[Netconf] Another comments on draft-ietf-netconf-subscribed-notifications-12

"Zhengguangying (Walker)" <zhengguangying@huawei.com> Thu, 14 June 2018 13:00 UTC

Return-Path: <zhengguangying@huawei.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CDF0713114B for <netconf@ietfa.amsl.com>; Thu, 14 Jun 2018 06:00:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EelgYw5o6lkn for <netconf@ietfa.amsl.com>; Thu, 14 Jun 2018 06:00:29 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 179A9130EE2 for <netconf@ietf.org>; Thu, 14 Jun 2018 06:00:29 -0700 (PDT)
Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 1B3707C4CA03D for <netconf@ietf.org>; Thu, 14 Jun 2018 14:00:25 +0100 (IST)
Received: from NKGEML412-HUB.china.huawei.com (10.98.56.73) by LHREML714-CAH.china.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 14 Jun 2018 14:00:27 +0100
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.193]) by nkgeml412-hub.china.huawei.com ([10.98.56.73]) with mapi id 14.03.0382.000; Thu, 14 Jun 2018 21:00:17 +0800
From: "Zhengguangying (Walker)" <zhengguangying@huawei.com>
To: "Eric Voit (evoit)" <evoit@cisco.com>, "alex@clemm.org" <alex@clemm.org>
CC: "netconf@ietf.org" <netconf@ietf.org>, Yangang <yangang@huawei.com>, "Wangxiaopeng (C)" <wangxiaopeng775@huawei.com>
Thread-Topic: [Netconf]Another comments on draft-ietf-netconf-subscribed-notifications-12
Thread-Index: AdQD3VIoWKNnD4LjRseldBZS2doJug==
Date: Thu, 14 Jun 2018 13:00:17 +0000
Message-ID: <381D7D55085B1E4D8B581BD652E1E140C92F2680@nkgeml513-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.134.169.155]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/sdAqU9MgKcN-XtXyu5n2iAc20G4>
Subject: [Netconf] Another comments on draft-ietf-netconf-subscribed-notifications-12
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 13:00:36 -0000

Hi Eric, Alex,

     In draft-ietf-netconf-subscribed-notifications-12  section "4.  Data Model",  the leafref to filters identifier was defined as a datatype as " typedef stream-filter-ref " , and this detatype are used in "configured-subscription" and " establish-subscription ".
     The issue is, when one does not support "/filters/" and use deviation file to deviate it as "not-supported", the target YANG file will have error when checking with yang tools, it lead to must support  "/filters/", I think it may not good to have this limit.
    
    One suggestion is not define the leaf ref to filter as a datatype, but use leafref directly when use " leafref " , what's your opinion?


Thanks 
Walker (Guangying)

PS:
Error: the node 'filters' from module 'ietf-subscribed-notifications' is not found
    
  typedef stream-filter-ref {
    type leafref {
      path "/sn:filters/sn:stream-filter/sn:identifier";
    }
    description
      "This type is used to reference an event stream filter.";
  }

  T 

rpcs:
    +---x establish-subscription
    |  +---w input
    |  |  +---w encoding?            encoding
    |  |  +---w (target)
    |  |  |  +--:(event-stream)
    |  |  |     +---w stream               stream
    |  |  |     +---w replay-start-time?   yang:date-and-time {replay}?
    |  |  +---w (applied-filter)
    |  |  |  +--:(by-reference)
    |  |  |  |  +---w filter-ref           filter-ref
    |  |  |  +--:(within-subscription)
    |  |  |     +---w (filter-type)?
    |  |  |        +--:(event-filter)
    |  |  |           +---w event-filter-type    event-filter-type
    |  |  |           +---w event-filter         <anyxml>
    |  |  +---w stop-time?           yang:date-and-time

+--rw subscription-config {configured-subscriptions}?
    |  +--rw subscription* [identifier]
    |     +--rw identifier           subscription-id
    |     +--rw encoding?            encoding
    |     +--rw (target)
    |     |  +--:(event-stream)
    |     |     +--rw stream               stream
    |     +--rw (applied-filter)
    |     |  +--:(by-reference)
    |     |  |  +--rw filter-ref           filter-ref
    |     |  +--:(within-subscription)
    |     |     +--rw (filter-type)?
    |     |        +--:(event-filter)
    |     |           +--rw event-filter-type    event-filter-type
    |     |           +--rw event-filter         <anyxml>
    |     +--rw stop-time?           yang:date-and-time
    |     +--rw receivers