IETF Logo Mail Archive

Re: [Netmod-ver-dt] draft-verdt-netmod-yang-module-versioning: Name of the “label-string” typedef.

"Joe Clarke (jclarke)" <jclarke@cisco.com> Tue, 10 September 2019 15:26 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: netmod-ver-dt@ietfa.amsl.com
Delivered-To: netmod-ver-dt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE4F51201E0 for <netmod-ver-dt@ietfa.amsl.com>; Tue, 10 Sep 2019 08:26:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=axrRGqnu; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=Lv1vKd3d
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HAlUbsoi33TC for <netmod-ver-dt@ietfa.amsl.com>; Tue, 10 Sep 2019 08:26:38 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5576B1201C6 for <netmod-ver-dt@ietf.org>; Tue, 10 Sep 2019 08:26:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=14869; q=dns/txt; s=iport; t=1568129198; x=1569338798; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=I7aG+CMmkZiFWTattH8YmzUw1TPT7BS2xm6O7CVZIKY=; b=axrRGqnuOzIJW10deoy1F/din7+jJFfUyXfNFnfnIUWqCRBYxQXTeU66 AfLIOc5yROQESJVSlXIHaIsYrRDvf/keF9rVBoCfw/6G0wK+e9vG5xbcp UkRqX6oo855Nwoh1KNDnWw6NIY9y0XGdD6mJP7mdP5QkUZxE8+K1fg8eE A=;
IronPort-PHdr: 9a23:/vM30h+5Ot40zv9uRHGN82YQeigqvan1NQcJ650hzqhDabmn44+8ZB7E/fs4iljPUM2b8P9Ch+fM+4HYEW0bqdfk0jgZdYBUERoMiMEYhQslVcyODUThL/PCZC0hF8MEX1hgrDm2
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0BwAACfv3dd/4ENJK1kGwEBAQEDAQEBBwMBAQGBVgMBAQELAYEVL1ADbVYgBAsWFIQhg0cDinqVcIRcglIDVAkBAQEMAQEYAQoKAgEBg3pFAheCMiM3Bg4CAwkBAQQBAQECAQYEbYUuDIVLAgEDAQEQER0BASwLAQ8CAQg7BAMCAgIlCxQGCwEBBA4FIoMAAYEdTQMdAQIMnD4CgTiIYXOBMoJ9AQEFhQcYghYDBoE0AYt3GIFAP4E4H4JMPoJhAQGBS0MJglUygiaPQIUhJIh0jlIKgiGUdxuZCoM5ozQCBAIEBQIOAQEFgWgigVhwFTsqAYJBgkI4gzqFFIU/c4Epjn8BAQ
X-IronPort-AV: E=Sophos;i="5.64,489,1559520000"; d="scan'208,217";a="541465764"
Received: from alln-core-9.cisco.com ([173.36.13.129]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 10 Sep 2019 15:26:34 +0000
Received: from XCH-ALN-013.cisco.com (xch-aln-013.cisco.com [173.36.7.23]) by alln-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id x8AFQY3R001917 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL) for <netmod-ver-dt@ietf.org>; Tue, 10 Sep 2019 15:26:34 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-013.cisco.com (173.36.7.23) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 10 Sep 2019 10:26:34 -0500
Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 10 Sep 2019 10:26:33 -0500
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 10 Sep 2019 10:26:33 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/X/MI1OXcYmTjXjqqTu3gxRM8OYt3RL07AKJbqi8vlxXjLRr8s9R+5Hdm9z1LcJWUO/Br3nbWexozIYSbLkTuW46AkZkdzH6SLDaIAZmRV2oN4OEs/KWUpSnptL3SMXLytEI5zDsehA6gbnMlLJKnJa8JHMZAShn04vk/0caXYEYOrLWwafuBY1Q0QBP+cgmDt/jny/dENhITgAkuOXpx3dSi2snl8O+h2tmdvN3gKyYmVEzJb0oJZmOJS2/ha4XE8HFyAjkDxvMKJurH0oyzcwllL/ZU0o8V+IccQKAgYmnMIUC+BhGUOSdOneWipb6UuvM6YldaWeAucYLROiDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7aG+CMmkZiFWTattH8YmzUw1TPT7BS2xm6O7CVZIKY=; b=W0D8rD+EY6qLeF+GdiLCZ0fuNn9szY+Dw2KXqYuB8CUxrrLnYY2eJDZT67wZkzoxvYq7SKOkpQUL2A3SfizWIcLHbKvs0MKluKSbopA9aTTKYDksc69dB86zw8z69GvmopMjk0N+lQmbG+YnorAktJHALL4UUyWIxQ0XigParURwsHCbLb8rtWGCZkLliqmR9y0EKpsY4HERxy3T3uPEB3mAaXTMAJIWUGxhOG8kUnqB6d1neiJSa4KUFHPvy2LYcC6wCZ62EobLmJ80zID+wA6YxNPm+UaW6yHYM7rhuq+v6T/FRNMrEzvlvZBM2KRRU7t11fcpj5DFl7Ivl6ZH6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7aG+CMmkZiFWTattH8YmzUw1TPT7BS2xm6O7CVZIKY=; b=Lv1vKd3dWmLAG65pRyxPOMVUTRQN4FIvSuDWbRvIIeovc7kAuzPikPff/VWOaSr3Prixj5XdTFqsQIVO44eeT17B7O55plglqLtgmOf8bbp4E7hT+qIDn9FkCaVufW9qel7s0gssdgwkDo8W0WGpekwi2rtq6jGLVvY4o8TAirw=
Received: from DM6PR11MB3418.namprd11.prod.outlook.com (20.177.219.223) by DM6PR11MB3658.namprd11.prod.outlook.com (20.178.231.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14; Tue, 10 Sep 2019 15:26:32 +0000
Received: from DM6PR11MB3418.namprd11.prod.outlook.com ([fe80::ddcd:cbad:9978:4c68]) by DM6PR11MB3418.namprd11.prod.outlook.com ([fe80::ddcd:cbad:9978:4c68%5]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 15:26:32 +0000
From: "Joe Clarke (jclarke)" <jclarke@cisco.com>
To: "Rob Wilton (rwilton)" <rwilton@cisco.com>
CC: "netmod-ver-dt@ietf.org" <netmod-ver-dt@ietf.org>
Thread-Topic: [Netmod-ver-dt] draft-verdt-netmod-yang-module-versioning: Name of the “label-string” typedef.
Thread-Index: AdVm+wE2Dmj3+ZtsQieKxleIiqFjQAAPDIoAACnNR1AAA22rgA==
Date: Tue, 10 Sep 2019 15:26:32 +0000
Message-ID: <F576881F-C3C0-47D5-90A9-4B0F0FF628C7@cisco.com>
References: <MN2PR11MB436621235D4DA605303EC2F2B5B70@MN2PR11MB4366.namprd11.prod.outlook.com> <C886CD18-89DB-468C-891D-2C99EF78F779@cisco.com> <MN2PR11MB43665DCCFB50A9AC7B4FB55DB5B60@MN2PR11MB4366.namprd11.prod.outlook.com>
In-Reply-To: <MN2PR11MB43665DCCFB50A9AC7B4FB55DB5B60@MN2PR11MB4366.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=jclarke@cisco.com;
x-originating-ip: [2600:1700:b00:b239:3ce0:739a:f758:bfb5]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 92866f5c-5ad8-4bf0-f7b6-08d7360342af
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:DM6PR11MB3658;
x-ms-traffictypediagnostic: DM6PR11MB3658:
x-ms-exchange-purlcount: 1
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM6PR11MB36584831AC4DB377B0F2B2C2B8B60@DM6PR11MB3658.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 01565FED4C
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(189003)(199004)(51444003)(66476007)(229853002)(6506007)(6486002)(256004)(6116002)(14454004)(91956017)(66446008)(478600001)(76116006)(64756008)(46003)(102836004)(2906002)(6636002)(476003)(4326008)(25786009)(966005)(6246003)(486006)(186003)(76176011)(11346002)(446003)(7736002)(6436002)(99286004)(33656002)(2616005)(316002)(37006003)(5660300002)(81166006)(8936002)(81156014)(86362001)(53936002)(6512007)(236005)(71200400001)(71190400001)(36756003)(6306002)(54896002)(66556008)(6862004)(606006)(66946007)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3658; H:DM6PR11MB3418.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 4hLPAbdQwMf0Pgz+snIT5NrevsAtmu2FPdrYeBnSPTnghHTXNOjB9ALMo7Zy5/WMZDOj/Jn1vw66pyc+hRRRTU2ez0TXpTnIzA7qUxtDo0Fh/DhRfuQnuwzmkPbSoXxOSCX2e0fH5y/M5c9pKn3OPDrdmViB8PBLHZxshuazZ4nEPIfcF1NDifyg9XwJaJJK6YaAqLuNwZeJdRCF3OGmjeE2AIAOxfNmtHK/ilx3XXU8wtOrvZ+4M8svK6IHvZEcBdiqoBNzO2WnMk2Or4kVolBlmg2yIaT5ngO76qM2TFdwVUM3aWsjEpfnD2C5BiTViFSphUmcoJEaTAWH4Hq1x/sbWzTIZXKs1bEcIfBETcTuZtauFKb8zHW6UK1IGkYLVT8pzHqOmA5jn8BRMr1loh96VEploAAW49WGYx8y3Wo=
Content-Type: multipart/alternative; boundary="_000_F576881FC3C047D590A94B0F0FF628C7ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 92866f5c-5ad8-4bf0-f7b6-08d7360342af
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 15:26:32.6895 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wMs87ceMThy1aiwos3e3S5+7yYk9g/Wgih0ZFdd0qpld18uHdK0t3rMwd7o2OeLZnB+diAA2mOac7PNIJRN1kA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3658
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.23, xch-aln-013.cisco.com
X-Outbound-Node: alln-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod-ver-dt/NiuIFIbO2yi9S2pJdHOlpUWnvQ0>
Subject: Re: [Netmod-ver-dt] draft-verdt-netmod-yang-module-versioning: Name of the “label-string” typedef.
X-BeenThere: netmod-ver-dt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NetMod WG YANG Model Versioning Design Team <netmod-ver-dt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod-ver-dt/>
List-Post: <mailto:netmod-ver-dt@ietf.org>
List-Help: <mailto:netmod-ver-dt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Sep 2019 15:26:41 -0000

I think that it might be better to change the name of the typedef “label-string” to “revision-label-string”.

Is this OK?

It depends.  I think the prefix will be “rev:” right?  I opted to call the typedef in the server draft “version” simply because it will be always written server:version.
[RW]

Yes, in the packages draft I have the following leaf defined:
    leaf version {
      type rev:label-string;
      mandatory true;
      description
        "Uniquely identies a particular version of a YANG package.

         Follows the definition for revision labels defined in
         draft-verdt-nemod-yang-module-versioning, section XXX";
    }

Here, it looked like calling the type “rev:revision-label-string” might be cleaner.

Yeah, I see your point.  Even within the rev namespace, you might have a need for a different “label-string”.  I think it’s a good change to make in this context.

Joe


This is a very minor issue though!

Thanks.
Rob



Joe



Thanks,
Rob


_______________________________________________
Netmod-ver-dt mailing list
Netmod-ver-dt@ietf.org<mailto:Netmod-ver-dt@ietf.org>
https://www.ietf.org/mailman/listinfo/netmod-ver-dt

v2.23.0 | Report a Bug | By Email