IETF Logo Mail Archive

Re: [Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01

"Joe Clarke (jclarke)" <jclarke@cisco.com> Fri, 13 September 2019 20:05 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: netmod-ver-dt@ietfa.amsl.com
Delivered-To: netmod-ver-dt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26D30120118 for <netmod-ver-dt@ietfa.amsl.com>; Fri, 13 Sep 2019 13:05:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Yecv3OAc; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=YbCFbDi+
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vNcaFKjIBRMu for <netmod-ver-dt@ietfa.amsl.com>; Fri, 13 Sep 2019 13:05:44 -0700 (PDT)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C2761200FF for <netmod-ver-dt@ietf.org>; Fri, 13 Sep 2019 13:05:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=17375; q=dns/txt; s=iport; t=1568405144; x=1569614744; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=kGzgCAanrdl9U8yHX69dEbChLXuVVbBSm9e1mLjILNg=; b=Yecv3OAcMw2sbOMOXnTxfTwlFaArl/1UDiB4q1aE7Nzm9/1rmSsKwIB9 0K8dxHD+Y33yZyjCxzwy23X0/fZAy0IX+4J7kmOQT3i6BZ/XiF4ePBccs V00ejPFei8pnFmtxDN2KES/B/hN75G987he0a77nojbdg8S0+WfgqEp5G g=;
IronPort-PHdr: 9a23:0rqmfRY/t21vwhM96cnQNKz/LSx94ef9IxIV55w7irlHbqWk+dH4MVfC4el20gebRp3VvvRDjeee87vtX2AN+96giDgDa9QNMn1NksAKh0olCc+BB1f8KavoZCgzBsdPfFRk5Hq8d0NSHZW2ag==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0D1AACn9Xtd/4gNJK1mHQEBBQEHBQGBVQYBCwGBFS9QA21WIAQLKoQhg0cDim6CN5M5hFyBLoEkA1QJAQEBDAEBGxICAQGEPwIXgkkjNgcOAgMJAQEEAQEBAgEGBG2FLgyFSwIBAxIRHQEBNwEPAgEIQgICAjAlAQEEDieDAAGBHU0DHQECn3cCgTiIYXOBMoJ9AQEFgkeCSBiCFgmBNAGLdxiBQD+BEScME4JMPoIygXxUgk0ygiaNDYIzhSEkiHSNZG4KgiGHAY12G4I0cIZQhCGKdY83i3WLQQIEAgQFAg4BAQWBWQongVhwFWUBgkEJgjmDcoUUhT9zgSmOfwEB
X-IronPort-AV: E=Sophos;i="5.64,501,1559520000"; d="scan'208,217";a="331708373"
Received: from alln-core-3.cisco.com ([173.36.13.136]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 13 Sep 2019 20:05:42 +0000
Received: from XCH-ALN-016.cisco.com (xch-aln-016.cisco.com [173.36.7.26]) by alln-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id x8DK5gTt010263 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 13 Sep 2019 20:05:42 GMT
Received: from xhs-aln-002.cisco.com (173.37.135.119) by XCH-ALN-016.cisco.com (173.36.7.26) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 13 Sep 2019 15:05:42 -0500
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 13 Sep 2019 15:05:41 -0500
Received: from NAM01-BN3-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 13 Sep 2019 16:05:41 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5irXkHaeR+WMCkmOkmwIOWyKwj9Ka368/pY3Gh/U0mU5AgIr5v80GLJ0QRbbOqaNGXrZTAwEn5OxMkSfmrIRCO/z94EKpAE8B2In/7Y2dSzo1/ikN4snmW/2gwBTcAeDDwtow5jzm4aJgwrp1kRi2Rv1NIjLcKdtQsaqdcPEErITOpZPcE0vaOcXxLmiDx1z5+O1k+CvabWrh9vY2mZwPqTE3QkYUofK2XWCWtByQ3FVPEe5OjsqTURWPl20x1nHiaMU+H0wKskBRSsR/RfJMSOZJDb1wBjUfHhjAGmc5SW6XfbwCco3zpvwOCWeS9vrEEwwHpo4NcO8mSzjT39uQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kGzgCAanrdl9U8yHX69dEbChLXuVVbBSm9e1mLjILNg=; b=eaaEXT1ozBeQcsB+z77Ka43M2aFOYw2xfAcQ38lBOgziEx93u7upR2hbh/srlxHIhzE4JNLVXAx3w668n0iRVfyF8shLEDy1W96tIlJtLCIAmePSxQLF6KzpFX8DiY9pHMiu6VHa8a+4yqQ+X/nYkYfL7fvoCMMMppu7+qtWoMSpmORqa3p0JDBEB3VVynm62JQBHTtp8WJz+lRhExFXGGhj4rXOwlmNfZA08Qr9Tb2E7PYnVKnFZZkNJZZwqtnmju0vRs9if7A4fxUOoMk/WfpCQXEOiNHcSovA8F2ESaQVXM8C480ElMZMeV6yOwQKQAuzv/abNsbRsywm/j9SIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kGzgCAanrdl9U8yHX69dEbChLXuVVbBSm9e1mLjILNg=; b=YbCFbDi+ZoMSiRB3B4IE8e331AkPJVf7Pn2H9sZD1w/7DFS/7brP8av66czntUo6eAcu9mCizMFkw3XtQTsztLumBILGaT2IRsSWUxMp2fEcBgzrHiQ/g0vRWoAibmfKM0qMrdO5nraEirrliRxbx9T6elrSHvRt/7Gzrtm07Lg=
Received: from DM6PR11MB3418.namprd11.prod.outlook.com (20.177.219.223) by DM6PR11MB2955.namprd11.prod.outlook.com (20.177.217.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Fri, 13 Sep 2019 20:05:40 +0000
Received: from DM6PR11MB3418.namprd11.prod.outlook.com ([fe80::ddcd:cbad:9978:4c68]) by DM6PR11MB3418.namprd11.prod.outlook.com ([fe80::ddcd:cbad:9978:4c68%5]) with mapi id 15.20.2241.022; Fri, 13 Sep 2019 20:05:40 +0000
From: "Joe Clarke (jclarke)" <jclarke@cisco.com>
To: Balázs Lengyel <balazs.lengyel@ericsson.com>
CC: "netmod-ver-dt@ietf.org" <netmod-ver-dt@ietf.org>
Thread-Topic: [Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01
Thread-Index: AdVqNKnthC5BjNxRS1GW8Oyeg5frcwAOfOkA
Date: Fri, 13 Sep 2019 20:05:40 +0000
Message-ID: <0EA079EB-5F3C-4027-B463-F686645FD790@cisco.com>
References: <VI1PR0701MB22860937DD03832F4B6CBF09F0B30@VI1PR0701MB2286.eurprd07.prod.outlook.com>
In-Reply-To: <VI1PR0701MB22860937DD03832F4B6CBF09F0B30@VI1PR0701MB2286.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=jclarke@cisco.com;
x-originating-ip: [2600:1700:b00:b239:816f:dbed:f534:c683]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2c86ce3f-c460-422d-2be6-08d73885c088
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:DM6PR11MB2955;
x-ms-traffictypediagnostic: DM6PR11MB2955:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <DM6PR11MB295588C9C3FCEDB6CC4C0A02B8B30@DM6PR11MB2955.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0159AC2B97
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(199004)(189003)(71190400001)(99286004)(81156014)(25786009)(316002)(66446008)(8676002)(86362001)(33656002)(11346002)(102836004)(186003)(8936002)(478600001)(486006)(5660300002)(446003)(2616005)(6486002)(36756003)(76176011)(7736002)(46003)(229853002)(53386004)(66946007)(6512007)(236005)(4326008)(14454004)(606006)(6246003)(6436002)(76116006)(476003)(71200400001)(54896002)(81166006)(6116002)(6306002)(64756008)(6916009)(6506007)(66476007)(91956017)(256004)(66556008)(2906002)(53936002)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2955; H:DM6PR11MB3418.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: Yiz/Nr+GfOYS70P0KUx18ONkhRYg/1nLBGzUBgJR1nBhlNPg29K5G2vS1OnC/tPzQMk0LnDCHW7RsfhCELjvI/Zqa4Ji0lEBsuSJSsVDv6aPLNfPUTFvq80w8rXcVLCiIcLYnMxmxmAlGGCdZjO/I9w00Azn3i3dtaSqS7IqKdZUavujvXJojMxov/SktsPvtU5iXp4yh0/ezVElXRC2UD5nU4875jkZKkUbDDCrH4F5z4sHAOYCG64gpDw6+erlfS839Op/kUou3mGL+aSTW5XV0FWaclAqMR5dNN1w1kNqvD47MfN3iTbTmEuuLhs40h6xFFTM4fdXVZv7pFZQd+bJaKqVEI03bRXI30sXOByDk7bpwog9FBeJ4h2ONCOoH5iDaqjlv96DMTyt65bHxfWNQoSRuklV3Gmahk80bQo=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_0EA079EB5F3C4027B463F686645FD790ciscocom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c86ce3f-c460-422d-2be6-08d73885c088
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2019 20:05:40.6620 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r/00vPpXyrrpvB7YakqVD2RskRMa9BCQ6IwdKeihEwUZRwqztVAPYHyyaZJ/G4HY3YBd1A1jHcRHdIvgsTU5rQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2955
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.26, xch-aln-016.cisco.com
X-Outbound-Node: alln-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod-ver-dt/PBoghtbBUa3lfGs2qC9ep7aQINk>
Subject: Re: [Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01
X-BeenThere: netmod-ver-dt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NetMod WG YANG Model Versioning Design Team <netmod-ver-dt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod-ver-dt/>
List-Post: <mailto:netmod-ver-dt@ietf.org>
List-Help: <mailto:netmod-ver-dt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Sep 2019 20:05:46 -0000

Ch 1)
Add something like:
“The goal is to add a human readable version label that provides compatibility information for the module without comparing or parsing the module’s body.”
This is the whole reason to create this draft.

Thanks.  I incorporated some of this.  Please let me know if you like it.


Ch 2. And General) We really need to give our versioning scheme a “name” and refer to it as such. I propose “yangver”.

I left this as an open item for discussion.  I personally like yangver.  It gets auto-corrected to “hangover” on the Mac :-).


Ch 3.1 paragraph after the bullets)
Do we need to specify different metadata  types? Or is this text directly from semver?

Yes, this comes directly from server.org<http://server.org>.


Reword as it is hard to understand:
Old text:
   Versioning schemes that are not this modified semver MUST NOT use
   this same version pattern.  Other schemes may, for example, use
   additional leading characters to distinguish them from this semantic
   versioning scheme.
New text:
   Other version schemes MUST use versioning strings that do not match the format and the pattern specified for yangver , e.g. use
   additional leading characters to distinguish them from yangver.

Thanks!  The original text was a pain.  I tweaked it based on your recommendation.


Ch 3.4.2) I have not read the package draft recently, but does this example imply that a package has a single revision-label? IMHO for each revision a description, reference and revision label is needed.

I don’t follow this exactly.  Each revision of a package will have its own revision label, reference, and description.


Ch 4) Shouldn’t we allow any BC version to be used for import even if it is not in the revision history.

Good question.  I left that open to the team.


Ch 5.) I would find a more descriptive name for the typedef e.g. yangver

If we settle on yangver, I’ll update the prefix.  Then it would typically be written as yangver:version.  Would that be sufficient?

Joe

v2.23.0 | Report a Bug | By Email