Re: [Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01

"Rob Wilton (rwilton)" <rwilton@cisco.com> Tue, 17 September 2019 14:00 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: netmod-ver-dt@ietfa.amsl.com
Delivered-To: netmod-ver-dt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BEA31120059 for <netmod-ver-dt@ietfa.amsl.com>; Tue, 17 Sep 2019 07:00:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=QDrxbgLk; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=m/0iDsGQ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ksOTLMGrCMou for <netmod-ver-dt@ietfa.amsl.com>; Tue, 17 Sep 2019 07:00:31 -0700 (PDT)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9E47712002E for <netmod-ver-dt@ietf.org>; Tue, 17 Sep 2019 07:00:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=21576; q=dns/txt; s=iport; t=1568728831; x=1569938431; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=CiPOmrfVN4W03arycfMgiJTzIYEq3tmSl9gS/Jy0/gU=; b=QDrxbgLk6b0AfOVYRXXqQQXH4HCnDUEaoMYDCHtd6KlXEcEuhR5iDxkG EanYYX0MVy8EgbfvSiIzBnPuC91lCRA2vmrHB8Ld82sBHY/WwMlh1fs6A lKJFgSCyUONWFA8n+ZcTtTsY7yvSt8mkaWvxsr58ZBMKoVgaaBM/O4amI c=;
IronPort-PHdr: 9a23:ZPFBkR1nLV7TgNUmsmDT+zVfbzU7u7jyIg8e44YmjLQLaKm44pD+JxKHt+51ggrPWoPWo7JfhuzavrqoeFRI4I3J8RVgOIdJSwdDjMwXmwI6B8vQE1L6KOLtaQQxHd9JUxlu+HToeUU=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0B9AwDd5YBd/5xdJa1mGwEBAQEDAQEBBwMBAQGBZ4EWL1ADbVYgBAsqCodeA4p1TYIPl3KBQoEQA1QJAQEBDAEBLQIBAYQ/AoJ8IzgTAgMJAQEEAQEBAgEFBG2FLgyFSgEBAQEDEhsTAQE4DwIBCBEEAQEhBwcyFAkIAQEEARIIGoMBgR1NAx0BAqJYAoE4iGGCJYJ9AQEFhQwYghcJgTSFAIZ4GIFAP4ERRoJMPoQRARIBITSDB4ImlHYkXYgcjXJuCoIilRyCNYdHhCWKeY4KmQQCBAIEBQIOAQEFgWkhZ3FwFYMngkKDcopTc4EpjQiBIgGBIgEB
X-IronPort-AV: E=Sophos;i="5.64,516,1559520000"; d="scan'208,217";a="327762318"
Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 17 Sep 2019 14:00:30 +0000
Received: from XCH-RCD-007.cisco.com (xch-rcd-007.cisco.com [173.37.102.17]) by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id x8HE0U2a023907 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 17 Sep 2019 14:00:30 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-007.cisco.com (173.37.102.17) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 17 Sep 2019 09:00:29 -0500
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 17 Sep 2019 10:00:28 -0400
Received: from NAM01-SN1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 17 Sep 2019 09:00:28 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AiDOwmcc3uEkRu6DIaXmFaE1rBBgt1W6zhWfUZYKiSn8l3JYPUrtzgHGWq9yGE+f9x+ZxdCZ302btiF/ojzXiPKHgkLspZZ9D9hUE0unDAeeTTnQ68Gx5pLzk5DjNkvIwGk+FifN48wGvqZfV9rguqqA1WbFoC+u2wNnsa+rzOtDfJH4sOGGNGt4DHYvnG3maukJHkzlSdqPVD9fKPNeX1F9DKHkKaB2w3Fe/JU5Eq6oTivfjPMAsgk4rSI9vWjO/ODIJuhusqJ4PBRrlpy4p3PYT7y1wkRzfLKf30zJkJVhiWqPG5i80Yp3FjkSbMbD11eg6N9VQWFmsjm8uc+xZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+rtf4kbTI3ebJksYUpYJH+4a13g1bCWAaxEKkIkTPhk=; b=DeGnc+juA62q0c4wQJQo5C9XnDMszKKUtkuLWr6kUwPowSt31uJPHPDEJ14zrKHj+UFALk8FUKhje89LtggEOELtYBDgC92creZGssdggY6VSRot9ry0AmTur0UjwSf7burDQCPMQWCBjzDaqZxl33uVDMDUgBTRHxpsqEqiYR2lKGQp/tnnOg+LFrixk8Pg3e+1rXbxkgLsslvPrcOBbMLsnYYE+Wv+cuO60X++ywFTG6/FxT6dciFF+xYmv/xz6zKjbbFNenlODW0nTogeeFrxF0fLOhvjDTgmpR8HvCRFKM/hZuXm7jZYO4L3no7C9RzC02oXTWFXXm4rfVZ94Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+rtf4kbTI3ebJksYUpYJH+4a13g1bCWAaxEKkIkTPhk=; b=m/0iDsGQyYB8uhUgnhA5ezmqS1dRZH6agI7kFH8CD5/QAyTEdS5ISO7LG+kpiq6mE67GX2kuQ0P6cBttYJuuzotN84/+LoTRcyLt0zsJvWHa3Ea1Cy2pDIY6oGZ2D61r6UMe5KpmI9qi0RJVZ9RfJgWo5d74jaCV+P3RpImQXR0=
Received: from MN2PR11MB4366.namprd11.prod.outlook.com (52.135.38.209) by MN2PR11MB4432.namprd11.prod.outlook.com (52.135.39.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.15; Tue, 17 Sep 2019 14:00:26 +0000
Received: from MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::6db3:f4c:467b:30f6]) by MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::6db3:f4c:467b:30f6%7]) with mapi id 15.20.2263.023; Tue, 17 Sep 2019 14:00:26 +0000
From: "Rob Wilton (rwilton)" <rwilton@cisco.com>
To: Balázs Lengyel <balazs.lengyel@ericsson.com>, "netmod-ver-dt@ietf.org" <netmod-ver-dt@ietf.org>
Thread-Topic: Balazs Review of draft-verdt-netmod-yang-semver-01
Thread-Index: AdVqNKnthC5BjNxRS1GW8Oyeg5frcwDKlF7A
Date: Tue, 17 Sep 2019 14:00:26 +0000
Message-ID: <MN2PR11MB4366649896FB31112F7D1A15B58F0@MN2PR11MB4366.namprd11.prod.outlook.com>
References: <VI1PR0701MB22860937DD03832F4B6CBF09F0B30@VI1PR0701MB2286.eurprd07.prod.outlook.com>
In-Reply-To: <VI1PR0701MB22860937DD03832F4B6CBF09F0B30@VI1PR0701MB2286.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rwilton@cisco.com;
x-originating-ip: [173.38.220.61]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e2c19263-7cb7-4c0d-e1a6-08d73b776471
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR11MB4432;
x-ms-traffictypediagnostic: MN2PR11MB4432:
x-microsoft-antispam-prvs: <MN2PR11MB4432525336D06559273A08E5B58F0@MN2PR11MB4432.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01630974C0
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(51444003)(199004)(189003)(7736002)(52536014)(71200400001)(76176011)(66556008)(11346002)(33656002)(110136005)(66476007)(66066001)(64756008)(66946007)(66446008)(7696005)(2501003)(25786009)(476003)(14454004)(66574012)(102836004)(6506007)(53546011)(478600001)(26005)(229853002)(316002)(186003)(99286004)(76116006)(256004)(71190400001)(2906002)(3846002)(6436002)(6246003)(86362001)(5660300002)(6116002)(55016002)(790700001)(8936002)(9686003)(81166006)(81156014)(236005)(9326002)(74316002)(486006)(54896002)(6306002)(446003)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4432; H:MN2PR11MB4366.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: oRH+OmNJGaEM2EZXuA/KSug9js0v8cxqcLf55ThhEGhToPCLpbi8EcyC6kTI2YcZB6NjdojCwpBSzCZf6tSUtKYZH3TIZtwkVz2RmWL77fFLKjCSisbdZ6btru2bAZXbCSz+BeEmYtS4+vhJqFA6wsWjgMg2+YzeYbZo6UfXD5s9nTsSZ5I7fRBEd6/UMqLUUCfU1oOsVtUGja65U/5iaWsow3adKbhHghdpCXm8vKnYJs34uq57nDWCgbY6pRlPeztjIK8HRpkrMvwOXizzcewM1YERQV2WVjbTyECIHJGaiLKWVGHchXlQRPJ5lbIYJAGu12K+ymMvF35rO52TZwgY1rnmSCLd5f17S+TDi3Rd13g6S4ZSvLnDNFmhDMHi7eMh91SQWnLVBX1JAyWGfZNTS/PcvmkWGPcrv8WIdI0=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_MN2PR11MB4366649896FB31112F7D1A15B58F0MN2PR11MB4366namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e2c19263-7cb7-4c0d-e1a6-08d73b776471
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2019 14:00:26.7217 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pKosWa5n8PEchhKT/UIXIJI3Xxd5LL+EeWxl03H8W/M3hldF3kBas3sCZbW9i1w71RxNaNIhoqN8K8z4HdQUwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4432
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.17, xch-rcd-007.cisco.com
X-Outbound-Node: rcdn-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod-ver-dt/my0dxLAC5xTElopKYyw_dRcdgnw>
Subject: Re: [Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01
X-BeenThere: netmod-ver-dt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NetMod WG YANG Model Versioning Design Team <netmod-ver-dt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod-ver-dt/>
List-Post: <mailto:netmod-ver-dt@ietf.org>
List-Help: <mailto:netmod-ver-dt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod-ver-dt>, <mailto:netmod-ver-dt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Sep 2019 14:00:35 -0000

Hi Balazs,

Please see further comments inline ...

From: Netmod-ver-dt <netmod-ver-dt-bounces@ietf.org> On Behalf Of Balázs Lengyel
Sent: 13 September 2019 14:35
To: netmod-ver-dt@ietf.org
Subject: [Netmod-ver-dt] Balazs Review of draft-verdt-netmod-yang-semver-01

Hello Joe,
Some comments:
General: I would like this to be merged with module-versioning.
[RW]
I don't think that we should do this.  I'm pretty sure that both Martin and Andy would strongly object to this, so I think that this would end up just slowing the work down.


-        I would like this to be main-stream. It may be optional, but it should be the single recommended scheme.
[RW]
I agree that it should be mainstream, and should be the single recommended scheme.  But I think that it is OK to allow other labels/schemes.


-        Putting restrictions on "other" schemes that use the revision label can not be enforced. If they don't support this draft/RFC they will never know what they are not allowed to do.
[RW]
Agreed.  The plan is to write this restriction into the parent module-versioning draft.  I will send proposed/text updated doc soon.


-        A YANG module with a single typedef looks really strange.
After workgroup adoption I would raise this issue again.

Ch 1)
Add something like:
"The goal is to add a human readable version label that provides compatibility information for the module without comparing or parsing the module's body."
This is the whole reason to create this draft.

Ch 2. And General) We really need to give our versioning scheme a "name" and refer to it as such. I propose "yangver".
[RW]
I've been calling in "YANG semantic versioning".  If we want a shorter name for it, perhaps "yang-semver" would be a bit more descriptive.

Ch 3.1 paragraph after the bullets)
Do we need to specify different metadata  types? Or is this text directly from semver?

Reword as it is hard to understand:
Old text:
   Versioning schemes that are not this modified semver MUST NOT use
   this same version pattern.  Other schemes may, for example, use
   additional leading characters to distinguish them from this semantic
   versioning scheme.
New text:
   Other version schemes MUST use versioning strings that do not match the format and the pattern specified for yangver , e.g. use
   additional leading characters to distinguish them from yangver.

Ch 3.4.2) I have not read the package draft recently, but does this example imply that a package has a single revision-label? IMHO for each revision a description, reference and revision label is needed.
[RW]
Each instance (i.e. version) of a YANG package has a single "revision-label" (actually called "version" in the latest package draft).

At the moment, it is proposed that YANG packages do not need to record the full revision history as part of the package definition.  They just store the current version, and also the previous one, allowing a full revision tree to be constructed, if required.

Thanks,
Rob




Ch 4) Shouldn't we allow any BC version to be used for import even if it is not in the revision history.

Ch 5.) I would find a more descriptive name for the typedef e.g. yangver

Regards Balazs

--
Balazs Lengyel                    Senior Specialist                       Ericsson Hungary Ltd.
Mobile: +36-70-330-7909              email: Balazs.Lengyel@ericsson.com<mailto:Balazs.Lengyel@ericsson.com>