[netmod] Yangdoctors last call review of draft-ietf-netmod-system-config-06

Michal Vaško via Datatracker <noreply@ietf.org> Thu, 13 June 2024 10:24 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: netmod@ietf.org
Delivered-To: netmod@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 781F9C1519A3; Thu, 13 Jun 2024 03:24:54 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Michal Vaško via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.15.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171827429448.18522.14394499042657937658@ietfa.amsl.com>
Date: Thu, 13 Jun 2024 03:24:54 -0700
Message-ID-Hash: 3ZXKUT62M3OY262IRTVW2ODSZ5VXV3LR
X-Message-ID-Hash: 3ZXKUT62M3OY262IRTVW2ODSZ5VXV3LR
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-netmod.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-netmod-system-config.all@ietf.org, last-call@ietf.org, netmod@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Michal Vaško <mvasko@cesnet.cz>
Subject: [netmod] Yangdoctors last call review of draft-ietf-netmod-system-config-06
List-Id: NETMOD WG list <netmod.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/-6H4sZQCGK6jGDAZqcgTN6SUMwU>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Owner: <mailto:netmod-owner@ietf.org>
List-Post: <mailto:netmod@ietf.org>
List-Subscribe: <mailto:netmod-join@ietf.org>
List-Unsubscribe: <mailto:netmod-leave@ietf.org>

Reviewer: Michal Vaško
Review result: Ready with Nits

This is my yang-doctor review of draft-ietf-netmod-system-config, which
includes 2 small YANG modules, in addition to a few example modules.

ietf-system-datastore:
- small module with a single identity, no issues

ietf-netconf-resolve-system:
- module with similar simple augments to standard ietf-netconf and
ietf-netconf-nmda modules, no issues

As for the example YANG modules and data, there are a few nits:

example-acl:
- leaf-list application - path is not indented

Section 8.2 BGP examples:
- 'inet:port' type does not exist in the latest ietf-inet-types (2013) YANG
module, only 'port-number' - all 'local-as' and 'peer-as' nodes are uint32, so
in JSON encoding numbers should be used instead of strings - 'local-port' is
using uint16 type so in JSON encoding numbers should be used instead of strings

Finally, the examples and their data are using YANG snippets and data without
namespaces or module names, which may be fine for illustration purposes but
possibly confusing.