Re: [netmod] Proposal to enhance the YANG tree output

Martin Bjorklund <mbj@tail-f.com> Mon, 25 September 2017 17:36 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C05E0134515 for <netmod@ietfa.amsl.com>; Mon, 25 Sep 2017 10:36:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xTdUPjpfvfNX for <netmod@ietfa.amsl.com>; Mon, 25 Sep 2017 10:36:42 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 4B3BC1320CF for <netmod@ietf.org>; Mon, 25 Sep 2017 10:36:42 -0700 (PDT)
Received: from localhost (h-40-225.A165.priv.bahnhof.se [94.254.40.225]) by mail.tail-f.com (Postfix) with ESMTPSA id 7D8461AE02A7; Mon, 25 Sep 2017 19:36:41 +0200 (CEST)
Date: Mon, 25 Sep 2017 19:39:03 +0200 (CEST)
Message-Id: <20170925.193903.1777711656523405872.mbj@tail-f.com>
To: acee@cisco.com
Cc: lhotka@nic.cz, netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <D5EEA5E2.C9623%acee@cisco.com>
References: <1505470900.18681.0.camel@nic.cz> <D5E153B9.C80CF%acee@cisco.com> <D5EEA5E2.C9623%acee@cisco.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/0FkexloKNb505TWJL0NAfTL0TG8>
Subject: Re: [netmod] Proposal to enhance the YANG tree output
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Sep 2017 17:36:52 -0000

"Acee Lindem (acee)" <acee@cisco.com> wrote:
> Martin, Lada, et al,
> 
> While I don’t think we need additional annotations that Joe had prototyped
> (at least not as the default), I strongly believe we need to keep the ‘@‘
> and ‘/‘ in the tree output for schema mount.

Can you explain what information "/" gives the reader?  Compare these
two trees:

  +--mp vrf-root
     +--rw rt:routing/
        +--rw rt:router-id

and

  +--mp vrf-root
     +--rw rt:routing
        +--rw rt:router-id

What did the "/" in the first tree tell me that I don't see in the
second tree?



Then consider:

  +--ro if:interfaces@

and

  +--ro if:interfaces
     +-- if:interface@

and

  +--ro if:interfaces@
     +-- if:interface@
     

Which ones are legal, and what do they mean?



/martin

While the former enhancement
> provided details, the schema mount tree designations are every bit as
> important as knowing, for example, whether or not a schema leaf is a
> presence node. 
> 
> Thanks,
> Acee 
> 
> 
> On 9/15/17, 9:56 AM, "Acee Lindem (acee)" <acee@cisco.com> wrote:
> 
> >+1 - Also it is hard enough to format the tree output to fit in a draft
> >w/o further annotations (even with —-tree-line-length).
> >Thanks,
> >Acee
> >
> >
> >On 9/15/17, 6:21 AM, "netmod on behalf of Ladislav Lhotka"
> ><netmod-bounces@ietf.org on behalf of lhotka@nic.cz> wrote:
> >
> >>Andy Bierman píše v Čt 14. 09. 2017 v 08:43 -0700:
> >>> Hi,
> >>> 
> >>> 
> >>> Actually I liked the early pyang output that was concise and easy to
> >>>remember.
> >>> The current format gets very cluttered and there are too many little
> >>>symbols
> >>> to remember them all.
> >>
> >>I agree.
> >>
> >>Lada
> >>
> >>> 
> >>> 
> >>> Andy
> >>> 
> >>> 
> >>> On Thu, Sep 14, 2017 at 8:33 AM, Joe Clarke <jclarke@cisco.com> wrote:
> >>> > I've been hacking on pyang, and I changed tree.py to add the enum
> >>>values
> >>> > for enumeration types and identiyref bases for identityref types.
> >>>Here
> >>> > is an example:
> >>> > 
> >>> > module: yang-catalog
> >>> >     +--rw catalog
> >>> >        +--rw modules
> >>> >        |  +--rw module* [name revision organization]
> >>> >        |     +--rw name                     yang:yang-identifier
> >>> >        |     +--rw revision                 union
> >>> >        |     +--rw organization             string
> >>> >        |     +--rw ietf
> >>> >        |     |  +--rw ietf-wg?   string
> >>> >        |     +--rw namespace                inet:uri
> >>> >        |     +--rw schema?                  inet:uri
> >>> >        |     +--rw generated-from?          enumeration [mib, code,
> >>> > not-applicable, native]
> >>> >        |     +--rw maturity-level?          enumeration [ratified,
> >>> > adopted, initial, not-applicable]
> >>> > ...
> >>> >                                +--rw protocols
> >>> >                                |  +--rw protocol* [name]
> >>> >                                |     +--rw name
> >>> > identityref -> protocol
> >>> > ...
> >>> > 
> >>> > My questions are:
> >>> > 
> >>> > 1. Is this useful?
> >>> > 
> >>> > 2. If so, can this be added to pyang (happy to submit a PR) and
> >>> > draft-ietf-netmod-yang-tree-diagrams?
> >>> > 
> >>> > 3. What changes to the output format would you recommend?
> >>> > 
> >>> > Thanks.
> >>> > 
> >>> > Joe
> >>> > 
> >>> > _______________________________________________
> >>> > netmod mailing list
> >>> > netmod@ietf.org
> >>> > https://www.ietf.org/mailman/listinfo/netmod
> >>> 
> >>> _______________________________________________
> >>> netmod mailing list
> >>> netmod@ietf.org
> >>> https://www.ietf.org/mailman/listinfo/netmod
> >>-- 
> >>Ladislav Lhotka
> >>Head, CZ.NIC Labs
> >>PGP Key ID: 0xB8F92B08A9F76C67
> >>
> >>_______________________________________________
> >>netmod mailing list
> >>netmod@ietf.org
> >>https://www.ietf.org/mailman/listinfo/netmod
> >
>