Re: [netmod] Fwd: [Gen-art] Review: draft-ietf-netmod-rfc6021-bis-01
Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Tue, 30 April 2013 11:49 UTC
Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1FF221F9A52; Tue, 30 Apr 2013 04:49:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -103.249
X-Spam-Level:
X-Spam-Status: No, score=-103.249 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HELO_EQ_DE=0.35, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rYhmVz2y4gMC; Tue, 30 Apr 2013 04:49:08 -0700 (PDT)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) by ietfa.amsl.com (Postfix) with ESMTP id EF90521F9B2F; Tue, 30 Apr 2013 04:49:07 -0700 (PDT)
Received: from localhost (demetrius2.jacobs-university.de [212.201.44.47]) by hermes.jacobs-university.de (Postfix) with ESMTP id 7367B20C12; Tue, 30 Apr 2013 13:49:07 +0200 (CEST)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius2.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id 2Mg_MdkrI39T; Tue, 30 Apr 2013 13:49:07 +0200 (CEST)
Received: from elstar.local (elstar.jacobs.jacobs-university.de [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id D35A520C06; Tue, 30 Apr 2013 13:49:06 +0200 (CEST)
Received: by elstar.local (Postfix, from userid 501) id D66D825EB6AA; Tue, 30 Apr 2013 13:49:05 +0200 (CEST)
Date: Tue, 30 Apr 2013 13:49:05 +0200
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: Benoit Claise <bclaise@cisco.com>, "Joel M. Halpern" <jmh@joelhalpern.com>
Message-ID: <20130430114905.GA47531@elstar.local>
Mail-Followup-To: Benoit Claise <bclaise@cisco.com>, "Joel M. Halpern" <jmh@joelhalpern.com>, draft-ietf-netmod-rfc6021-bis.all@tools.ietf.org, gen-art@ietf.org, netmod@ietf.org
References: <5171C416.5070105@joelhalpern.com> <517F9AEF.8090601@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <517F9AEF.8090601@cisco.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: draft-ietf-netmod-rfc6021-bis.all@tools.ietf.org, gen-art@ietf.org, netmod@ietf.org
Subject: Re: [netmod] Fwd: [Gen-art] Review: draft-ietf-netmod-rfc6021-bis-01
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/netmod>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Apr 2013 11:49:12 -0000
On Tue, Apr 30, 2013 at 12:20:31PM +0200, Benoit Claise wrote: > Hi, > > Just making sure that you saw this one. > Next to the APPSDIR review, I believe that this is the one review left. > Thanks for forwarding this. Answers inline. Thanks to Joel Halpern to review this document. > > > -------- Original Message -------- > Subject: [Gen-art] Review: draft-ietf-netmod-rfc6021-bis-01 > Date: Fri, 19 Apr 2013 18:24:22 -0400 > From: Joel M. Halpern <jmh@joelhalpern.com> > To: A. Jean Mahoney <mahoney@nostrum.com> > CC: gen-art@ietf.org, IETF discussion list <ietf@ietf.org> > > > > I am the assigned Gen-ART reviewer for this draft. For background on > Gen-ART, please see the FAQ at > > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > Please resolve these comments along with any other Last Call comments > you may receive. > > Document: draft-ietf-netmod-rfc6021-bis-01 > Common YANG Data Types > Reviewer: Joel M. Halpern > Review Date: 19-April-2013 > IETF LC End Date: 1-May-2013 > IESG Telechat date: N/A > > Summary: This document is nearly ready for publication as a Standards > Track RFC > > Major issues: > (The following may well be a non-issue.) > In the revision of the ietf-inet-types, the patterns for the new > ip4-address-no-zone and ipv6-address-no-zone are drastically simplified > from the ipv4-address and ipv6-address patterns. The new > ipv4-address-no-zone allows any sequence of decimal digits an periods, > while the original was carefully defined as dotted quads of 0..255. > Similarly, te ipv6-address-no-zone allows any arbitrary sequence of hex > digits and colons. The original patterns were very careful to match > rules for validity. Is there a reason for the change. Joel, note that ip4-address-no-zone and ipv6-address-no-zone are _derived_ from the ipv4-address and ipv6-address types: typedef ipv4-address-no-zone { type inet:ipv4-address { pattern '[\.0-9]*'; } // ... } typedef ipv6-address-no-zone { type inet:ipv6-address { pattern '[0-9a-fA-F:]*'; } // ... } This means that all rules for ipv4-address and ipv6-address respectively apply and in addition the patterns for ip4-address-no-zone and ipv6-address-no-zone apply. In other words, the pattern in the -no-zone versions only aim to eliminate the zone identifier by eliminating the % symbol. Your comment, however, made Lada discover that I missed to allow the . for IPv4-mapped IPv6 addresses. This was not my intention and is indeed a bug that I think needs to be fixed. There is a thread on the netmod mailing list about this. > Minor issues: > > Nits/editorial comments: > /js -- Juergen Schoenwaelder Jacobs University Bremen gGmbH Phone: +49 421 200 3587 Campus Ring 1, 28759 Bremen, Germany Fax: +49 421 200 3103 <http://www.jacobs-university.de/>
- Re: [netmod] Fwd: [Gen-art] Review: draft-ietf-ne… Juergen Schoenwaelder
- Re: [netmod] [Gen-art] Review: draft-ietf-netmod-… Benoit Claise
- Re: [netmod] [Gen-art] Review: draft-ietf-netmod-… Benoit Claise
- Re: [netmod] [Gen-art] Review: draft-ietf-netmod-… Juergen Schoenwaelder
- Re: [netmod] [Gen-art] Review: draft-ietf-netmod-… Joel M. Halpern
- Re: [netmod] [Gen-art] Review: draft-ietf-netmod-… Jari Arkko