Re: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Fri, 20 October 2017 12:51 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1E2E133011; Fri, 20 Oct 2017 05:51:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DqLJpVQYyqwW; Fri, 20 Oct 2017 05:51:04 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 38D0B132944; Fri, 20 Oct 2017 05:51:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1814; q=dns/txt; s=iport; t=1508503864; x=1509713464; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=obpCEASMK0Le+n9GI5aACJ487SMxCdqWFdbLrPp9r8E=; b=HYxl98W59RYYlOHDUSHX7KTOlgwlgl6m3eCFDEiDqK0UqOUOt8IongH/ 6YHtDoL1lFyseAJhp1Pg9YXFte7hLuVqMAqA/UZUe2+fHgxKrB1rcUFPa jdJ/JdiY7BpnxqB0+f/IVvTN5vDVryk+ScJHB2/EGXpmB9fje70hcfXg0 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CjAQDe7+lZ/40NJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg19kbicHhj+XEoF6hCcBApILEIIBChgLhElPAoQ5QBcBAgEBAQE?= =?us-ascii?q?BAQFrKIUdAQEBBAEBbAsQAgEIEQQBAQolDxgLHQgCBAENBYogEKwSiyABAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEBAQEYBYMuggeBUIUThG0YhXUFkhmPQwKUb5MclUkCERk?= =?us-ascii?q?BgTgBIAE2gVt6FUmCZIRfdogWLIEFgREBAQE?=
X-IronPort-AV: E=Sophos;i="5.43,405,1503360000"; d="scan'208";a="304019680"
Received: from alln-core-8.cisco.com ([173.36.13.141]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Oct 2017 12:51:03 +0000
Received: from xch-rcd-011.cisco.com (xch-rcd-011.cisco.com [173.37.102.21]) by alln-core-8.cisco.com (8.14.5/8.14.5) with ESMTP id v9KCp3bA001011 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 20 Oct 2017 12:51:03 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-RCD-011.cisco.com (173.37.102.21) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 20 Oct 2017 07:51:02 -0500
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1320.000; Fri, 20 Oct 2017 07:51:02 -0500
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "Eric Voit (evoit)" <evoit@cisco.com>, "draft-ietf-netmod-rfc6087bis@ietf.org" <draft-ietf-netmod-rfc6087bis@ietf.org>
CC: "netmod-chairs@ietf.org" <netmod-chairs@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14
Thread-Index: AQHTK/QA8+mcxSk5vUmECY2lUkQ4OqLoEwSAgADU1oCAABYiAIAANyAAgAO1vdA=
Date: Fri, 20 Oct 2017 12:51:02 +0000
Message-ID: <1508503864559.35322@cisco.com>
References: <DE7DEC2E-F737-4020-8830-AF556A65EEF5@juniper.net> <001701d3470b$8f473fe0$add5bfa0$@clemm.org> <EA300017-CDE0-4006-95D5-D2E81CBBE9E3@juniper.net> <644DA50AFA8C314EA9BDDAC83BD38A2E0EAB6C8C@sjceml521-mbx.china.huawei.com>, <4862029103bb46d7b56013331d9e2d3c@XCH-RTP-013.cisco.com>
In-Reply-To: <4862029103bb46d7b56013331d9e2d3c@XCH-RTP-013.cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.86.245.114]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/1fzTkdO62JoZpYbzHNBvO9m17L8>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Oct 2017 12:51:06 -0000

Regarding validation, section 3.10 refers to pyang tool. Since the set of tools might change in the future, shouldn't the reference be to the yangvalidator url or something along those lines (instead of an exhaustive list which may change)?

I think there is a nit in section 2.4, the '.' after [I-D.ietf-netmod-revised-datastores] should be removed or replaced by a comma.

Regards,
Reshad.
________________________________________
From: netmod <netmod-bounces@ietf.org> on behalf of Eric Voit (evoit)
Sent: Tuesday, October 17, 2017 7:06 PM
To: draft-ietf-netmod-rfc6087bis@ietf.org
Cc: netmod-chairs@ietf.org; netmod@ietf.org
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14

I was also encouraged to provide comments.  A couple (new?) minor ones...

Section 3.4:
- If a tree diagram is included for an augmented model, it SHOULD contain the integrated of the augmented model.  I.e., use the pyang -f command to generate the tree so that you can explicitly see the schema elements imported

Side comment: if a YANG module contains extension structures (like YANG-Data) these should also be shown in the tree, but I understand why you might not want to make that a requirement of this document.

Section 3.10: There should be a normative set of YANG validation tools which are run on upload of an Internet draft.   Errors and warnings found later (and perhaps through tools a user doesn't have) should not result in a module being given an error designation.

Thanks,
Eric


_______________________________________________
netmod mailing list
netmod@ietf.org
https://www.ietf.org/mailman/listinfo/netmod