[netmod] RtgDir review: Review of draft-ietf-netmod-yang-tree-diagrams-05.txt
Stig Venaas <stig@venaas.com> Mon, 29 January 2018 23:09 UTC
Return-Path: <stig@venaas.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E04E130A97 for <netmod@ietfa.amsl.com>; Mon, 29 Jan 2018 15:09:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5_P1dlFbHP71 for <netmod@ietfa.amsl.com>; Mon, 29 Jan 2018 15:09:37 -0800 (PST)
Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A50CC12EC54 for <netmod@ietf.org>; Mon, 29 Jan 2018 15:09:37 -0800 (PST)
Received: by mail-qk0-x230.google.com with SMTP id l29so7810022qkj.8 for <netmod@ietf.org>; Mon, 29 Jan 2018 15:09:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc; bh=xpt035imEKRIoFJeCDAlTje7OHK5iMVT/aqCTblKyxM=; b=BeoILL06xhZchllkokHBLeYDe3xKmRChQvUwgWzr1kn/ds8K52FVcXzzvPyxipmi9O sraiRwjPxLGIdPRMnDftLiF4ygarmXgvwFYpZnpgtiXgkqbbGn4H+mHtya3HK7LF6Flt KyLx7iOK47ZT7GSrRM6cpCfAOXvfqECmihqyEgdN0j4zjb1WeNPtsNERk3lA0tFuWI67 WG81C1xJV9Dffyy4tedPF1jLIkKCQIiFPCoorrdBsQjZnwNG9He1K4TWdBovcWMzwEYc 70+HVB+dcQlN6+vgGBPPPWLoFzBsAubEg+NCrn/xZ9GDaEVDlVqm3QWa9WS9RGe/sQNJ +cBg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=xpt035imEKRIoFJeCDAlTje7OHK5iMVT/aqCTblKyxM=; b=qXzV8FBWCSTAXagUDDxpxlCb4TwFdlVDt9Zq94MziOnAS/rBRXwczIhVhDuGFUZQUr TUn3Emb8GUY2N8we/JcBuXqUs1+BPNqDklhNMoAl5hXnZN9+gV9vR/biPLP+OG3nY2e1 lduOfjG0SLNlmlbcf6BN+6fne7Rxb7dNWbrgmPPW5kSEUAjbQk0/693lFgvc8l76z1ej nlharLiU0YL8Psw2XkQKEPf8ENAUwwrZBm2QOvsy7mH+VYEQFwSKI2tvxREpzHsF5leT EnG5qb2IsoL4w086vwrV13LF+123jShFtkDItOWyns0f2ybH/GlwHPUNyIYDo9vrpezg UdeQ==
X-Gm-Message-State: AKwxytdobh8jbKjoQaux3zTLmFE6hmlI+b1xzBkqHG+PB+QJ8Kjdkx0Q EWf95fO0ZZustaM68J4KUPvf4wdyNAIOoblCOi1d+a0iX8A=
X-Google-Smtp-Source: AH8x224l5pALqjU92fUif1YfUYzIeA2sBJ8SpqZX4z0jra40rNXOYb9S05kUcRIU/tSifedEUB3hDBtUFhkS/dCsuo8=
X-Received: by 10.55.137.197 with SMTP id l188mr25359519qkd.84.1517267376763; Mon, 29 Jan 2018 15:09:36 -0800 (PST)
MIME-Version: 1.0
Received: by 10.140.84.149 with HTTP; Mon, 29 Jan 2018 15:09:36 -0800 (PST)
From: Stig Venaas <stig@venaas.com>
Date: Mon, 29 Jan 2018 15:09:36 -0800
Message-ID: <CAHANBtKXMYLY-sAc9DoOf7BfXhezix-W+ET+3K3_Uu5xp0hnfA@mail.gmail.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Cc: rtg-dir@ietf.org, draft-ietf-netmod-yang-tree-diagrams.all@ietf.org, netmod@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/3gedkGiRm3miCzx0OGUKVneia7Q>
Subject: [netmod] RtgDir review: Review of draft-ietf-netmod-yang-tree-diagrams-05.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 23:09:39 -0000
Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-netmod-yang-tree-diagrams-05.txt Reviewer: Stig Venaas Review Date: 2018-01-29 IETF LC End Date: 2018-02-07 Intended Status: Best Current Practice Summary: This document is basically ready for publication, but has nits that should be considered prior to publication. Comments: The draft is well written and ready for publication except for perhaps two nits. My YANG skills are a bit limited though, so it is possible that I may have missed issues. Major Issues: No major issues found. Minor Issues: No minor issues found. Nits: In the introduction it says: Today's common practice is to include the definition of the syntax used to represent a YANG module in every document that provides a tree diagram. This practice has several disadvantages and the purpose of the document is to provide a single location for this ^^^^ definition. It is not the intent of this document to restrict future changes, but rather to ensure such changes are easily identified and suitably agreed upon. It would be better to say "this document". In section 2 it says: A module is identified by "module:" followed the module-name. In the introduction [RFC7223] Section 3 is given as an example tree diagram, but this does not start with "module:". Would another example be better? It might also be good to have a richer example that makes use of most of the defined symbols. Otherwise the document looks great to me. Stig
- [netmod] RtgDir review: Review of draft-ietf-netm… Stig Venaas
- Re: [netmod] RtgDir review: Review of draft-ietf-… Martin Bjorklund