IETF Logo Mail Archive

Re: [netmod] Yangdoctors last call review of draft-ietf-netmod-factory-default-07

Qin Wu <bill.wu@huawei.com> Sat, 30 November 2019 13:04 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 775ED1200CE; Sat, 30 Nov 2019 05:04:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SVrzKeSA-dhF; Sat, 30 Nov 2019 05:04:52 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E38821200C7; Sat, 30 Nov 2019 05:04:51 -0800 (PST)
Received: from lhreml702-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 8587BCD981E165145DDF; Sat, 30 Nov 2019 13:04:47 +0000 (GMT)
Received: from lhreml720-chm.china.huawei.com (10.201.108.71) by lhreml702-cah.china.huawei.com (10.201.108.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 30 Nov 2019 13:04:22 +0000
Received: from lhreml720-chm.china.huawei.com (10.201.108.71) by lhreml720-chm.china.huawei.com (10.201.108.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 30 Nov 2019 13:04:22 +0000
Received: from DGGEML422-HUB.china.huawei.com (10.1.199.39) by lhreml720-chm.china.huawei.com (10.201.108.71) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Sat, 30 Nov 2019 13:04:22 +0000
Received: from DGGEML511-MBX.china.huawei.com ([169.254.1.151]) by dggeml422-hub.china.huawei.com ([10.1.199.39]) with mapi id 14.03.0439.000; Sat, 30 Nov 2019 21:04:15 +0800
From: Qin Wu <bill.wu@huawei.com>
To: Carl Moberg <calle@tail-f.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-netmod-factory-default.all@ietf.org" <draft-ietf-netmod-factory-default.all@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-netmod-factory-default-07
Thread-Index: AdWnfpoyxUMTFL8PT2ypzqOv8wtfzw==
Date: Sat, 30 Nov 2019 13:04:15 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABAA94A9EDB@dggeml511-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.134.31.203]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/3hVQ_dkIEuUV2czEqzkZn0BeEeY>
Subject: Re: [netmod] Yangdoctors last call review of draft-ietf-netmod-factory-default-07
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Nov 2019 13:04:53 -0000

Thanks Carl and will fix them.

-Qin
-----邮件原件-----
发件人: Carl Moberg via Datatracker [mailto:noreply@ietf.org] 
发送时间: 2019年11月27日 22:35
收件人: yang-doctors@ietf.org
抄送: last-call@ietf.org; draft-ietf-netmod-factory-default.all@ietf.org; netmod@ietf.org
主题: Yangdoctors last call review of draft-ietf-netmod-factory-default-07

Reviewer: Carl Moberg
Review result: Ready with Nits

This is my YANG doctors review of the ietf-factory-default.yang module as part of draft-ietf-netmod-factory-default-07.

The module cleanly passes validation using the YANG validator site and I have successfully loaded it into one NETCONF server implementation.

This module is ready with a cosmetic nit and a suggestion.

I suggest fixing the following textual nit:

OLD
       configuration datastores (i.e.,<running> , <startup><candidate>) to
       their factory default content.";

NEW:
       configuration datastores (i.e. <running>, <startup>, and
       <candidate>) to their factory default content.";

I suggest adding a revision-date to the filename in the <CODE BEGINS> block.

OLD:
 <CODE BEGINS> file "ietf-factory-default.yang"

 NEW:
 <CODE BEGINS> file "ietf-factory-default@2019-11-27.yang"

 (Obviously replacing the date with the release date of the module)

v2.23.0 | Report a Bug | By Email