[netmod] Genart last call review of draft-ietf-netmod-factory-default-14

Stewart Bryant via Datatracker <noreply@ietf.org> Thu, 12 March 2020 13:11 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: netmod@ietf.org
Delivered-To: netmod@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1DFFF3A07B6; Thu, 12 Mar 2020 06:11:53 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Stewart Bryant via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: netmod@ietf.org, last-call@ietf.org, draft-ietf-netmod-factory-default.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.120.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <158401871305.18111.17946808218973342191@ietfa.amsl.com>
Reply-To: Stewart Bryant <stewart.bryant@gmail.com>
Date: Thu, 12 Mar 2020 06:11:53 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/404wLhGtLGbl4VWF9g4KGpXhTV4>
Subject: [netmod] Genart last call review of draft-ietf-netmod-factory-default-14
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 13:11:54 -0000

Reviewer: Stewart Bryant
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-netmod-factory-default-14
Reviewer: Stewart Bryant
Review Date: 2020-03-12
IETF LC End Date: 2020-03-16
IESG Telechat date: Not scheduled for a telechat

Summary: A well written document that is pretty much ready to go. I only have
one concern and that is whether the overwrite pattern needs some text so that
it does not accidentally become a covert channel.

Major issues: None

Minor issues:

 "All security sensitive data (i.e., private keys, passwords, etc.)  SHOULD be
 overwritten with zeros or a pattern before deletion.  "

"a pattern" is possibly vague, and care needs to be taken that this is not a
covert channel. Possibly it needs to say something like "an implementation
specific common pattern"?

Nits/editorial comments:

Nits contains a warning about references, but one concerns text that will
removed, and the other is a format error that will be fixed in publication

I saw the SecDir comment on RPC. This is a starred term in the abbreviation
list and does not technically need expanding.