Re: [netmod] rfc6991bis: yang:longitude, yang:latitude, yang:postal-code, yang:country-code

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Thu, 30 July 2020 16:23 UTC

Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B66873A0BCA; Thu, 30 Jul 2020 09:23:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U_QyWRcedCUP; Thu, 30 Jul 2020 09:23:29 -0700 (PDT)
Received: from atlas5.jacobs-university.de (atlas5.jacobs-university.de [212.201.44.20]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 698893A0BCE; Thu, 30 Jul 2020 09:23:29 -0700 (PDT)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas5.jacobs-university.de (Postfix) with ESMTP id CACB9D6B; Thu, 30 Jul 2020 18:23:27 +0200 (CEST)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas5.jacobs-university.de ([10.70.0.198]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10032) with ESMTP id gggGh-CIE3tY; Thu, 30 Jul 2020 18:23:27 +0200 (CEST)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "DFN-Verein Global Issuing CA" (verified OK)) by atlas5.jacobs-university.de (Postfix) with ESMTPS; Thu, 30 Jul 2020 18:23:27 +0200 (CEST)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by hermes.jacobs-university.de (Postfix) with ESMTP id 6F03420154; Thu, 30 Jul 2020 18:23:27 +0200 (CEST)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10028) with ESMTP id b_2jgJPkLmF3; Thu, 30 Jul 2020 18:23:26 +0200 (CEST)
Received: from localhost (anna.jacobs.jacobs-university.de [10.50.218.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by hermes.jacobs-university.de (Postfix) with ESMTPS id CBCD7200E4; Thu, 30 Jul 2020 18:23:26 +0200 (CEST)
Date: Thu, 30 Jul 2020 18:23:26 +0200
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: Qin Wu <bill.wu@huawei.com>, "netmod@ietf.org" <netmod@ietf.org>
Cc: chopps@chopps.org, netmod-chairs@ietf.org
Message-ID: <20200730162326.b2pcn646d2bk45iy@anna.jacobs.jacobs-university.de>
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
Mail-Followup-To: Qin Wu <bill.wu@huawei.com>, "netmod@ietf.org" <netmod@ietf.org>, chopps@chopps.org, netmod-chairs@ietf.org
References: <B8F9A780D330094D99AF023C5877DABAAD8A8660@dggeml511-mbs.china.huawei.com> <20200730140251.q7hwxc6j4kxuy5vq@anna.jacobs.jacobs-university.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200730140251.q7hwxc6j4kxuy5vq@anna.jacobs.jacobs-university.de>
X-Clacks-Overhead: GNU Terry Pratchett
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/4coZhsEXp8_3T0J7wkDZWq8c1pM>
Subject: Re: [netmod] rfc6991bis: yang:longitude, yang:latitude, yang:postal-code, yang:country-code
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2020 16:23:33 -0000

Looking in the I-Ds, I see that draft-ietf-netmod-geo-location-05
defines a grouping geo-location. draft-ietf-teas-yang-te-topo-22
has:

          +--ro geolocation
             +--ro altitude?    int64
             +--ro latitude?    geographic-coordinate-degree
             +--ro longitude?   geographic-coordinate-degree

You might simply use the grouping here that comes out of
draft-ietf-netmod-geo-location-05 - but then the grouping is
also a bit more complex than what you have.

Unfortunately, draft-ietf-netmod-geo-location-05 does not define
helper types. The latitude and longitude leafs are simply decimal64s
with all details spelled out inline:

             leaf latitude {
               type decimal64 {
                 fraction-digits 16;
               }
               units "decimal degrees";
               description
                 "The latitude value on the astronomical body. The
                  definition and precision of this measurement is
                  indicated by the reference-frame value.";
             }
             leaf longitude {
               type decimal64 {
                 fraction-digits 16;
               }
               units "decimal degrees";
               description
                 "The longitude value on the astronomical body. The
                  definition and precision of this measurement is
                  indicated by the reference-frame.";
             }

The teas document has

     typedef geographic-coordinate-degree {
         type decimal64 {
           fraction-digits 8;
         }
         description
           "Decimal degree (DD) used to express latitude and longitude
            geographic coordinates.";
     }
     
     leaf latitude {
       type geographic-coordinate-degree {
         range "-90..90";
       }
       description
         "Relative position north or south on the Earth's surface.";
     }

     leaf longitude {
       type geographic-coordinate-degree {
         range "-180..180";
       }
       description
         "Angular distance east or west on the Earth's surface.";
     }

Note also the differences in the precision. Obviously,
draft-ietf-netmod-geo-location-05 could have defined
helper types like

    typedef latitude {
      type decimal64 {
          fraction-digits 16;
      }
      units "decimal degrees";
      description
         "The latitude value on the astronomical body.";
    }

    typdef longitude {
      type decimal64 {
          fraction-digits 16;
      }
      units "decimal degrees";
      description
        "The longitude value on the astronomical body. The
         definition and precision of this measurement is
         indicated by the reference-frame.";
    }

and a bunch more and used them to define the leafs. These types could
then have been reused in situations where the grouping in all its
details is not needed.

I am not entirely sure where draft-ietf-netmod-geo-location-05 is in
the WG process, the datatracker says "In WG Last Call, Revised I-D
Needed - Issue raised by WGLC" - so perhaps there is a chance to get
the inline type definitions factored out so that they can be reused.

I think this is something where the input from Chris Hopps and the
NETMOD chairs is important to determine the path forward. Since we
have an ietf-geo-location module, I would prefer to have common types
for location information defined there and not in yang-types.

/js

On Thu, Jul 30, 2020 at 04:02:51PM +0200, Juergen Schoenwaelder wrote:
> But then perhaps draft-ietf-netmod-geo-location-05 needs to be updated
> or you need to use a grouping. I think we should not have overlapping
> work in different documents.
> 
> /js
> 
> On Thu, Jul 30, 2020 at 01:54:43PM +0000, Qin Wu wrote:
> > That is a good option, but draft-ietf-netmod-geo-location-05 only define grouping, there is typedef for longitude and latitude, altitude. 
> > 
> > -Qin
> > -----邮件原件-----
> > 发件人: Juergen Schoenwaelder [mailto:j.schoenwaelder@jacobs-university.de] 
> > 发送时间: 2020年7月30日 21:32
> > 收件人: Qin Wu <bill.wu@huawei.com>
> > 抄送: netmod@ietf.org
> > 主题: Re: [netmod] rfc6991bis: yang:longitude, yang:latitude, yang:postal-code, yang:country-code
> > 
> > But there is draft-ietf-netmod-geo-location-05... What about using the types defined in there?
> > 
> > /js
> > 
> > On Thu, Jul 30, 2020 at 01:28:17PM +0000, Qin Wu wrote:
> > > See geolocation definition in draft-ietf-teas-yang-te-topo-22 which defines longitude and latitude, altitude.
> > > I know it is beneficial for future document to import these types from rfc6991bis instead of from te topo model.
> > > 
> > > -Qin
> > > -----邮件原件-----
> > > 发件人: netmod [mailto:netmod-bounces@ietf.org] 代表 Juergen Schoenwaelder
> > > 发送时间: 2020年7月18日 3:16
> > > 收件人: netmod@ietf.org
> > > 主题: [netmod] rfc6991bis: yang:longitude, yang:latitude, 
> > > yang:postal-code, yang:country-code
> > > 
> > >   - It was suggested to add types for longitude, latitude, postal
> > >     code, country-code. Do we go there or do we leave these for other
> > >     modules to define? It seems such definitions should go into
> > >     draft-ietf-netmod-geo-location.
> > > 
> > >   - Geo location is covered by draft-ietf-netmod-geo-location
> > >     (so do nothing).
> > > 
> > >   - For country codes, there is ISO 3166, which defines two-letter,
> > >     three-letter, and numeric country codes. I assume people wanted
> > >     two-letter codes (as used in the DNS), i.e. they want DE and not
> > >     DEU. But note that it is GB and not UK, i.e., what we commonly
> > >     use in the DNS may not be exactly ISO 3166. (The devil is always
> > >     in the details.)
> > > 
> > >   - For postal codes, it is unclear what the requirements are or what
> > >     a proper definition for postal codes is. It is not entirely clear
> > >     what the authoritative definition of the format of postal codes
> > >     is, perhaps the Universal Postal Union.
> > > 
> > >   - Options: (i) do nothing or (ii) add a country code definition
> > >     only or (iii) add both a country code definition and a postal
> > >     code definition (which might be to some extend vague)
> > > 
> > >   - Proposal: do nothing
> > >   
> > > -- 
> > > Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> > > Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> > > Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>
> > > 
> > > _______________________________________________
> > > netmod mailing list
> > > netmod@ietf.org
> > > https://www.ietf.org/mailman/listinfo/netmod
> > 
> > -- 
> > Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> > Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> > Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>
> 
> -- 
> Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>

-- 
Juergen Schoenwaelder           Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>