Re: [netmod] ACL draft issues found during shepherd writeup

Joe Clarke <jclarke@cisco.com> Mon, 26 February 2018 22:14 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCB22126DFB; Mon, 26 Feb 2018 14:14:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jWb6vmvl-yDg; Mon, 26 Feb 2018 14:14:17 -0800 (PST)
Received: from bgl-iport-4.cisco.com (bgl-iport-4.cisco.com [72.163.197.28]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB0011200B9; Mon, 26 Feb 2018 14:14:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2149; q=dns/txt; s=iport; t=1519683257; x=1520892857; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=/6CAHB2/7ZiwgqHF37gfo75bAAhML1Ih0i13Zz9cdKI=; b=AyTqmYwRwNLGxxp3eM8ApRTk7+d5iN1dcomwasmVu0ZrcyBKWtTmgvk4 H0NVpKxuR6/e1LgsjK2zGF0b9GteTgCWrPkmy2LNGFDdBzTd9CPhO68+R wBLv5HvP9/A63E5HysRFcPoVJ56C8miFL/qa3FeLZqp/lPezkcnLAB77D M=;
X-IronPort-AV: E=Sophos;i="5.47,398,1515456000"; d="scan'208";a="61532923"
Received: from vla196-nat.cisco.com (HELO bgl-core-1.cisco.com) ([72.163.197.24]) by bgl-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2018 22:14:14 +0000
Received: from [10.66.246.15] (syd-vpn-client-246-15.cisco.com [10.66.246.15]) by bgl-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id w1QMECbg001241; Mon, 26 Feb 2018 22:14:13 GMT
To: Eliot Lear <lear@cisco.com>, Mahesh Jethanandani <mjethanandani@gmail.com>, Kent Watsen <kwatsen@juniper.net>
Cc: "draft-ietf-netmod-acl-model@ietf.org" <draft-ietf-netmod-acl-model@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>, Warren Kumari <warren@kumari.net>
References: <14BA9086-69D4-4BAF-A7C7-0EB1F3F400BB@juniper.net> <2864E0CF-D038-4FDA-B69C-FD43F486BF17@gmail.com> <8D3773A8-ECA6-406A-B28D-6DD44F951F10@juniper.net> <02D4541E-FF83-41AD-A026-A1AB857E0A62@gmail.com> <1a4a3f5d-5211-8b13-308e-3b124c836135@cisco.com>
From: Joe Clarke <jclarke@cisco.com>
Organization: Cisco
Message-ID: <5a9866b8-6809-003c-2663-b27ecd373d51@cisco.com>
Date: Mon, 26 Feb 2018 17:14:11 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1a4a3f5d-5211-8b13-308e-3b124c836135@cisco.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/5TbZ3PS11PVwqhq5qWk1mDho8qc>
Subject: Re: [netmod] ACL draft issues found during shepherd writeup
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Feb 2018 22:14:18 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/26/18 03:15, Eliot Lear wrote:
> 
> 
> On 26.02.18 06:55, Mahesh Jethanandani wrote:
>>> 
>>>> 
>>>> 
>>>> PS: And this is not a shepherd directive, but I found the
>>>> whole "source-port-range-or-operator" syntax clumsy.  I'm
>>>> surprised it didn't look something like:
>>>> 
>>>> OLD <source-port-range-or-operator> <port-range-or-operator> 
>>>> <range> <lower-port>16384</lower-port> 
>>>> <upper-port>65535</upper-port> </range> 
>>>> </port-range-or-operator> </source-port-range-or-operator>
>>>> 
>>>> <source-port-range-or-operator> <port-range-or-operator> 
>>>> <operator> <operator>eq</operator> <port>21</port> 
>>>> </operator> </port-range-or-operator> 
>>>> </source-port-range-or-operator>
>>>> 
>>>> NEW
>>>> 
>>>> <source-port> <range> <lower>16384</lower> 
>>>> <upper>65535</upper> </range> </source-port>
>>>> 
>>>> <source-port> <operator> <operator>eq</operator> 
>>>> <port>21</port> </operator> </source-port>
>>>> 
>>> 
>>> Did you try making the change in the model to see if it work?
>>> It will complain that <range> is already used within the
>>> container and that it cannot be repeated (for
>>> destination-port).
>>> 
>>> <KENT> No, I did not, nor do I intend to get that deep into it.
>>> But I recall that Kristian made the same comment before, and
>>> was making pull requests before, so maybe he can suggest
>>> something?
>> 
>> Kristian’s suggestion requires changing the module. It is not an 
>> editorial change. And that change will have an impact on the MUD 
>> draft, which has been sent for publication.
>> 
> 
> As it happens, we found a bug in our augment statements, and so we
> will need to rev one more time.  If the change can be made quickly,
> I can live with it.

- From an opsawg chair perspective, I am fine with this.  Warren may
want to weigh in from the AD perspective.

Joe
-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQTMiWQHc8wChijkr7lvaI+K/hTPhwUCWpSGsQAKCRBvaI+K/hTP
h/NaAKCEhW2WJnfscTPSTlvbDyzsyWfPiACghHZgtMO0sCl49m3NWnLnt126Z1c=
=EEbu
-----END PGP SIGNATURE-----