Re: [netmod] [Editorial Errata Reported] RFC7950 (5642)

Andy Bierman <andy@yumaworks.com> Thu, 21 February 2019 18:15 UTC

Return-Path: <andy@yumaworks.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CEFA1310A2 for <netmod@ietfa.amsl.com>; Thu, 21 Feb 2019 10:15:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h40EyehA814F for <netmod@ietfa.amsl.com>; Thu, 21 Feb 2019 10:14:59 -0800 (PST)
Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3774913109F for <netmod@ietf.org>; Thu, 21 Feb 2019 10:14:59 -0800 (PST)
Received: by mail-lf1-x131.google.com with SMTP id m11so21061501lfc.6 for <netmod@ietf.org>; Thu, 21 Feb 2019 10:14:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERqw5PUaPC0sUS6Nv8ner+sgcDXSPdoqLj3hMBW2ATM=; b=S+Cplxwy1Ay3MpXtK57kky/43WHYl1TK9NiaRxao8LPrX1RCBVvHEMoA5wCKm7g9qY Unta6vtmtuCtxVLTttRaEw0I38dgpfm265NusiZ/TLTVJVzoGswkA5Avik1eY95CXzmd NAcwIwPeohZj6QiU4o5InBpuORP/8hgefXeh8asni55DM54OXZLz14laWHXrB5OGAUit QTAz1xkGOKzmnfJiznEGO6wt8QdGaE8JgrEG4uL2Z5xwhSzAMwRDXTXdeaPSDGOgcjbK IcRRFMNR4EDl9RBtBubpZnu5/+LhHDML64KqZRskfNS2oZnf7ZEb225c1ZRpccv7FsBK jkTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERqw5PUaPC0sUS6Nv8ner+sgcDXSPdoqLj3hMBW2ATM=; b=fGoQKeCYyNHhqhh6UcqiXoaU7rtUEkivyHg1YUZ5TPl7I4z4kTjIUhXe/1x8eqTTLo uCKiOKCtKmoYE3bAfYxuNPpYnEFTBywhO8iPV9LQjSvPY07L2aOC49eBgy4BxzfW7Vq0 9YoejggZLKKff0zjPY2wXEjDS+dEqjni5MoKaM3wNLCDR8M8hmPD1ypeWiIN5I/+63dF rBocwcxpBLDxhiCG92CWF6xzVTia5OstxnJ16/Qy9ZuMR+SxQFQ9kgtiS660hgdOMc2h CxqhcUmoGBxkI+GfzWEbkOcHnp8ZdjNvJLp+1IJmO9CKo/BtuN/DlVAA0nReUkSV3rew Qq/g==
X-Gm-Message-State: AHQUAub9JQwc6BP4A9NIkHJ8WSWQLxSE+sj+hp8gq7emDKptFHiA48+/ AetkvuI7+NQi6VrFPHMdpFSFq0RJCoDv8rGGiphsWw==
X-Google-Smtp-Source: AHgI3Iaadk2lAaS38/4NTpaTvV4kIEEMT3Pmb+g40lfK42OvMx2VWhBXy48zISk7Az7uB1eeJEhLhJR3776fHZH2Ax8=
X-Received: by 2002:ac2:5489:: with SMTP id t9mr23899636lfk.49.1550772896787; Thu, 21 Feb 2019 10:14:56 -0800 (PST)
MIME-Version: 1.0
References: <20190221163919.5196EB81AF4@rfc-editor.org> <20190221.175336.1995849216024607593.mbj@tail-f.com> <CABCOCHQMAq-vzANerP3ehY1y9fiiQZKY_S4dEh0qfhO=7bS8hA@mail.gmail.com> <HE1PR0701MB29053FE1EC7A4F199C688050EA7E0@HE1PR0701MB2905.eurprd07.prod.outlook.com>
In-Reply-To: <HE1PR0701MB29053FE1EC7A4F199C688050EA7E0@HE1PR0701MB2905.eurprd07.prod.outlook.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Thu, 21 Feb 2019 10:14:45 -0800
Message-ID: <CABCOCHQMB8KD9Z8zXw8uxLOrcBE7_RqNFGRmJfNmoQ=TvFUaDg@mail.gmail.com>
To: Peter Loborg <peter.loborg@ericsson.com>
Cc: Martin Bjorklund <mbj@tail-f.com>, RFC Editor <rfc-editor@rfc-editor.org>, Ignas Bagdonas <ibagdona@gmail.com>, NetMod WG <netmod@ietf.org>, Warren Kumari <warren@kumari.net>
Content-Type: multipart/alternative; boundary="000000000000a4210805826b7364"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/8Q7p1Qqtks2_gClh5BAp1fuk_Do>
Subject: Re: [netmod] [Editorial Errata Reported] RFC7950 (5642)
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Feb 2019 18:15:03 -0000

On Thu, Feb 21, 2019 at 10:07 AM Peter Loborg <peter.loborg@ericsson.com>
wrote:

>
>
> Your example is fine – but the gammar is ch14 specifies something
> different:
>
>
>
> enum-stmt           = enum-keyword sep string optsep
>
>                          (";" /
>
>                           "{" stmtsep
>
>                               ;; these stmts can appear in any order
>
>                               *if-feature-stmt
>
>                               [value-stmt]
>
>                               [status-stmt]
>
>                               [description-stmt]
>
>                               [reference-stmt]
>
>                            "}") stmtsep
>
>
>
> It clearly states  string, not quoted-string. These two have the following
> rules:
>
>
>
> quoted-string       = (DQUOTE string DQUOTE) / (SQUOTE string SQUOTE)
>
>
>
> string              = < an unquoted string, as returned by >
>
>                          < the scanner, that matches the rule >
>
>                          < yang-string >
>
>
>


The text in 9.6.4 is correct.
The ABNF is wrong.



> …and in 6.1.3 we can read that:
>
>    An unquoted string is any sequence of characters that does not
>
>    contain any space, tab, carriage return, or line feed characters, a
>
>    single or double quote character, a semicolon (";"), braces ("{" or
>
>    "}"), or comment sequences ("//", "/*", or "*/").
>
>
>
>    Note that any keyword can legally appear as an unquoted string.
>
>
>
> Since the section so clearly writes about single quoted strings and double
> quoted strings, there can unfortunately be no interpretation that would
> allow “identifier” to be called an unquoted string – even though it follows
> the rules about limited character contents.
>
>
>
> Hence – this is not a matter of opinion – it’s a matter of reading what’s
> actually written in the RFC.
>
>
>
> But on the subject of opinion…
>
>
>
>       enum "This is also legal";   // should definitely always be illegal
>
>
>
> …as we cannot create a language binding to enum constructs in any major
> programming languages.
>
>
>

There are many aspects of YANG that do not map directly to programming
languages,
such as allowing '.' in identifiers.



> Br,
>
> Peter
>


Andy


>
>
>
>
> *From:* Andy Bierman <andy@yumaworks.com>
> *Sent:* den 21 februari 2019 18:45
> *To:* Martin Bjorklund <mbj@tail-f.com>
> *Cc:* RFC Editor <rfc-editor@rfc-editor.org>; Ignas Bagdonas <
> ibagdona@gmail.com>; NetMod WG <netmod@ietf.org>; Peter Loborg <
> peter.loborg@ericsson.com>; Warren Kumari <warren@kumari.net>
> *Subject:* Re: [netmod] [Editorial Errata Reported] RFC7950 (5642)
>
>
>
>
>
>
>
> On Thu, Feb 21, 2019 at 8:53 AM Martin Bjorklund <mbj@tail-f.com> wrote:
>
> RFC Errata System <rfc-editor@rfc-editor.org> wrote:
> > The following errata report has been submitted for RFC7950,
> > "The YANG 1.1 Data Modeling Language".
> >
> > --------------------------------------
> > You may review the report below and at:
> > http://www.rfc-editor.org/errata/eid5642
> >
> > --------------------------------------
> > Type: Editorial
> > Reported by: Peter Loborg <peter.loborg@ericsson.com>
> >
> > Section: 9.6.4
> >
> > Original Text
> > -------------
> > It takes as an argument a string that is the assigned name.
> >
> > Corrected Text
> > --------------
> > It takes as an argument an unquoted string that is the assigned name.
>
> This is not correct.  The enum argument is not different from any
> other keyword's arguments in YANG.  See e.g. the example in 9.12.4:
>
>        type enumeration {
>          enum "unbounded";
>        }
>
> The following is also legal:
>
>          enum "unb" + 'ounded';
>
>
>
>
>
>   enum "This is also legal";
>
>
>
> 9.6.4.  The "enum" Statement
>
>
>
>    The "enum" statement, which is a substatement to the "type"
>
>    statement, MUST be present if the type is "enumeration".  It is
>
>    repeatedly used to specify each assigned name of an enumeration type.
>
>    It takes as an argument a string that is the assigned name.  *The*
>
> *   string MUST NOT be zero-length and MUST NOT have any leading or*
>
> *   trailing whitespace characters* (any Unicode character with the
>
>    "White_Space" property).  The use of Unicode control codes SHOULD be
>
>    avoided.
>
>
>
>
>
> This errata should be rejected.
>
>
>
> /martin
>
>
>
>
>
> Andy
>
>
>
>
> >
> > Notes
> > -----
> > Readers are not beeing made aware that careful reading of section 6.1.3
> and the detailed definition of string in section 14 must be consulted.
> > For comming versions of this RFC it would be preferable to use a more
> specialized grammar token for these cases (e.g. unquoted-string).
> >
> > Instructions:
> > -------------
> > This erratum is currently posted as "Reported". If necessary, please
> > use "Reply All" to discuss whether it should be verified or
> > rejected. When a decision is reached, the verifying party
> > can log in to change the status and edit the report, if necessary.
> >
> > --------------------------------------
> > RFC7950 (draft-ietf-netmod-rfc6020bis-14)
> > --------------------------------------
> > Title               : The YANG 1.1 Data Modeling Language
> > Publication Date    : August 2016
> > Author(s)           : M. Bjorklund, Ed.
> > Category            : PROPOSED STANDARD
> > Source              : Network Modeling
> > Area                : Operations and Management
> > Stream              : IETF
> > Verifying Party     : IESG
> >
>
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod
>
>