Re: [netmod] I-D Action: draft-ietf-netmod-syslog-model-19.txt

Kent Watsen <kwatsen@juniper.net> Wed, 17 January 2018 16:58 UTC

Return-Path: <kwatsen@juniper.net>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D9D412D9FE for <netmod@ietfa.amsl.com>; Wed, 17 Jan 2018 08:58:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X0YUPCWZSrzB for <netmod@ietfa.amsl.com>; Wed, 17 Jan 2018 08:58:30 -0800 (PST)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF8601204DA for <netmod@ietf.org>; Wed, 17 Jan 2018 08:58:30 -0800 (PST)
Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0HGXevQ007042 for <netmod@ietf.org>; Wed, 17 Jan 2018 08:35:15 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=PPS1017; bh=kHJOfrIBxn1Ko4riRwQ9Tf7amaeYEO+WUxGUNM7mda8=; b=q9RHaZ1eWrZR+znHqjghz+4SUvq47+Nbfj5JyPzx1OOEqXGBwus4mJPqA+DDNnu/sa2T LB2m+yzu1C5Ud2eRpaCRfwhCLEimxBZsknoTZzR3RctMr1RZA6wkoEUBDLINy9DUT2Yl mVOsB1PXZqTLigfX8yn/9RhEuRd74FLD+Nebe743HdDVNPJY8pAKr+PsYS9XbCi3aA1V +NYKZM1MIOjsiRVWix1m5osVMnEsBWqn+q9AFAHA21IYdI2Dc9zLqAO8IJB9Ibri8tgN 0uSzxaNQIYqWIaYLMYglH9w/QcV66rZNbFaVXCAn+x14qADF+mSdvNN/KGADUWefsfFc eQ==
Received: from nam03-by2-obe.outbound.protection.outlook.com (mail-by2nam03lp0052.outbound.protection.outlook.com [216.32.180.52]) by mx0b-00273201.pphosted.com with ESMTP id 2fja44g049-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for <netmod@ietf.org>; Wed, 17 Jan 2018 08:35:14 -0800
Received: from DM5PR05MB3484.namprd05.prod.outlook.com (10.174.240.147) by DM5PR05MB3242.namprd05.prod.outlook.com (10.173.220.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.9; Wed, 17 Jan 2018 16:35:12 +0000
Received: from DM5PR05MB3484.namprd05.prod.outlook.com ([10.174.240.147]) by DM5PR05MB3484.namprd05.prod.outlook.com ([10.174.240.147]) with mapi id 15.20.0428.014; Wed, 17 Jan 2018 16:35:12 +0000
From: Kent Watsen <kwatsen@juniper.net>
To: "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] I-D Action: draft-ietf-netmod-syslog-model-19.txt
Thread-Index: AQHTi/jgm64n1kE5c0S5iq2VpQaBSqN2at0AgAGLqQA=
Date: Wed, 17 Jan 2018 16:35:12 +0000
Message-ID: <90BE8219-327C-42E9-B391-53E862F33D17@juniper.net>
References: <151579789446.21777.985631371557420470@ietfa.amsl.com> <B21EB766-3A67-4642-9791-16586449E885@juniper.net>
In-Reply-To: <B21EB766-3A67-4642-9791-16586449E885@juniper.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.20.0.170309
x-originating-ip: [66.129.241.11]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DM5PR05MB3242; 7:T3o8m5ZM3xc005hYmlHRaPSQrRjSLU/tFSzeN9A7EQTeZRl30BmhVqBZVyYzZI9OXnhcRsAXf+ZFETa3Xj/PK/cLAtytJQpGIhuRat83k05OlQ7PNTlS8Nrc4AbSzJLhzcu2tr1hLZu8H2DQBz+cREQPpFBSzDZNmKSKrRKDurCR+TAVhXTa8cNuYfGyMRlABwGvdHnnniPbHX7QfEuYsoOqAH5gvirFHbpaOLQp9RyBAUlg6BJhUheqwnwNibWY
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: 6ed0fc78-8de7-4eee-c149-08d55dc847ec
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7153060)(7193020); SRVR:DM5PR05MB3242;
x-ms-traffictypediagnostic: DM5PR05MB3242:
x-microsoft-antispam-prvs: <DM5PR05MB3242D6144F35E5472A765DA6A5E90@DM5PR05MB3242.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(10436049006162)(209352067349851)(192374486261705);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(944501161)(6055026)(6041268)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR05MB3242; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR05MB3242;
x-forefront-prvs: 0555EC8317
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(346002)(396003)(39860400002)(39380400002)(366004)(189003)(199004)(2900100001)(5660300001)(86362001)(2950100002)(575784001)(305945005)(966005)(14454004)(2906002)(68736007)(58126008)(478600001)(3660700001)(8676002)(316002)(26005)(1730700003)(81166006)(81156014)(3280700002)(83716003)(8936002)(6506007)(229853002)(102836004)(230783001)(59450400001)(6246003)(6486002)(77096006)(82746002)(2351001)(6436002)(25786009)(6916009)(2501003)(6306002)(76176011)(99286004)(6512007)(53936002)(33656002)(3846002)(7736002)(83506002)(6116002)(66066001)(36756003)(97736004)(106356001)(5640700003)(105586002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR05MB3242; H:DM5PR05MB3484.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
x-microsoft-antispam-message-info: +3CGvMIWrhCVnr53QkVL5WPDYIRV01UaIEVF7ifryzuiJ71yrLHGITvJUVc6o6CYWA4ue0TowMil42LbU+K4XA==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <5A5D998101F25C48A16C63D62DEB2305@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ed0fc78-8de7-4eee-c149-08d55dc847ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2018 16:35:12.3865 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR05MB3242
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-01-17_07:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801170232
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/9-sswAqkicYbxneyqT8H82rmHBg>
Subject: Re: [netmod] I-D Action: draft-ietf-netmod-syslog-model-19.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jan 2018 16:58:33 -0000

Hi Clyde,

One quick follow-up, it seems that all drafts are moving over to reference the tree-diagrams draft these days.  As such, I think Section 1.3 (Tree Diagram Notation) should now be removed and Section 3.1 should change as follows:

  OLD
  Please see Section 1.3 for tree diagram notation.

  NEW
  Please see [I-D.ietf-netmod-yang-tree-diagrams] for tree diagram notation.
  (yes, that should be hyperlink)

and add I-D.ietf-netmod-yang-tree-diagrams as an Informative reference.

Thanks,
Kent


===== original message =====

Clyde,

This draft still isn't passing idnits.  I provided the link to idnits previously, but here it is again: https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ietf.org_tools_idnits&d=DwICAg&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=9zkP0xnJUvZGJ9EPoOH7Yhqn2gsBYaGTvjISlaJdcZo&m=A2x1CyvFGV7zPzunzNLz__Ce2NswyYOw0iQVI-cNwTo&s=FErz5G2HICKnT_lI6gedg7ni66XCMBrj756eh-lXdW0&e=.  Below is the idnits output for -19 with inlined comments.

PS: I didn't also checked the other issues we're tracking, but will when we get past these idnits issues.

Kent


===== START =====
idnits 2.15.00 

/tmp/draft-ietf-netmod-syslog-model-19.txt:

  Checking boilerplate required by RFC 5378 and the IETF Trust (see
  https://urldefense.proofpoint.com/v2/url?u=https-3A__trustee.ietf.org_license-2Dinfo&d=DwICAg&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=9zkP0xnJUvZGJ9EPoOH7Yhqn2gsBYaGTvjISlaJdcZo&m=A2x1CyvFGV7zPzunzNLz__Ce2NswyYOw0iQVI-cNwTo&s=X00_D6mS_CYdDDM_LABw-a_uhQziwjSvaaz8UHC6Nc0&e=):
  ----------------------------------------------------------------------------

     No issues found here.

  Checking nits according to https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ietf.org_id-2Dinfo_1id-2Dguidelines.txt&d=DwICAg&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=9zkP0xnJUvZGJ9EPoOH7Yhqn2gsBYaGTvjISlaJdcZo&m=A2x1CyvFGV7zPzunzNLz__Ce2NswyYOw0iQVI-cNwTo&s=U9PqY8kpdbwz_sL4a1DhBJagSvEx9sv9zZquldhed7U&e=:
  ----------------------------------------------------------------------------

     No issues found here.

  Checking nits according to https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ietf.org_id-2Dinfo_checklist&d=DwICAg&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=9zkP0xnJUvZGJ9EPoOH7Yhqn2gsBYaGTvjISlaJdcZo&m=A2x1CyvFGV7zPzunzNLz__Ce2NswyYOw0iQVI-cNwTo&s=K833IRzwN3sBZr2ApmQYRHjvSmKHOhNjY4JQ2mUEm18&e= :
  ----------------------------------------------------------------------------

  ** There is 1 instance of too long lines in the document, the longest one
     being 1 character in excess of 72.

Kent: this isn't a big deal IMO, but if it's easy to fix, it saves the RFC editor a step later on.


  Miscellaneous warnings:
  ----------------------------------------------------------------------------

  == Line 352 has weird spacing: '...gorithm    ide...'

Kent: this is fine.  it is in a tree diagram.


  == The document seems to lack the recommended RFC 2119 boilerplate, even if
     it appears to use RFC 2119 keywords -- however, there's a paragraph with
     a matching beginning. Boilerplate error?

     (The document does seem to have the reference to RFC 2119 which the
     ID-Checklist requires).

Kent: I can't find the error.  Looking at the xml, it is verbatim what I have in the zerotouch draft.  my guess is that this is a tooling error and we should ignore it.


  -- The document date (January 12, 2018) is 4 days in the past.  Is this
     intentional?

Kent: this is fine, it is intentional.


  Checking references for intended status: Proposed Standard
  ----------------------------------------------------------------------------

     (See RFCs 3967 and 4897 for information about using normative references
     to lower-maturity documents in RFCs)

  == Unused Reference: 'I-D.ietf-netconf-keystore' is defined on line 1386,
     but no explicit reference was found in the text

Kent: looking at the XML, I see that the entire paragraph uses '[' and ']' as opposed to <xref .../>.  Please fix this.


  == Unused Reference: 'RFC7895' is defined on line 1456, but no explicit
     reference was found in the text

Kent: looking at the XML, I see two instances of an unwanted "/&gt;" string.  For instance: <xref target="RFC7895"/>/&gt;  Please fix this.


  ** Downref: Normative reference to an Historic RFC: RFC 6587

Kent: hmmm, what's going on here?  This YANG module is providing an ability to configure the "tcp" transport, even though the IESG made that ability historic in 2012 (see IESG Note below).  Searching online, it looks like Cisco supports this, but Juniper does not.  What about other vendors, is it widely supported?  Was this discussed in the WG?  Answering my own question, searching my local mailbox, I don't see this ever being discussed before, other than Martin questioning if it was a good idea in Mar 2016 (no response).  Please start a thread on the list to get WG opinion if it's okay for the draft to proceed as is or not.  Here's the IESG Note from RFC 6587:

   IESG Note

   The IESG does not recommend implementing or deploying syslog over
   plain tcp, which is described in this document, because it lacks the
   ability to enable strong security [RFC3365].

   Implementation of the TLS transport [RFC5425] is recommended so that
   appropriate security features are available to operators who want to
   deploy secure syslog.  Similarly, those security features can be
   turned off for those who do not want them.





     Summary: 2 errors (**), 0 flaws (~~), 4 warnings (==), 1 comment (--).

     Run idnits with the --verbose option for more detailed information about
     the items above.
===== END =====

Thanks,
Kent // shepherd



_______________________________________________
netmod mailing list
netmod@ietf.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ietf.org_mailman_listinfo_netmod&d=DwICAg&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=9zkP0xnJUvZGJ9EPoOH7Yhqn2gsBYaGTvjISlaJdcZo&m=A2x1CyvFGV7zPzunzNLz__Ce2NswyYOw0iQVI-cNwTo&s=etLxOIrgGaAD30-UmDGkrdfiVvY7AsD2GQ8szCkUChk&e=