Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14

Martin Bjorklund <mbj@tail-f.com> Thu, 26 October 2017 10:09 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E19C13F54C for <netmod@ietfa.amsl.com>; Thu, 26 Oct 2017 03:09:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X58RXweutccU for <netmod@ietfa.amsl.com>; Thu, 26 Oct 2017 03:09:22 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 0879013F545 for <netmod@ietf.org>; Thu, 26 Oct 2017 03:09:22 -0700 (PDT)
Received: from localhost (h-40-225.A165.priv.bahnhof.se [94.254.40.225]) by mail.tail-f.com (Postfix) with ESMTPSA id EDE3A1AE012C; Thu, 26 Oct 2017 12:09:20 +0200 (CEST)
Date: Thu, 26 Oct 2017 12:09:20 +0200 (CEST)
Message-Id: <20171026.120920.1585653562670944391.mbj@tail-f.com>
To: acee@cisco.com
Cc: mjethanandani@gmail.com, agarwaso@cisco.com, netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <D61726BB.D26F7%acee@cisco.com>
References: <D6160649.D21B2%acee@cisco.com> <880E1C02-2D32-4298-B970-D2D61E2F3C28@gmail.com> <D61726BB.D26F7%acee@cisco.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/9_NCUAwASss5JEQXP8FlhgRnsHg>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Oct 2017 10:09:23 -0000

"Acee Lindem (acee)" <acee@cisco.com> wrote:
> Hi Mahesh, 
> 
> On 10/25/17, 9:22 PM, "Mahesh Jethanandani" <mjethanandani@gmail.com>
> wrote:
> 
> >Acee,
> >
> >Thanks for reviewing the draft.
> >
> >> On Oct 25, 2017, at 6:21 AM, Acee Lindem (acee) <acee@cisco.com> wrote:
> >> 
> >> Hi Kent, Mahesh, et al,
> >> 
> >> I have read the draft and support publication. I have two comments on
> >>the
> >> -14 version. 
> >> 
> >>  1. The tree diagrams do not fit within the draft pages. Note that
> >>recent
> >> versions of pyang support the —tree-line-length parameter and this may
> >> help. 
> >
> >I used the —tree-line-length=72 as the parameter to generate the tree,
> >and that is why you see the line wrap around.
> 
> I guess then you need to manually format it so it fits.

Try --tree-line-length 69.   The reason for this is that the figures
are indented by xml2rfc.  I added this as a recommention to the
tree-diagram draft as well the other day.


/martin