Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7277bis-00

Martin Bjorklund <mbj@tail-f.com> Sat, 16 December 2017 09:46 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C964A126C22 for <netmod@ietfa.amsl.com>; Sat, 16 Dec 2017 01:46:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5oFoeTyv0gQH for <netmod@ietfa.amsl.com>; Sat, 16 Dec 2017 01:46:48 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 3138812025C for <netmod@ietf.org>; Sat, 16 Dec 2017 01:46:48 -0800 (PST)
Received: from localhost (h-85-209.A165.priv.bahnhof.se [94.254.85.209]) by mail.tail-f.com (Postfix) with ESMTPSA id E81C91AE0475; Sat, 16 Dec 2017 10:46:45 +0100 (CET)
Date: Sat, 16 Dec 2017 10:46:45 +0100 (CET)
Message-Id: <20171216.104645.2140965470373068531.mbj@tail-f.com>
To: vladimir@transpacket.com
Cc: netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <937fadab-b3f0-1246-8543-00cb4d6a5acd@transpacket.com>
References: <20171213.154734.273404682004037071.mbj@tail-f.com> <500e497e-9a80-8d00-22ca-6fe271fcd725@transpacket.com> <937fadab-b3f0-1246-8543-00cb4d6a5acd@transpacket.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/Bqd9iWmOGpe9NcoD00oziprJ0GA>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7277bis-00
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Dec 2017 09:46:50 -0000

Hi,

Vladimir Vassilev <vladimir@transpacket.com>; wrote:
> 
> On 12/13/2017 04:26 PM, Vladimir Vassilev wrote:
> > Hi,
> >
> > On 12/13/2017 03:47 PM, Martin Bjorklund wrote:
> >
> >> Hi,
> >>
> >> Thanks for reporting this.  I'll add the missing origin.  But why did
> >> you think forwarding and mtu should be removed?
> > 1. IMO since <mtu> is not present in the <ipv4> container in the
> > Appendix A (<get-config>) example and does not have default value in
> > the model I still think it should be removed.
> Alternatively the ipv4/mtu node can be a good example of a
> origin="or:system" configuration.

Yes.

> >>    In fact, I think I
> >> missed <enabled>,
> > 2. IMO both fixes adding <enabled> or removing <forwarding> should be
> > OK depending on the RFC6243 defined with-defaults capability
> > 'basic-mode' parameter advertised by the server. I was running the
> > example with basic-mode=explicit

Right.  I now have this:

      <!-- other parameters from ietf-interfaces omitted -->

      <ipv4 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip">
        <enabled or:origin="or:default">true</enabled>
        <forwarding or:origin="or:default">false</forwarding>
        <mtu or:origin="or:system">1500</mtu>
        <address>
          <ip>192.0.2.1</ip>
          <prefix-length>24</prefix-length>
          <origin>static</origin>
        </address>
        <neighbor or:origin="or:learned">
          <ip>192.0.2.2</ip>
          <link-layer-address>00:01:02:03:04:05</link-layer-address>
        </neighbor>
      </ipv4>
      <ipv6 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip">
        <enabled or:origin="or:default">true</enabled>
        <forwarding or:origin="or:default">false</forwarding>
        <mtu>1280</mtu>
        ...

Do you think this is ok?


/martin