[netmod] shepherd review for draft-ietf-netmod-rfc8407bis
"maqiufang (A)" <maqiufang1@huawei.com> Fri, 27 September 2024 06:07 UTC
Return-Path: <maqiufang1@huawei.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC1FEC180B50; Thu, 26 Sep 2024 23:07:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.904
X-Spam-Level:
X-Spam-Status: No, score=-6.904 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tus-L4gWEaMM; Thu, 26 Sep 2024 23:07:03 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7034C1840C1; Thu, 26 Sep 2024 23:07:02 -0700 (PDT)
Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XFKhv3qXcz6H7MZ; Fri, 27 Sep 2024 14:06:07 +0800 (CST)
Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id DA053140AE5; Fri, 27 Sep 2024 14:06:44 +0800 (CST)
Received: from kwepemk200009.china.huawei.com (7.202.194.75) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 27 Sep 2024 07:06:44 +0100
Received: from kwepemk200009.china.huawei.com (7.202.194.75) by kwepemk200009.china.huawei.com (7.202.194.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 27 Sep 2024 14:06:42 +0800
Received: from kwepemk200009.china.huawei.com ([7.202.194.75]) by kwepemk200009.china.huawei.com ([7.202.194.75]) with mapi id 15.02.1544.011; Fri, 27 Sep 2024 14:06:39 +0800
From: "maqiufang (A)" <maqiufang1@huawei.com>
To: "draft-ietf-netmod-rfc8407bis@ietf.org" <draft-ietf-netmod-rfc8407bis@ietf.org>
Thread-Topic: shepherd review for draft-ietf-netmod-rfc8407bis
Thread-Index: AdsP85swhRiWnsB/QyWQZtp+Ly32OQ==
Date: Fri, 27 Sep 2024 06:06:39 +0000
Message-ID: <c5f677c30aed43c68279d5d35859b3ba@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.118.147]
Content-Type: multipart/alternative; boundary="_000_c5f677c30aed43c68279d5d35859b3bahuaweicom_"
MIME-Version: 1.0
Message-ID-Hash: CE4Y2DRLYNHWNQLICWNFJ3T55UOY74MK
X-Message-ID-Hash: CE4Y2DRLYNHWNQLICWNFJ3T55UOY74MK
X-MailFrom: maqiufang1@huawei.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-netmod.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "netmod@ietf.org" <netmod@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [netmod] shepherd review for draft-ietf-netmod-rfc8407bis
List-Id: NETMOD WG list <netmod.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/DLHyyTms7ZMdgFwZwzdgTNEDZgQ>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Owner: <mailto:netmod-owner@ietf.org>
List-Post: <mailto:netmod@ietf.org>
List-Subscribe: <mailto:netmod-join@ietf.org>
List-Unsubscribe: <mailto:netmod-leave@ietf.org>
Hi, authors, WG, As part of my shepherd write-up for draft-ietf-netmod-rfc8407bis, I've reviewed the latest version of the draft and have got some editorial comments (most of which are nits), hopefully they could be fixed before progressing the document. The Idnits<https://author-tools.ietf.org/api/idnits?url=https://www.ietf.org/archive/id/draft-ietf-netmod-rfc8407bis-16.txt> complains of some errors and warnings, some of which I think are valid and need to be fixed before publication : * There is 1 instance of too long lines in the document, the longest one being 2 characters in excess of 72. The line where the when expression is located in sec.4..6.4: when 'derived-from-or-self(rt:address-family, "v4ur:ipv4-unicast")' { * Downref: Normative reference to an Informational RFC: RFC 8792 Could this be fixed as informative reference? * -- Obsolete informational reference (is this intentional?): RFC 7223 (Obsoleted by RFC 8343) Better to fix the reference to RFC 7223 with 8343 (which also defines the identical example) in section 4.19.1? Section 4.14 specifies a set of YANG statements that MUST have a description substatement, but I don't think anydata should be omitted here. Thoughts? Other nits: * Section 4.5 OLD: presence "When present, indicates type foo" NEW: presence "When present, indicates type foo"; (missing the semicolon) OLD: presence "When present, indicates type bar" NEW: presence "When present, indicates type bar"; (missing the semicolon) OLD: Section 8.1 of [RFC7950] includes a provision for defining a constraint on state data and specifies that the constraint must be true in a valid state data. NEW: Section 8.1 of [RFC7950] includes a provision for defining constraints on state data and specifies that the constraint must be true in a valid state data tree. * Section 4.20 OLD: max-elements 10; NEW: max-elements 10; Please consider indenting a space here. * Section 4.24 s/ min-entries/min-elements s/max-entries/max-elements * Section 5.1 OLD: Name: iana-template Maintained by IANA? N Namespace: urn:ietf:params:xml:ns:yang:iana-template Prefix: iana-foo Reference: RFC AAAA NEW: Name: iana-template Maintained by IANA? Y Namespace: urn:ietf:params:xml:ns:yang:iana-template Prefix: iana-foo Reference: RFC AAAA * Appendix A OLD: "IETF NETMOD (NETCONF Data Modeling Language) Working Group"; NEW: "IETF NETMOD (Network Modeling) Working Group"; Or, "IETF your-wg-name (expansion) Working Group", to be consistent with the info in contact statement. * Appendix C The IETF Trust Copyright statement for the iana-template module doesn't seem to be correct. s/Simplified/Revised/? Best Regards, Qiufang
- [netmod] Re: shepherd review for draft-ietf-netmo… mohamed.boucadair
- [netmod] shepherd review for draft-ietf-netmod-rf… maqiufang (A)
- [netmod] Re: shepherd review for draft-ietf-netmo… maqiufang (A)
- [netmod] Re: shepherd review for draft-ietf-netmo… mohamed.boucadair
- [netmod] Re: shepherd review for draft-ietf-netmo… maqiufang (A)
- [netmod] Re: shepherd review for draft-ietf-netmo… mohamed.boucadair
- [netmod] Re: shepherd review for draft-ietf-netmo… Kent Watsen
- [netmod] Re: shepherd review for draft-ietf-netmo… mohamed.boucadair
- [netmod] Re: shepherd review for draft-ietf-netmo… Kent Watsen
- [netmod] Re: shepherd review for draft-ietf-netmo… maqiufang (A)
- [netmod] Re: shepherd review for draft-ietf-netmo… mohamed.boucadair
- [netmod] anydata/mandatory description RE: shephe… mohamed.boucadair
- [netmod] Re: anydata/mandatory description RE: sh… mohamed.boucadair