Re: [netmod] *one* week 2nd WG Last Call: draft-ietf-netmod-revised-datastores-07

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Tue, 19 December 2017 20:54 UTC

Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AEE071270A0; Tue, 19 Dec 2017 12:54:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j7rmpkyHAqcz; Tue, 19 Dec 2017 12:54:25 -0800 (PST)
Received: from atlas5.jacobs-university.de (atlas5.jacobs-university.de [212.201.44.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EA6E1205D3; Tue, 19 Dec 2017 12:54:25 -0800 (PST)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas5.jacobs-university.de (Postfix) with ESMTP id 25C35673; Tue, 19 Dec 2017 21:54:24 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas5.jacobs-university.de ([10.70.0.217]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10032) with ESMTP id O8aBte0mGbwX; Tue, 19 Dec 2017 21:54:23 +0100 (CET)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "Jacobs University CA - G01" (verified OK)) by atlas5.jacobs-university.de (Postfix) with ESMTPS; Tue, 19 Dec 2017 21:54:23 +0100 (CET)
Received: from localhost (demetrius3.jacobs-university.de [212.201.44.48]) by hermes.jacobs-university.de (Postfix) with ESMTP id DF89720130; Tue, 19 Dec 2017 21:54:23 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius3.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id lcNYMCgrqnHU; Tue, 19 Dec 2017 21:54:23 +0100 (CET)
Received: from elstar.local (elstar.jacobs.jacobs-university.de [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id 3CCE420073; Tue, 19 Dec 2017 21:54:23 +0100 (CET)
Received: by elstar.local (Postfix, from userid 501) id 157F441F3C8F; Tue, 19 Dec 2017 21:54:22 +0100 (CET)
Date: Tue, 19 Dec 2017 21:54:22 +0100
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: Andy Bierman <andy@yumaworks.com>
Cc: Martin Bjorklund <mbj@tail-f.com>, Berger Lou <lberger@labn.net>, NetMod WG Chairs <netmod-chairs@ietf.org>, draft-ietf-netmod-revised-datastores@ietf.org, NetMod WG <netmod@ietf.org>
Message-ID: <20171219205422.okuxkyj7egpoqo6t@elstar.local>
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
Mail-Followup-To: Andy Bierman <andy@yumaworks.com>, Martin Bjorklund <mbj@tail-f.com>, Berger Lou <lberger@labn.net>, NetMod WG Chairs <netmod-chairs@ietf.org>, draft-ietf-netmod-revised-datastores@ietf.org, NetMod WG <netmod@ietf.org>
References: <80a900b3-716a-b11f-3472-7cae57662ba4@labn.net> <198a88e4-9b8b-945b-09a1-49fa9f57cbb0@labn.net> <20171219.213101.692193824403742919.mbj@tail-f.com> <CABCOCHSsYugYe0dgZ_SV6rdt3AGoNx5HknLAkhiDzpPcuGgS+w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABCOCHSsYugYe0dgZ_SV6rdt3AGoNx5HknLAkhiDzpPcuGgS+w@mail.gmail.com>
User-Agent: NeoMutt/20171215
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/F-q54cV__iVQzXGbpEwVVU9sWT0>
Subject: Re: [netmod] *one* week 2nd WG Last Call: draft-ietf-netmod-revised-datastores-07
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2017 20:54:28 -0000

On Tue, Dec 19, 2017 at 12:41:28PM -0800, Andy Bierman wrote:
> On Tue, Dec 19, 2017 at 12:31 PM, Martin Bjorklund <mbj@tail-f.com> wrote:
> 
> > Hi Lou,
> >
> > Lou Berger <lberger@labn.net> wrote:
> > > Hi,
> > >       These comments are based on my Shepherd review of this document and
> > > should be addressed as part of addressing any LC comments:
> > >
> > > 1) Considering the recent discussion on Library made me consider the
> > > general case of a module that is composed entirely of operational state.
> > >  I think this case is subject to interpretation and therefore needs to
> > > be explicitly covered.  For example section 5.3 states:
> > >
> > >    The datastore schema for <operational> MUST be a superset of the
> > >    combined datastore schema used in all configuration datastores except
> > >    that YANG nodes supported in a configuration datastore MAY be omitted
> > >    from <operational> if a server is not able to accurately report them.
> > >
> > > This could be read that a module that an operational state MUST be
> > > present (but presumably empty>?) in some other DS to be present in
> > > operational.  I don't believe this is your intent, but it should be
> > > explicitly covered for the benefit of future readers.
> >
> > Ok.  How about we add to the paragraph above a sentence:
> >
> >     If a module does not contain any configuration data then it MAY be
> >     omitted from the schema for the configuration datastores.
> 
> I liked the old YANG library better.
> It allows a client to create of a list of all the
> modules/revisions/features/deviations
> that will be needed to match the schema tree used by the server.
> The compiler does not care if it is looking for a typedef vs. a data node.
> The YANG library details help the compiler find the correct definitions.
> 
> Consider iana-crypt-hash that has only typedefs and features.
> Leaving this module out of the library can cause problems for a client.
>

I think this is not the intention. If a module is needed to satisfy
imports, it has to be listed as part of the schema. So perhaps this is
better?

    If a module does not contain any configuration data and it is not
    needed to satisfy any imports, then it MAY be omitted from the
    schema for the configuration datastores.

/js

-- 
Juergen Schoenwaelder           Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
Fax:   +49 421 200 3103         <http://www.jacobs-university.de/>