Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt

Christian Hopps <chopps@chopps.org> Tue, 05 March 2019 13:54 UTC

Return-Path: <chopps@chopps.org>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C09B131268 for <netmod@ietfa.amsl.com>; Tue, 5 Mar 2019 05:54:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UctsLIJNn14a for <netmod@ietfa.amsl.com>; Tue, 5 Mar 2019 05:54:31 -0800 (PST)
Received: from smtp.chopps.org (smtp.chopps.org [54.88.81.56]) by ietfa.amsl.com (Postfix) with ESMTP id 5FE851310F6 for <netmod@ietf.org>; Tue, 5 Mar 2019 05:54:31 -0800 (PST)
Received: from tops.chopps.org (047-050-069-038.biz.spectrum.com [47.50.69.38]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by smtp.chopps.org (Postfix) with ESMTPS id 57373604CC; Tue, 5 Mar 2019 08:54:30 -0500 (EST)
References: <155121476305.848.1143308532121819978@ietfa.amsl.com> <51C97F98-F877-49D4-9250-5213A31B442D@chopps.org> <20190304.105940.312797647046250578.mbj@tail-f.com> <sa67ede1jef.fsf@chopps.org> <CAEe_xxi4QeGbwQxXQFJE7EB9Cz1ee2ZhRLY9FOaNd3opw9M=Jw@mail.gmail.com>
User-agent: mu4e 1.1.0; emacs 26.1
From: Christian Hopps <chopps@chopps.org>
To: William Lupton <wlupton@broadband-forum.org>
Cc: Christian Hopps <chopps@chopps.org>, Martin Bjorklund <mbj@tail-f.com>, netmod@ietf.org
In-reply-to: <CAEe_xxi4QeGbwQxXQFJE7EB9Cz1ee2ZhRLY9FOaNd3opw9M=Jw@mail.gmail.com>
Date: Tue, 05 Mar 2019 08:54:29 -0500
Message-ID: <sa65zsx4eay.fsf@chopps.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/FJO2wkIeFM2Sb3W74ydGIreQyus>
Subject: Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Mar 2019 13:54:34 -0000

William Lupton <wlupton@broadband-forum.org> writes:

>> The intent was "ascii-printable". Would be nice if there was an easier
> way to specify this. :)
>
> Printable ASCII characters are ' ' (space) through '~' (tilde) so naively [
> -~] should work ... but perhaps that makes unacceptable assumptions about
> the locale and/or character encoding? (Certainly it should be OK if we can
> assume UTF-8, because all printable ASCII characters retain their ASCII
> representations in UTF-8.)

I think your suggestion is a good one!

YANG references <https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/#dt-regex> says it will work too (its the range between the UTF code points, which in this case are the ascii values), but then that reference is also where i got the "#x22" hex format from that Martin said was invalid. :)

Thanks,
Chris.

>
> On Mon, 4 Mar 2019 at 20:20, Christian Hopps <chopps@chopps.org> wrote:
>
>>
>> Martin Bjorklund <mbj@tail-f.com> writes:
>>
>> > Hi,
>> >
>> > Just some quick comments on the YANG:
>> >
>> > However, it seems libxml2's regexp engine requires both "[" and "^" to
>> > be escaped:
>> >
>> >         '[-0-9a-z "#\[\]' +
>> >         '!$%&()*+,./:;<=>?@\\\^_`{|}~]+';
>> >
>> > This expression isn't wrong, but it seems to me that these characters
>> > should not have to be escaped.
>> >
>> > The pattern allows double quote (") but not single quote (').  Is
>> > that intentional?
>>
>> The intent was "ascii-printable". Would be nice if there was an easier way
>> to specify this. :)
>>
>> > [a simple way to test the patterns is to have a "default" statement
>> > and a YANG complier that verifies defaults]
>>
>> Does pyang do this?
>>
>> > I recommend that you rename the example module in section to
>> > "example-uses-geo-location" (and change the namespace to
>> > urn:example:uses-geo-location).   We should not use the "ietf"
>> > namespace for examples.
>>
>> Will do.
>>
>> Thanks,
>> Chris.
>>
>> > /martin
>> _______________________________________________
>> netmod mailing list
>> netmod@ietf.org
>> https://www.ietf.org/mailman/listinfo/netmod
>>