Re: [netmod] Comments on instance data draft rev -02

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Mon, 25 March 2019 13:37 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3AB29120381 for <netmod@ietfa.amsl.com>; Mon, 25 Mar 2019 06:37:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.503
X-Spam-Level:
X-Spam-Status: No, score=-14.503 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=H6YsrMOa; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=EMRZBtt6
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4yMBsxJGDYau for <netmod@ietfa.amsl.com>; Mon, 25 Mar 2019 06:37:10 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9783F12038C for <netmod@ietf.org>; Mon, 25 Mar 2019 06:37:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2012; q=dns/txt; s=iport; t=1553521030; x=1554730630; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=lSFo0rdhdu4R2lcbnmZZYiBQrdB7k4F8oE1bBBhnhV4=; b=H6YsrMOaoPNgxAElIc3I9/mVvhuiA0XyXL2rM5aVv9Ccrd0MOSoSFlOh eJFWnROsOdV28mGAZGER5lxFvK2MYsKpq1k5yedj1/jHLooYdOkDW0tDI IrTj3Xywuz4rR+s4Y/5L3lXkDVAIJL03KCEJc/IL2pYS/bLC0pSKbECFa A=;
IronPort-PHdr: =?us-ascii?q?9a23=3Aa56nLxdYKVqmcYEt67srSMrllGMj4e+mNxMJ6p?= =?us-ascii?q?chl7NFe7ii+JKnJkHE+PFxlwGRD57D5adCjOzb++D7VGoM7IzJkUhKcYcEFn?= =?us-ascii?q?pnwd4TgxRmBceEDUPhK/u/dTYzHMFLUndu/mqwNg5eH8OtL1A=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AnAABG2Jhc/4oNJK1jHAEBAQQBAQc?= =?us-ascii?q?EAQGBUQcBAQsBgT1QA2h0BAsnCoQEg0cDhFKKV4IylzGBLoEkA1QNAQEYCwm?= =?us-ascii?q?DekYCF4R7IjQJDQEBAwEBCQEDAm0cDIVLAgQBASERDAEBLAwPAgEIGgImAgI?= =?us-ascii?q?CJQsVEAIEARKDIgGBXQMVAQIMow4CihRxgS+CeAEBBYJHgjYYggwDBYELJAG?= =?us-ascii?q?LMReBQD+BOAwTghcHLj6CYQEBgWEXgnMxgiaMRC+YJgkCkzcZk36LHJMqAgQ?= =?us-ascii?q?CBAUCDgEBBYFNOIFWcBU7KgGCQYIKDBeDS4UUhT9ygSiNXwGBHgEB?=
X-IronPort-AV: E=Sophos;i="5.60,269,1549929600"; d="scan'208";a="539523443"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 25 Mar 2019 13:37:09 +0000
Received: from XCH-RCD-002.cisco.com (xch-rcd-002.cisco.com [173.37.102.12]) by alln-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id x2PDb9aZ023733 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL) for <netmod@ietf.org>; Mon, 25 Mar 2019 13:37:09 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-RCD-002.cisco.com (173.37.102.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Mar 2019 08:37:08 -0500
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Mar 2019 09:37:08 -0400
Received: from NAM04-CO1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 25 Mar 2019 08:37:08 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lSFo0rdhdu4R2lcbnmZZYiBQrdB7k4F8oE1bBBhnhV4=; b=EMRZBtt6d104mVckZVVtNVu6ue1E3L2lhYV3a6EpY5yD4NhbT/FXZgnEGbHey6wKWi2RiChURSn7YJwyB16iO7O5yOOvFEs+nLphJ9PrzzM1GWnb0KAS8IkWXlXoTaLeYW9CkGlkD9GYvLzejbS9Bi1bOjDGlEKJEpplz9Lp++4=
Received: from MN2PR11MB3695.namprd11.prod.outlook.com (20.178.252.156) by MN2PR11MB3856.namprd11.prod.outlook.com (20.178.251.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.16; Mon, 25 Mar 2019 13:37:01 +0000
Received: from MN2PR11MB3695.namprd11.prod.outlook.com ([fe80::4d5b:81c5:6ab2:c5d]) by MN2PR11MB3695.namprd11.prod.outlook.com ([fe80::4d5b:81c5:6ab2:c5d%5]) with mapi id 15.20.1730.019; Mon, 25 Mar 2019 13:37:01 +0000
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: "Joe Clarke (jclarke)" <jclarke@cisco.com>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] Comments on instance data draft rev -02
Thread-Index: AQHU4w72B4h41eMW9Ea7hYSZb+NIq6YcakmA
Date: Mon, 25 Mar 2019 13:37:00 +0000
Message-ID: <61E39ECE-7358-47CA-9D78-26C5C33853FB@cisco.com>
References: <5f17a293-346e-b469-e78f-8933a7650db4@cisco.com>
In-Reply-To: <5f17a293-346e-b469-e78f-8933a7650db4@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.6.190114
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rrahman@cisco.com;
x-originating-ip: [173.38.117.91]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a27842c9-dd00-4d84-8fa5-08d6b126f5d1
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:MN2PR11MB3856;
x-ms-traffictypediagnostic: MN2PR11MB3856:
x-ms-exchange-purlcount: 1
x-ld-processed: 5ae1af62-9505-4097-a69a-c1553ef7840e,ExtAddr
x-microsoft-antispam-prvs: <MN2PR11MB3856523F0FC955990EF9362BAB5E0@MN2PR11MB3856.namprd11.prod.outlook.com>
x-forefront-prvs: 0987ACA2E2
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(376002)(366004)(136003)(199004)(189003)(66574012)(186003)(8676002)(8936002)(102836004)(99286004)(6486002)(97736004)(66066001)(7736002)(81156014)(53936002)(478600001)(105586002)(2501003)(81166006)(83716004)(966005)(446003)(2616005)(486006)(476003)(5660300002)(14454004)(26005)(229853002)(86362001)(11346002)(82746002)(76176011)(25786009)(2906002)(256004)(14444005)(58126008)(316002)(68736007)(6506007)(36756003)(110136005)(33656002)(6246003)(305945005)(71200400001)(71190400001)(6436002)(106356001)(6116002)(3846002)(6306002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3856; H:MN2PR11MB3695.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: l9ocgTuBH1yYVxBhJMH/6/GPjU12t2KGirTqwlIWJf2nKoTmrwvdvEPav3IVq1XQ5n80aJFOEuYa76kripX6lQfq2JwQHMzoB9xIdy0A6IT7pDqkobDmAm7R4Zh3CwBECjT+lhp+APQOE6FSRjXVEnh7dXTA0j5QCvWN/p7hRGhJ9ReoAYXPcjmr6YMxJ6Odgnm6ANWtdibBrtmajK4kVNCa9KyJ/HZwVkvKTkkyPy/cPrsCkm8Ph4hWGH+fX5F+s0UzaUhHIMJ23amPG3BpnYoXNsSa5a3c1ivyvUNwZV4HTMDhicvodL4dXiTdx8N7itbgNm6DGprTZINQ0CNWg+zCVReeTAsI3/CFb3Smv08b21lFggWrlcV56/DuWH7++ap0rpAPPUJAb1HTYtHWmwrWIH7DMSAIt9wiRknIBuM=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D1883825DF483A469EE14FAEC7D5B0FB@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a27842c9-dd00-4d84-8fa5-08d6b126f5d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2019 13:37:00.9758 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3856
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.12, xch-rcd-002.cisco.com
X-Outbound-Node: alln-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/IA5Kk_bqN3-bNFHNjlEptuKidUs>
Subject: Re: [netmod] Comments on instance data draft rev -02
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Mar 2019 13:37:13 -0000

+1 on schema, and the -ptr part added to my confusion.

Minor comment (which the authors probably know already): s/yang-data/structure/

Regards,
Reshad.

On 2019-03-25, 2:30 PM, "netmod on behalf of Joe Clarke" <netmod-bounces@ietf.org on behalf of jclarke@cisco.com> wrote:

    First, I agree with Jürgen that the "target" terminology confused me,
    especially so given you have target-module and inline-target-spec.  Like
    Jürgen and Rob said, "schema" seems to work better.  And maybe
    "inline-schema-module-spec" would be clearer that the spec modifies the
    modules from which the schema is generated.
    
    To the point about yang-data-ext/structure, I see instance data was very
    useful, but it's a must to be able to augment its metadata.  YANG
    Catalog would use that.  If this draft moves forward without
    sx:structure, then I think it would need to be straight YANG so that
    augments will work (i.e., a schema element would exist to augment).
    
    A few other comments (minor):
    
    Section 2.1:
    
    "P2 Re-use existing formats similar to the <get> operation/request"
    
    Isn't the format similar to a <get> _response_ versus the request?
    
    ===
    
    Section 3
    
    s/and and/and/
    
    Joe
    
    _______________________________________________
    netmod mailing list
    netmod@ietf.org
    https://www.ietf.org/mailman/listinfo/netmod