Re: [netmod] Comments on instance data draft rev -02

Martin Bjorklund <mbj@tail-f.com> Mon, 25 March 2019 13:52 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0516120432 for <netmod@ietfa.amsl.com>; Mon, 25 Mar 2019 06:52:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7iv3tklGk4Wb for <netmod@ietfa.amsl.com>; Mon, 25 Mar 2019 06:52:05 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 7B959120455 for <netmod@ietf.org>; Mon, 25 Mar 2019 06:52:04 -0700 (PDT)
Received: from localhost (dhcp-828a.meeting.ietf.org [31.133.130.138]) by mail.tail-f.com (Postfix) with ESMTPSA id 559981AE00A0; Mon, 25 Mar 2019 14:52:02 +0100 (CET)
Date: Mon, 25 Mar 2019 14:52:00 +0100 (CET)
Message-Id: <20190325.145200.336212787973649675.mbj@tail-f.com>
To: jclarke@cisco.com
Cc: netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <5f17a293-346e-b469-e78f-8933a7650db4@cisco.com>
References: <5f17a293-346e-b469-e78f-8933a7650db4@cisco.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/Ic9OF78JMsxJByyq-hhOExXQMCQ>
Subject: Re: [netmod] Comments on instance data draft rev -02
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Mar 2019 13:52:12 -0000

Joe Clarke <jclarke@cisco.com> wrote:
> First, I agree with Jürgen that the "target" terminology confused me,

+1

> especially so given you have target-module and inline-target-spec.  Like
> Jürgen and Rob said, "schema" seems to work better.

Since we have "content-data", perhaps use "content-schema"?


And a question:  why is the "name" leaf mandatory?


/martin


> And maybe
> "inline-schema-module-spec" would be clearer that the spec modifies the
> modules from which the schema is generated.
> 
> To the point about yang-data-ext/structure, I see instance data was very
> useful, but it's a must to be able to augment its metadata.  YANG
> Catalog would use that.  If this draft moves forward without
> sx:structure, then I think it would need to be straight YANG so that
> augments will work (i.e., a schema element would exist to augment).
> 
> A few other comments (minor):
> 
> Section 2.1:
> 
> "P2 Re-use existing formats similar to the <get> operation/request"
> 
> Isn't the format similar to a <get> _response_ versus the request?
> 
> ===
> 
> Section 3
> 
> s/and and/and/
> 
> Joe
> 
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod