Re: [netmod] Adam Roach's No Objection on draft-ietf-netmod-entity-07: (with COMMENT)

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Thu, 11 January 2018 07:13 UTC

Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ECAA512EA87; Wed, 10 Jan 2018 23:13:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DKAQjXxmbBu8; Wed, 10 Jan 2018 23:13:19 -0800 (PST)
Received: from atlas5.jacobs-university.de (atlas5.jacobs-university.de [212.201.44.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 88EA512EA81; Wed, 10 Jan 2018 23:13:19 -0800 (PST)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas5.jacobs-university.de (Postfix) with ESMTP id 52BAD6BA; Thu, 11 Jan 2018 08:13:18 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas5.jacobs-university.de ([10.70.0.217]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10032) with ESMTP id afOOuiYaWu50; Thu, 11 Jan 2018 08:13:17 +0100 (CET)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "Jacobs University CA - G01" (verified OK)) by atlas5.jacobs-university.de (Postfix) with ESMTPS; Thu, 11 Jan 2018 08:13:18 +0100 (CET)
Received: from localhost (demetrius1.jacobs-university.de [212.201.44.46]) by hermes.jacobs-university.de (Postfix) with ESMTP id 1DA842013D; Thu, 11 Jan 2018 08:13:18 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius1.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id uqCsz57P7FsR; Thu, 11 Jan 2018 08:13:17 +0100 (CET)
Received: from elstar.local (unknown [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id 943F12013C; Thu, 11 Jan 2018 08:13:17 +0100 (CET)
Received: by elstar.local (Postfix, from userid 501) id 7BF46420B309; Thu, 11 Jan 2018 08:13:17 +0100 (CET)
Date: Thu, 11 Jan 2018 08:13:17 +0100
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: Adam Roach <adam@nostrum.com>
Cc: The IESG <iesg@ietf.org>, netmod-chairs@ietf.org, draft-ietf-netmod-entity@ietf.org, netmod@ietf.org
Message-ID: <20180111071317.wvqyyufx4bkyz5pi@elstar.local>
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
Mail-Followup-To: Adam Roach <adam@nostrum.com>, The IESG <iesg@ietf.org>, netmod-chairs@ietf.org, draft-ietf-netmod-entity@ietf.org, netmod@ietf.org
References: <151565374680.30635.814396227713285360.idtracker@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <151565374680.30635.814396227713285360.idtracker@ietfa.amsl.com>
User-Agent: NeoMutt/20171215
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/KFRdfTrxUIVzs-6vd-0RA8l3tgc>
Subject: Re: [netmod] Adam Roach's No Objection on draft-ietf-netmod-entity-07: (with COMMENT)
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jan 2018 07:13:22 -0000

On Wed, Jan 10, 2018 at 10:55:46PM -0800, Adam Roach wrote:
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> I have one correction and one question about the ietf-hardware YANG module.
> 
>          enum exa {
>            value 14;
>            description
>              "Data scaling factor of 10^15.";
>          }
>          enum peta {
>            value 15;
>            description
>              "Data scaling factor of 10^18.";
>          }
> 
> I believe this is backwards -- "peta" should be 10^15, while "exa" should be 10^18.

I agree this is wrong. This bug was most likely inherited from RFC
3433 but luckily there is a confirmed errata for RFC 3433. So Martin
should fix this in the YANG module (and his copy of the MIB module).

>      typedef sensor-value-precision {
>        type int32 {
>          range "-8 .. 9";
>        }
> 
> Why is this an int32 rather than an int8?

Likely because they way this was defined in the MIB module:

   SYNTAX Integer32 (-8..9)

I assume using int8 would be fine as well. (Note that YANG update
rules allow to expand the range restriction but they do not allow to
replace int8 with int32; so the range resulting from the type is a
hard limit, the range restriction is an expandable limit. I guess in
this case using int8 would be safe but then this is a slight (but
likely not important) departure from the MIB module.)

/js

-- 
Juergen Schoenwaelder           Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
Fax:   +49 421 200 3103         <http://www.jacobs-university.de/>