[netmod] RtgDir review: draft-ietf-netmod-yang-data-ext

Tal Mizrahi <tal.mizrahi.phd@gmail.com> Thu, 30 January 2020 14:09 UTC

Return-Path: <tal.mizrahi.phd@gmail.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 17CF31200E5; Thu, 30 Jan 2020 06:09:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KAHSCcYU8D6e; Thu, 30 Jan 2020 06:08:59 -0800 (PST)
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F51F12007C; Thu, 30 Jan 2020 06:08:59 -0800 (PST)
Received: by mail-wr1-x434.google.com with SMTP id c9so4188514wrw.8; Thu, 30 Jan 2020 06:08:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=QtwsaC9t9ghDHK4r61CWJ06HMvdxC/huecK+7q+1XCs=; b=AWs+ZONY/l1Gig0/BaZmYqLokVG2lwUKmMSoViq2GFFXBSY4BEpfK+a8sGTd/B/cqa FOX3ipDj118YW3wYzoQ4hufPhbpPOJPn+WOIyH3qcWklMFYqxWRYCmyVITFH1oTKx9fQ ybRYwGmyp0RpwQzzzZw7/yGCI57AsHsC5DZ4C11TlVLLK04af9jHajxroKFjM3eK6yjK 5jLDQd55P/bpZS8JPVY01f8EztExhYhIbuHG1FkxhN/2G7TYTAFj0XdBvD7u//jUUvqZ auLq8W+OBP8HkD4iCNi6Bnatl4naysa/BgXgvEJ4Ia2kV40cCNd/6a+O7Gt9XEGXojFr cc7w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=QtwsaC9t9ghDHK4r61CWJ06HMvdxC/huecK+7q+1XCs=; b=kWEf2gNIntBkENX9uSreK94F2p2wTPHKvZK1a4/UrRBXbjp05rLRSX6GljV8l4opys /sPGYH9QFKpemTfVkaxpG7qlGI0Oxvdn2IVYUY4k8bkCfkUw2xV4VBv6YsV7i6//46Na 5qLIYhJ7B5xzPytcH70JhQ7vJBymi84e6/EmrSfE69Ixfh8DfmiXJB2VJK9aL0GzPdW+ RwLpE50UJwiyBdYt1wfdHaPtg0fOrIOIltnBoyzOCRWutD4uqBPBVudOhinlZJ3Kjblt aRjBPQQhlZehY5buXH4mKZqNv301p+fu8dsAVUhw6ietzymqGl4adaXc8LvkzwRyskwz t40w==
X-Gm-Message-State: APjAAAUra6eBMi9rqTClChVMWH+y8oF6P+ZHgQ8t+YTrq4LZ4EUG12PP 97W+s8pRZ4Gkqsv1MuVU1VuCjnFa8y0+fSXJneT8A3vUjZg=
X-Google-Smtp-Source: APXvYqwDdEcYQqQl2sRAMgd6PODMYEWrdHRUXoiUg61wCW33zeYNORA5Hz3wLUPQ2XWH8rp/WnN9RcuGzLpuQXs0PAQ=
X-Received: by 2002:adf:ee01:: with SMTP id y1mr6173150wrn.152.1580393337066; Thu, 30 Jan 2020 06:08:57 -0800 (PST)
MIME-Version: 1.0
From: Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Date: Thu, 30 Jan 2020 16:08:44 +0200
Message-ID: <CABUE3XmYSEkXVgnQH75zd=KXjF9tfXX346s1_mYpLDVMD6--Xw@mail.gmail.com>
To: rtg-ads@ietf.org, draft-ietf-netmod-yang-data-ext@ietf.org
Cc: netmod@ietf.org, rtg-dir@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="0000000000007618a6059d5bff20"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/Lq-67TYtPXQRsSQgpZAHIb4IUWc>
Subject: [netmod] RtgDir review: draft-ietf-netmod-yang-data-ext
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2020 14:09:01 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and sometimes
on special request. The purpose of the review is to provide assistance to
the Routing ADs. For more information about the Routing Directorate, please
see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other IETF Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-netmod-yang-data-ext-05
Reviewer: Tal Mizrahi
Review Date: January 30th, 2020
Intended Status: Standards Track

Summary:
This document is basically ready for publication, but has two minor issues
that should be considered prior to publication.

Comments:
The document is well-written and clear, even to the non-expert reader. The
examples are highly appreciated.

Minor issues:
- The following definition in the "Terminology" section is recursive, and
not very clear at this point in the document (it becomes clearer only after
the "Definitions" section). It would be highly recommended to rephrase this:

'YANG data structure: A data structure defined with the "structure"
statement.'

- The "Definitions" section seems to define a single term, the YANG data
structure. It would be best to rename the section.

Cheers,
Tal Mizrahi.