Re: [netmod] syslog-model-17 shepherd writeup issues -references
Robert Wilton <rwilton@cisco.com> Thu, 14 September 2017 11:09 UTC
Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 123891321A7; Thu, 14 Sep 2017 04:09:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ghcqBbh3glu3; Thu, 14 Sep 2017 04:09:36 -0700 (PDT)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3A430120724; Thu, 14 Sep 2017 04:09:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6328; q=dns/txt; s=iport; t=1505387375; x=1506596975; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=GovQD+BVTKJQxeKtkS0WR87SVYqVfUPUMlp+ksZaM+E=; b=hgSzx3O43PiGJoVbzvuioVJ79XDSTGyfcb7tYD1WafCAtcg+HVMUg4O1 R8KkOIbAnLIqnbxprnRDql6PCVCxMUVYQWM9vaKcG7e9ykOMWATkxryew 2SmIhxwsxqrXHBuZgTNzDI4RNpnxRefmphMkOw6towRIGnzFXBWC9RJim U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ChAQAxYrpZ/xbLJq1TCRkBAQEBAQEBAQEBAQcBAQEBAYQ+bieDd4sUjwKBegkilUFmghIKGAuESk8ChGAWAQIBAQEBAQEBayiFGAEBAQEDAQEhDwEFNgsMBAsOAwQBAQECAiYCAicoCAYBDAYCAQGKLhCsH4InizUBAQEBAQEBAQEBAQEBAQEBAQEBAQEdgQ6CHYNSgWMrC4JygkCCDhSDKYJgBZEpj1CHWox4ghOFaINahyGNW4QcgzmBOSYHKoENMiEIHBVKhRkcgWg/NgGJAQEBAQ
X-IronPort-AV: E=Sophos;i="5.42,392,1500940800"; d="scan'208";a="697182907"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2017 11:09:30 +0000
Received: from [10.63.23.66] (dhcp-ensft1-uk-vla370-10-63-23-66.cisco.com [10.63.23.66]) by aer-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id v8EB9UOk030675; Thu, 14 Sep 2017 11:09:30 GMT
To: Kent Watsen <kwatsen@juniper.net>, "t.petch" <ietfc@btconnect.com>, "netmod@ietf.org" <netmod@ietf.org>
Cc: "draft-ietf-netmod-syslog-model@ietf.org" <draft-ietf-netmod-syslog-model@ietf.org>
References: <49B4BE2F-6912-49BE-9E4A-830146309AB2@juniper.net> <019b01d32c76$fa7dfc40$4001a8c0@gateway.2wire.net> <8CF097E4-CEB7-4C4E-AC7D-F7F896CD1BB7@juniper.net>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <516d3881-4fbb-fad0-5413-404f644ea63b@cisco.com>
Date: Thu, 14 Sep 2017 12:09:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <8CF097E4-CEB7-4C4E-AC7D-F7F896CD1BB7@juniper.net>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/M-1W5o3XvFaTe8INeQNmbhsxySs>
Subject: Re: [netmod] syslog-model-17 shepherd writeup issues -references
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Sep 2017 11:09:38 -0000
Hi Kent, Clyde, Does the "pattern-match" leaf need to be explicitly pulled out in security considerations? Allowing a client to provide an arbitrary regex could potentially cause a regex engine to overflow its stack and crash. An example of an regex overflow is described here: http://www.regular-expressions.info/catastrophic.html Thanks, Rob On 13/09/2017 18:08, Kent Watsen wrote: > Hi Tom, > > Thanks. The fix I'm looking for is for the 'pattern-match' leaf > to have a 'reference' statement to Std-1003.1-2008, and for S4.1 > to also list Std-1003.1-2008 as a draft-level reference. > > I was going to point out the typo "the the" as well, but figured > that the RFC Editor would get it. > > K. // shepherd > > > -- > > Kent > > You flag Std-1003.1-2008 as listed as a normative reference but not used > anywhere in the document. In the Descriptions, but not in the s.4.1 > references, I see > > This leaf describes a Posix 1003.2 regular expression ... > > twice, which may, or may not, relate to this issue. > > Back in July, clyde said > "I will insert a normative reference to POSIX 1003.2 in the next > revision of the draft." > > In a similar vein, RFC6991 appears in a reference statement but nowhere > else. > > As you point out, RFC6021 is referenced but is obsoleted by RFC6991 so > should not be. > > And in a slightly different vein, > > registry [RFC7895]/>. Following the format in [RFC7950]/>, the the > > looks odd for plain text and for the repetition of 'the'.. > > Tom Petch > > ----- Original Message ----- > From: "Kent Watsen" <kwatsen@juniper.net> > To: <netmod@ietf.org> > Cc: <draft-ietf-netmod-syslog-model@ietf.org> > Sent: Tuesday, September 12, 2017 10:50 PM > Subject: [netmod] syslog-model-17 shepherd writeup issues > > >> Clyde, all, >> >> In reviewing the draft for Shepherd writeup, I found the following > issues that I think need to be addressed before the document can be sent > to Benoit for AD review: >> >> 1. Idnits found the following: >> >> Summary: 3 errors (**), 0 flaws (~~), 3 warnings (==), 1 comment > (--). >> ** There are 2 instances of too long lines in the document, the > longest one >> being 3 characters in excess of 72. >> >> ** Obsolete normative reference: RFC 6021 (Obsoleted by RFC 6991) >> >> ** Downref: Normative reference to an Historic RFC: RFC 6587 >> >> == Missing Reference: 'RFC5425' is mentioned on line 359, but not > defined >> '[RFC5425], [RFC5426], [RFC6587], and [RFC5848]....' >> >> == Unused Reference: 'RFC7895' is defined on line 1406, but no > explicit >> reference was found in the text >> '[RFC7895] Bierman, A., Bjorklund, M., and K. Watsen, "YANG > Module L...' >> == Unused Reference: 'RFC6242' is defined on line 1435, but no > explicit >> reference was found in the text >> '[RFC6242] Wasserman, M., "Using the NETCONF Protocol over > Secure Sh...' >> >> 2. `rfcstrip` extracted "ietf-syslog.yang", which is missing > "@yyyy-mm-dd" in its name >> 3. neither `pyang` nor `yanglint` found any errors with > ietf-syslog.yang. pyang says >> for vendor-syslog-types-example: statement "identity" must have > a "description" >> substatement. >> >> 4. testing the examples in the draft against yanglint: >> - for both examples: Missing element's "namespace". (/config) >> - just removing the "<config>" element envelop resolves this > error. >> 5. the 2nd example uses IP address "2001:db8:a0b:12f0::1", but this > SHOULD be a >> domain name (e.g., foo.example.com) >> >> 6. in the YANG module, anywhere you have an RFC listed in a > 'description' statement, >> there should be a 'reference' statement for that RFC. >> >> 7. in the tree diagram, the leafrefs no longer indicate what they > point at, they now all >> just say "leafref". Did you do this on purpose, or are you using > a different tree >> output generator from -15? >> >> 8. RFC6536 is listed as a normative reference, but it probably should > be informative. >> 9. Std-1003.1-2008 is listed as a normative reference, but it is not > used anywhere in the document. >> 10. RFC6242 is listed as an informative reference, but it is not used > anywhere in the document. >> 11. the document fails to declare its normative references to > ietf-keystore and ietf-tls-client-server. >> Note: you manually entered the "[RFC yyyy], and [RFC xxxx]" > references… >> 12. The IANA considerations section seems asymmetric. Either put > both registry insertions into >> subsections, or keep them both at the top-level… >> >> 13. reviewing the final document against my original YD review, I have > the following responses. Let's be sure to close out these items as > well. Ref: https://mailarchive.ietf.org/arch/msg/netmod/10lo41Ud4A3ZN11 > s-0gOfCe8NSE >> 1. ok >> 2. better >> 3. should be: s/the message/these messages/ [RFC Editor might've > caught this] >> 4. better >> 5. still feel the same way, but no biggee >> 6. better, but from 8174, you should add the part "when, and only > when, they appear in all capitals, as shown here." >> 7. fixed >> 8. fixed >> 9. you did what I asked, but the result still isn't satisfying... >> 10. some improvements made in this area, but my ask wasn't among them >> 11. better >> 12. better, but I think the 4th line should be indented too, right? >> 13. better, but I wish you called S1.3 "Tree Diagram Notation" >> 14. fixed >> 15. fixed >> 16. fixed >> 17. fine >> 18. still a weird line brake here. try putting the quoted string on > the next line. >> 19. fixed >> 20. fixed >> 21. not fixed (re: yang-security-guidelines) >> 22. fine >> >> >> PS: please also be sure to follow-up with Benoit on his AD review. >> >> Thanks, >> Kent // shepherd & yang doctor >> >> >> >> _______________________________________________ >> netmod mailing list >> netmod@ietf.org >> https://www.ietf.org/mailman/listinfo/netmod >> > > > _______________________________________________ > netmod mailing list > netmod@ietf.org > https://www.ietf.org/mailman/listinfo/netmod
- [netmod] syslog-model-17 shepherd writeup issues Kent Watsen
- Re: [netmod] syslog-model-17 shepherd writeup iss… t.petch
- Re: [netmod] syslog-model-17 shepherd writeup iss… Kent Watsen
- Re: [netmod] syslog-model-17 shepherd writeup iss… Robert Wilton
- Re: [netmod] syslog-model-17 shepherd writeup iss… Kent Watsen
- Re: [netmod] syslog-model-17 shepherd writeup iss… t.petch
- Re: [netmod] syslog-model-17 shepherd writeup iss… Kent Watsen
- Re: [netmod] syslog-model-17 shepherd writeup iss… Benoit Claise
- Re: [netmod] syslog-model-17 shepherd writeup iss… Clyde Wildes (cwildes)
- Re: [netmod] syslog-model-17 shepherd writeup iss… t.petch
- Re: [netmod] syslog-model-17 shepherd writeup iss… Clyde Wildes (cwildes)
- Re: [netmod] syslog-model-17 shepherd writeup iss… t.petch