Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02

[Italo Busi <[e-mail]>]

Hi Kent,

Thanks for your reply

For what I am concerned, the clarification you have provided is sufficient to me (no need to change the code)

You might also consider adding similar text at the beginning of Appendix A, if you think this helps. Something along the line:

The script forces the desired maximum line length to be a bit longer than the raw header text defined in sections 7 and 8, to further ensure that the header will always have some '=' characters wrapping around the header, for readability, in the unlikely scenario that such a narrow-width is needed.

Italo

Italo Busi
Principal Optical Transport Network Research Engineer
Huawei Technologies Co., Ltd.
Tel : [phone]
Email : [e-mail]
[cid:image003.png@01D5156A.B2C94830]

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

From: Kent Watsen [mailto:[e-mail]]
Sent: lunedì 27 maggio 2019 19:57
To: Italo Busi <[e-mail]>
Cc: Lou Berger <[e-mail]>; [e-mail]; [e-mail]
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02


Hi Italo,



1) Section 7.2.1 (Folding for Single Backslash Strategy) says:

  Ensure that the desired maximum line length is not less than the
  minimum header, which is 46 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

However, the first line defined in section 7.1.1 is a "45-character string".
I think that the paragraph be changed as:

  Ensure that the desired maximum line length is not less than the
  minimum header, which is 45 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

Fixed in my local copy.



2) Section 8.2.1 (Folding for Double Backslash Strategy) says:


  Ensure that the desired maximum line length is not less than the
  minimum header, which is 45 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

However, the first line defined in section 8.1.1 is a "46-character string".
I think that the paragraph be changed as:

  Ensure that the desired maximum line length is not less than the
  minimum header, which is 46 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

Fixed in my local copy.



A question for clarification. Reading the following code in Appendix A:

    if [[ $strategy -eq 2 ]]; then
      min_supported=`expr ${#hdr_txt_2} + 8`
    else
      min_supported=`expr ${#hdr_txt_1} + 8`
    fi

It seems to me that the minimum lengths applied by the code in Appendix A are be 53 and 54 (instead of 45 and 46 respectively)

Is my understanding correct?

The script is not conflicting with the draft, as it does ensure that the length is not less than the raw header text.  Though, to your point, it adds an additional buffer to further ensure that the header will always have some '=' characters wrapping around the header, for readability, in the unlikely scenario that such a narrow-width is needed.   I could go either way on this, does anyone else have an opinion?




Thanks, Italo

Kent // author