Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07

"Rob Wilton (rwilton)" <rwilton@cisco.com> Wed, 06 November 2019 11:28 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B1AB12086C for <netmod@ietfa.amsl.com>; Wed, 6 Nov 2019 03:28:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=N1KITxCB; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=RH4E4Dyk
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mjDprS8a5beF for <netmod@ietfa.amsl.com>; Wed, 6 Nov 2019 03:28:10 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 504E0120869 for <netmod@ietf.org>; Wed, 6 Nov 2019 03:28:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4036; q=dns/txt; s=iport; t=1573039690; x=1574249290; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gnT9SK6xBxKtY7D9qt6zButT7rdvnknWVoVmd9uEHjY=; b=N1KITxCByZom97xia6AGxAkCIDiKj/WyJoh54nz/t3KZvRRbNCClHF47 c/rGS+n7UY7GDCjN0/IZBb8JR3j8FQ2NAH5W68IG+JxuVo9rNdKUprUK+ 2twTvUabD8SsU49X23QZ7+yd2ztPRPt5mMF/HSgtV231SJUqTULcqBzua U=;
IronPort-PHdr: 9a23:NH9SLhY/a0/wJAqLgZ5dEnL/LSx94ef9IxIV55w7irlHbqWk+dH4MVfC4el20gebRp3VvvRDjeee87vtX2AN+96giDgDa9QNMn1NksAKh0olCc+BB1f8KavwcC0+AMNEfFRk5Hq8d0NSHZW2ag==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AJAACWrcJd/5ldJa1mGgEBAQEBAQEBAQMBAQEBEQEBAQICAQEBAYFqBQEBAQELAYFKUAVsWCAECyoKhB+DRgOEWoYkgl6JVo4ogS6BJANUCQEBAQwBARgLCgIBAYN7RQIXg3ckNAkOAgMLAQEEAQEBAgEFBG2FNwyFUQEBAQEDAQEQEREMAQEsCwELBAIBBgIOAwQBAQECAiMDAgICHwYLFAEICAEBBAENBQgagwGCRgMuAQIMlRiQYgKBOIhgdYEygn4BAQWFBQ0LghcDBoEOKAGMExiBQD+BV4JMPoIbRwEBgWODDjKCLI0mgl+dES1BCoIkhxWKFoQsgjyHXY9TjkOIL4ISjyMCBAIEBQIOAQEFgVI5gVhwFTuCbFARFIMGg3OFFIU/dIEoj1MBgQ4BAQ
X-IronPort-AV: E=Sophos;i="5.68,274,1569283200"; d="scan'208";a="358408489"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 06 Nov 2019 11:28:08 +0000
Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id xA6BS8SR031487 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 6 Nov 2019 11:28:08 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 6 Nov 2019 05:28:08 -0600
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 6 Nov 2019 05:28:07 -0600
Received: from NAM05-DM3-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 6 Nov 2019 05:28:07 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O2QbENyegqjUTO3oK/4VTKG7A+TMb8N0pF72NeZWwwSrOArlqApGLFnmriLGzWA5NgwcR6nfLYLP3Pzuvro5UtGhbNGspWUvrf5w3Td2o2AJ+WGols/6cxW4IIOf66cFbIV2I84EDF+Y5eqXghaS6wc7QKvixbhFKKyP9PePXKzcw0CAcv5q2MT5lphngkkbNVNqMW3qQ2+ZvKEikw8eqb02dOZec8v1F9KqHkag27I8vOPTY/4F3rY1UBLdy6Gr76zsW5/9VDLFI1j16GC0F8bKnA8tqeMgRxW/N/sl4Y0kJsKPMwwv3jRDF5ByjvuAuDzWqONPcyu0tViV0YO5jA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gnT9SK6xBxKtY7D9qt6zButT7rdvnknWVoVmd9uEHjY=; b=i7qmcIqhLQL9tknU9hwg7M8xEM29DnQeFArn+Ww9XtFyIjy8jljDGx4o14f+V+1wIfdhWMQsHwnawWxveezReO+jGpv1+hkjBUEky/o2cgkGuCYpqWBNngjntROaa3s4qjB0ZNkdO7f8Nv/7bav+rh9lrECrhIrpIdRJchArD1wEiWGy72c5Jybtv6eUmeSoNFXtMhmmLBlKZTS1ITOFP5cOCqkRTAr0R41zpsTQF3c84/ihuglpL8Zg5fodeHm2zhaEYTM14UyPahmJIx9HbKTG2PO9/1NapyBVRXDZJR6u4tIFwDvK4bgRjAUF5d26LZgiANwODHJJfYvyr4QYWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gnT9SK6xBxKtY7D9qt6zButT7rdvnknWVoVmd9uEHjY=; b=RH4E4Dyk/dG6SaqSy+0Imf5FQiVLMw0yW0Vt38tIleUGbWCKNRIwHZnaisdZoQ+4QZ3oHelcaQ13qeg27tNRWqp4yGjOwJODMdtNryB07Qkv0TtSh/3tOwLSeLF5GruD8HHqWRHwRjjc5ITHB6PeYZMqgXczFgHyKNDdOZG05Zw=
Received: from MN2PR11MB4366.namprd11.prod.outlook.com (52.135.38.209) by MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Wed, 6 Nov 2019 11:28:05 +0000
Received: from MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::49b6:bc5c:bd3e:203c]) by MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::49b6:bc5c:bd3e:203c%5]) with mapi id 15.20.2430.020; Wed, 6 Nov 2019 11:28:05 +0000
From: "Rob Wilton (rwilton)" <rwilton@cisco.com>
To: Qin Wu <bill.wu@huawei.com>, Mahesh Jethanandani <mjethanandani@gmail.com>
CC: Kent Watsen <kent+ietf@watsen.net>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
Thread-Index: AdWUPdYYqw08TE00TgiJf8q0tlodOQAQnzNA
Date: Wed, 06 Nov 2019 11:28:05 +0000
Message-ID: <MN2PR11MB4366B4B9F548D521854C8276B5790@MN2PR11MB4366.namprd11.prod.outlook.com>
References: <B8F9A780D330094D99AF023C5877DABAA93EB714@dggeml531-mbs.china.huawei.com>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABAA93EB714@dggeml531-mbs.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rwilton@cisco.com;
x-originating-ip: [173.38.220.45]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 529a4ed7-faf3-4545-1726-08d762ac64a9
x-ms-traffictypediagnostic: MN2PR11MB4221:
x-ms-exchange-purlcount: 3
x-microsoft-antispam-prvs: <MN2PR11MB4221F4E6E34D4CC77057A486B5790@MN2PR11MB4221.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 02135EB356
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(346002)(366004)(39860400002)(136003)(13464003)(199004)(189003)(6436002)(66066001)(486006)(476003)(71200400001)(71190400001)(11346002)(6306002)(9686003)(110136005)(55016002)(54906003)(14444005)(446003)(66476007)(66556008)(64756008)(66946007)(6246003)(66446008)(76116006)(256004)(316002)(2906002)(26005)(52536014)(229853002)(478600001)(86362001)(53546011)(99286004)(6506007)(186003)(4326008)(25786009)(5660300002)(14454004)(102836004)(33656002)(966005)(8676002)(8936002)(81156014)(7696005)(3846002)(76176011)(81166006)(6116002)(74316002)(7736002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4221; H:MN2PR11MB4366.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: m9bkHV62TljFgJPOwSYxFnfYhJ0w7bwjQ+oEFN5Ki9K9wq4NivySvVeP48Btrzc4JUufuk4PizMOYxBTEByfVYuQwlfsx5HuphbKwgzSPT3PrmX34qTn5kz6/UjGCbMOiaHArSrKS6COGmKGmHOEBj9s118OEkyhjWLhIYaq+BAToITR+byo7X1QqqjnG95PheeweJcrIl/TS9F9l1LK0vtHQiVCV+rm029j493/GULmyd5LEksItFyyeJ7bS+6MaFipylllB15fKX+Ik5fvg3j2o+mWKizwCFUng6HFo7RL4gWfTJLsPirSX2SJLAydB6o24Q94AyRDqd9ClI8er0fGBHfykwuGDcelkqUjAN8CS2EWKWO1f5kTjHYGNirCwjgy2/adKlsZMcHdFqj8LB2AXmfWkxkTqSQN3sh9ha38MN/IgNafw/1TC7AfvhhxiQdkygiZd6MXSiwf/KvNgo2WrWyH0lC1Hz5t8GIEu3c=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 529a4ed7-faf3-4545-1726-08d762ac64a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 11:28:05.7075 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yxh8BpEiWBDo6zcXYUt6OUqgpddUT4H65HSineB+/dExfMXEGsdkeb6nS1KMCmLnxhB2Es4WWqp3v+yzFXW9Qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4221
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.13, xch-rcd-003.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/N71mtX7gstPSBCOl3BeHTQ7hNGA>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 11:28:13 -0000

Hi Qin,

> -----Original Message-----
> From: Qin Wu <bill.wu@huawei.com>
> Sent: 06 November 2019 01:03
> To: Mahesh Jethanandani <mjethanandani@gmail.com>
> Cc: Rob Wilton (rwilton) <rwilton@cisco.com>; Kent Watsen
> <kent+ietf@watsen.net>; netmod@ietf.org
> Subject: RE: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
> 
> -----邮件原件-----
> 发件人: Mahesh Jethanandani [mailto:mjethanandani@gmail.com]
> 发送时间: 2019年11月6日 8:57
> 收件人: Qin Wu <bill.wu@huawei.com>
> 抄送: Robert Wilton <rwilton@cisco.com>; Kent Watsen
> <kent+ietf@watsen.net>; netmod@ietf.org
> 主题: Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
> 
> Hi Qin,
> 
> > On Nov 5, 2019, at 4:35 PM, Qin Wu <bill.wu@huawei.com> wrote:
> >
> > 2. Suggest to add a
> >> paragraph in the section 5 to explain which common type or type in
> >> specific module is imported
> > [RW]
> >
> > Please can you clarify this comment, because I'm not sure what you are
> > requesting here.  I've left an open issue to track this:
> > https://github.com/netmod-wg/interface-extensions-yang/issues/21
> >
> > [Qin]: See 1st paragraph, section 4 of RFC8344 as an example.
> 
> [mj] You mean to say that the draft should specify which RFCs the module
> imports typedefs from, and which RFCs it references in the model somewhere
> in the draft. For example, it imports ietf-yang-types and therefore should
> refer to RFC 6991 somewhere in the draft (but outside the model). Right?
> 
> [Qin]:That's correct.
[RW]
I'm happy to list the RFCs that the modules depend on/references, which presumably also helps keeps the tooling happy about the RFC references.

But I'm not convinced that categorising them as typedef dependencies is really helpful in the RFC text.  If this information is important then I would suggest that it should be annotated in the YANG (I've previously raised this as a potential issue on the YANG Next issue tracker: https://github.com/netmod-wg/yang-next/issues/95).

Perhaps adding the following text is enough:

Proposed/updated:

4.  Interface Extensions YANG Module

   This YANG module augments the interface container defined in
   [RFC8343].  It also contains references to [RFC6991] and [RFC7224].

...

Proposed/updated:

5.  Interfaces Ethernet-Like YANG Module

   This YANG module augments the interface container defined in RFC 8343
   [RFC8343] for Ethernet-like interfaces.  This includes Ethernet
   interfaces, 802.3 LAG (802.1AX) interfaces, Switch Virtual
   interfaces, and Pseudo-Wire Head-End interfaces.  It also contains
   references to [RFC6991], [RFC7224], and [IEEE802.3.2-2019].

...


Thanks,
Rob
 

> >
> > _______________________________________________
> > netmod mailing list
> > netmod@ietf.org
> > https://www.ietf.org/mailman/listinfo/netmod
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com
> 
>