Re: [netmod] Adam Roach's No Objection on draft-ietf-netmod-rfc6087bis-18: (with COMMENT)

Adam Roach <adam@nostrum.com> Thu, 08 March 2018 23:55 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 554CB126C0F; Thu, 8 Mar 2018 15:55:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.889
X-Spam-Level:
X-Spam-Status: No, score=-1.889 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, T_RP_MATCHES_RCVD=-0.01, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ATseSS6BK9eY; Thu, 8 Mar 2018 15:55:26 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6D5CE124319; Thu, 8 Mar 2018 15:55:26 -0800 (PST)
Received: from Svantevit.local (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id w28NtN5w085864 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 8 Mar 2018 17:55:24 -0600 (CST) (envelope-from adam@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Svantevit.local
To: Andy Bierman <andy@yumaworks.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-netmod-rfc6087bis@ietf.org, NetMod WG Chairs <netmod-chairs@ietf.org>, Kent Watsen <kwatsen@juniper.net>, NetMod WG <netmod@ietf.org>
References: <152050158005.21412.3389388204390015375.idtracker@ietfa.amsl.com> <CABCOCHSmCioJPNM5b9J-5WCsXe_J2jMzKKCD8fw02uh-D5nNdA@mail.gmail.com>
From: Adam Roach <adam@nostrum.com>
Message-ID: <e627d122-a709-c41c-b58a-b5890b8d2103@nostrum.com>
Date: Thu, 8 Mar 2018 17:55:17 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CABCOCHSmCioJPNM5b9J-5WCsXe_J2jMzKKCD8fw02uh-D5nNdA@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------FA286F8DF434042736862FF6"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/PQ10sreigE1LPO6DemWoA8VACzA>
Subject: Re: [netmod] Adam Roach's No Objection on draft-ietf-netmod-rfc6087bis-18: (with COMMENT)
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2018 23:55:28 -0000

Thanks for your quick response! I have some additional comments inline.

On 3/8/18 2:00 PM, Andy Bierman wrote:
>
>     ---------------------------------------------------------------------------
>
>     §3:
>
>     >  YANG data model modules under review are likely to be contained in
>     >  Internet-Drafts.  All guidelines for Internet-Draft authors MUST be
>     >  followed.  The RFC Editor provides guidelines for authors of RFCs,
>     >  which are first published as Internet-Drafts.  These guidelines
>     >  should be followed and are defined in [RFC7322] and updated in
>     >  [RFC7841] and "RFC Document Style" [RFC-STYLE].
>
>     Maybe include a pointer to draft-flanagan-7322bis also, as this
>     document is in
>     the process of being revised.
>
>
>
> This does not appear to be a WG document, so it seems premature to 
> include it

Like RFC 7322 before it, 7322bis will be published as part of the IAB 
stream, not part of the IESG stream, so it will never be a WG document. 
The "flanagan" in "draft-flanagan" is Heather Flanagan, the RFC editor. 
While the contents may continue to evolve, I don't think there's any 
doubt that a revision of the document is in the works, and it's all but 
guaranteed that such revision will be published at some point and 
obsolete RFC 7322.

To be clear: I'm okay with you leaving the text as-is, but I think that 
the additional citation would be an improvement.

>
>     ---------------------------------------------------------------------------
>
>     §3.8:
>
>     >  If there are no
>     >  IANA considerations applicable to the document, then the IANA
>     >  Considerations section stating that there are no actions is removed
>     >  by the RFC Editor before publication.
>
>     I believe that the current state of play is that removal is left
>     to the authors'
>     discretion, and that the IANA has a weak preference for leaving in
>     sections that
>     say "No actions are requested of IANA." This may change. Rather
>     than try to
>     capture the (potentially changing) state of play, my suggestion is to
>     remove the text I quote above.
>
>
> This was just changed to "might be removed"
>
> Is that good enough?

Yes, that seems fine.
>
>     ---------------------------------------------------------------------------
>
>     §4.11.2:
>
>     >  The following typedef from [RFC6991] demonstrates the proper use of
>     >  the "pattern" statement:
>     >
>     >      typedef ipv4-address-no-zone {
>     >        type inet:ipv4-address {
>     >          pattern '[0-9\.]*';
>     >        }
>     >        ...
>     >      }
>
>     By contrast, RFC 6021 has a somewhat more complex production:
>
>          pattern
>              '(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}'
>            +  '([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])'
>            + '(%[\p{N}\p{L}]+)?';
>
>     Is there any consensus on how complex the pattern validation
>     should be? I've
>     seen some YANG modules with patterns that occupied more than half
>     a page. Is
>     that encouraged, discouraged, or neither? It seems some guidance
>     on this
>     specific issue would be useful, as the currently published modules
>     appear to be
>     all over the map on this topic.
>
>
> Not changing any text since the pattern complexity depends on the 
> structure
> of the text that is being modeled.

It's a little more than that; it comes down to the purpose of the regex, 
and how much validation is expected to be provided. For example, 
ignoring the interface designation, the validation of IP addresses 
between the two productions above is radically different. The second one 
is set up so that anything it matches will be a syntactically correct IP 
address. The first one, by contrast, would accept any of the following 
as valid:

  * 999.999.999.999
  * 1.3.6.1.2.1.2.2.1.3
  * 17
  * .......


This seems a bit more than academic to me: given that modules are 
included into other modules, wild inconsistencies in validation 
philosophies can be surprising to users. For example, if an operator 
gets used to the syntax for IP addresses generating warnings or errors 
when they are out of range, then they may be frustrated to discover that 
IP addresses in other locations are not.

Clearly, the items that have already been published can't be changed, 
but it seems like there is room for guidance about whether to optimize 
for simple regexes, or for more rigorous ones.

/a