Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02

Italo Busi <Italo.Busi@huawei.com> Wed, 29 May 2019 13:02 UTC

Return-Path: <Italo.Busi@huawei.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5335F120192; Wed, 29 May 2019 06:02:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.19
X-Spam-Level:
X-Spam-Status: No, score=-4.19 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wZTabHAJcC9l; Wed, 29 May 2019 06:02:06 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 04AAA120140; Wed, 29 May 2019 06:02:06 -0700 (PDT)
Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 1CB52C755E9A04CE5706; Wed, 29 May 2019 14:02:04 +0100 (IST)
Received: from LHREML504-MBS.china.huawei.com ([10.201.109.59]) by LHREML714-CAH.china.huawei.com ([10.201.108.37]) with mapi id 14.03.0415.000; Wed, 29 May 2019 14:02:03 +0100
From: Italo Busi <Italo.Busi@huawei.com>
To: Kent Watsen <kent@watsen.net>
CC: Lou Berger <lberger@labn.net>, "netmod@ietf.org" <netmod@ietf.org>, "netmod-chairs@ietf.org" <netmod-chairs@ietf.org>
Thread-Topic: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02
Thread-Index: AQHVCSaY+iCIbhU/PESy/n6QJGx4eqZ6EnSggAU1uACAAVcTMIAAJMqAgAFnCNA=
Date: Wed, 29 May 2019 13:02:02 +0000
Message-ID: <91E3A1BD737FDF4FA14118387FF6766B2774E2B7@lhreml504-mbs>
References: <e6fc4541-891a-60cb-e956-86f238d09f14@labn.net> <91E3A1BD737FDF4FA14118387FF6766B2774C768@lhreml504-mbs> <0100016afa70796c-314cbf69-755f-4ae2-b83a-d53507714c69-000000@email.amazonses.com> <91E3A1BD737FDF4FA14118387FF6766B2774DA44@lhreml504-mbs> <0100016aff4d355e-f638b0c7-02de-481c-9153-f79023bcaa7d-000000@email.amazonses.com>
In-Reply-To: <0100016aff4d355e-f638b0c7-02de-481c-9153-f79023bcaa7d-000000@email.amazonses.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.203.246.126]
Content-Type: multipart/related; boundary="_004_91E3A1BD737FDF4FA14118387FF6766B2774E2B7lhreml504mbs_"; type="multipart/alternative"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/PrzVblm3dt8Z-BcDOhip1bZZaZ4>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2019 13:02:22 -0000

It looks very good to me

Thanks, Italo

Italo Busi
Principal Optical Transport Network Research Engineer
Huawei Technologies Co., Ltd.
Tel : +39 345 4721946
Email : italo.busi@huawei.com
[cid:image001.png@01D5162F.7797D1D0]

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

From: Kent Watsen [mailto:kent@watsen.net]
Sent: martedì 28 maggio 2019 18:37
To: Italo Busi <Italo.Busi@huawei.com>
Cc: Lou Berger <lberger@labn.net>; netmod@ietf.org; netmod-chairs@ietf.org
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02

Hi Italo,

Thank you for the text suggestion, I landed on the following text:

   For readability purposes, this script forces the minimally supported
   line length to be eight characters longer than the raw header text
   defined in Section 7.1.1 and Section 8.1.1 so as to ensure that the
   header can be wrapped by a space (' ') character and three equal
   ('=') characters on each side of the raw header text.

Kent // author





On May 28, 2019, at 9:33 AM, Italo Busi <Italo.Busi@huawei.com<mailto:Italo.Busi@huawei.com>> wrote:

Hi Kent,

Thanks for your reply

For what I am concerned, the clarification you have provided is sufficient to me (no need to change the code)

You might also consider adding similar text at the beginning of Appendix A, if you think this helps. Something along the line:

The script forces the desired maximum line length to be a bit longer than the raw header text defined in sections 7 and 8, to further ensure that the header will always have some '=' characters wrapping around the header, for readability, in the unlikely scenario that such a narrow-width is needed.

Italo

Italo Busi
Principal Optical Transport Network Research Engineer
Huawei Technologies Co., Ltd.
Tel : +39 345 4721946
Email : italo.busi@huawei.com<mailto:italo.busi@huawei.com>
<image003.png>

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

From: Kent Watsen [mailto:kent@watsen.net]
Sent: lunedì 27 maggio 2019 19:57
To: Italo Busi <Italo.Busi@huawei.com<mailto:Italo.Busi@huawei.com>>
Cc: Lou Berger <lberger@labn.net<mailto:lberger@labn.net>>; netmod@ietf.org<mailto:netmod@ietf.org>; netmod-chairs@ietf.org<mailto:netmod-chairs@ietf.org>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02


Hi Italo,




1) Section 7.2.1 (Folding for Single Backslash Strategy) says:

  Ensure that the desired maximum line length is not less than the
  minimum header, which is 46 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

However, the first line defined in section 7.1.1 is a "45-character string".
I think that the paragraph be changed as:

  Ensure that the desired maximum line length is not less than the
  minimum header, which is 45 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

Fixed in my local copy.




2) Section 8.2.1 (Folding for Double Backslash Strategy) says:


  Ensure that the desired maximum line length is not less than the
  minimum header, which is 45 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

However, the first line defined in section 8.1.1 is a "46-character string".
I think that the paragraph be changed as:

  Ensure that the desired maximum line length is not less than the
  minimum header, which is 46 characters.  If the desired maximum line
  length is less than this minimum, exit (this text-based content
  cannot be folded).

Fixed in my local copy.




A question for clarification. Reading the following code in Appendix A:

    if [[ $strategy -eq 2 ]]; then
      min_supported=`expr ${#hdr_txt_2} + 8`
    else
      min_supported=`expr ${#hdr_txt_1} + 8`
    fi

It seems to me that the minimum lengths applied by the code in Appendix A are be 53 and 54 (instead of 45 and 46 respectively)

Is my understanding correct?

The script is not conflicting with the draft, as it does ensure that the length is not less than the raw header text.  Though, to your point, it adds an additional buffer to further ensure that the header will always have some '=' characters wrapping around the header, for readability, in the unlikely scenario that such a narrow-width is needed.   I could go either way on this, does anyone else have an opinion?





Thanks, Italo

Kent // author