Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02

Italo Busi <Italo.Busi@huawei.com> Fri, 24 May 2019 11:43 UTC

Return-Path: <Italo.Busi@huawei.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9717C12011E; Fri, 24 May 2019 04:43:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ogpAjLzEu1cj; Fri, 24 May 2019 04:43:35 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05A681202BC; Fri, 24 May 2019 04:43:35 -0700 (PDT)
Received: from lhreml705-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id E523B1D067F5BC0CAB9B; Fri, 24 May 2019 12:43:32 +0100 (IST)
Received: from LHREML504-MBS.china.huawei.com ([10.201.109.59]) by lhreml705-cah.china.huawei.com ([10.201.108.46]) with mapi id 14.03.0415.000; Fri, 24 May 2019 12:43:30 +0100
From: Italo Busi <Italo.Busi@huawei.com>
To: Lou Berger <lberger@labn.net>, NetMod WG <netmod@ietf.org>
CC: NetMod WG Chairs <netmod-chairs@ietf.org>
Thread-Topic: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02
Thread-Index: AQHVCSaY+iCIbhU/PESy/n6QJGx4eqZ6EnSg
Date: Fri, 24 May 2019 11:43:30 +0000
Message-ID: <91E3A1BD737FDF4FA14118387FF6766B2774C768@lhreml504-mbs>
References: <e6fc4541-891a-60cb-e956-86f238d09f14@labn.net>
In-Reply-To: <e6fc4541-891a-60cb-e956-86f238d09f14@labn.net>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.203.246.126]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/QNG_hyAD4QIG3nXWUTdO3ycHYW8>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 May 2019 11:43:37 -0000

Hi all,

I have reviewed the document and I support its publication as an RFC

I have just few (related) minor comments which can be easily fixed during WG LC process

1) Section 7.2.1 (Folding for Single Backslash Strategy) says:

   Ensure that the desired maximum line length is not less than the
   minimum header, which is 46 characters.  If the desired maximum line
   length is less than this minimum, exit (this text-based content
   cannot be folded).

However, the first line defined in section 7.1.1 is a "45-character string".
I think that the paragraph be changed as:

   Ensure that the desired maximum line length is not less than the
   minimum header, which is 45 characters.  If the desired maximum line
   length is less than this minimum, exit (this text-based content
   cannot be folded).

2) Section 8.2.1 (Folding for Double Backslash Strategy) says:


   Ensure that the desired maximum line length is not less than the
   minimum header, which is 45 characters.  If the desired maximum line
   length is less than this minimum, exit (this text-based content
   cannot be folded).

However, the first line defined in section 8.1.1 is a "46-character string".
I think that the paragraph be changed as:

   Ensure that the desired maximum line length is not less than the
   minimum header, which is 46 characters.  If the desired maximum line
   length is less than this minimum, exit (this text-based content
   cannot be folded).

A question for clarification. Reading the following code in Appendix A:

     if [[ $strategy -eq 2 ]]; then
       min_supported=`expr ${#hdr_txt_2} + 8`
     else
       min_supported=`expr ${#hdr_txt_1} + 8`
     fi

It seems to me that the minimum lengths applied by the code in Appendix A are be 53 and 54 (instead of 45 and 46 respectively)

Is my understanding correct?

Thanks, Italo

-----Original Message-----
From: Lou Berger [mailto:lberger@labn.net] 
Sent: domenica 12 maggio 2019 23:20
To: NetMod WG <netmod@ietf.org>;
Cc: NetMod WG Chairs <netmod-chairs@ietf.org>;
Subject: [netmod] WG Last Call: draft-ietf-netmod-artwork-folding-02


All,

This starts a two-week working group last call for
draft-ietf-netmod-artwork-folding-02

The working group last call ends on May 27.
Please send your comments to the working group mailing list.

Positive comments, e.g., "I've reviewed this document and believe it is ready for publication", are welcome!
This is useful and important, even from authors.

Thank you,
NetMod Chairs