[netmod] Adam Roach's No Objection on draft-ietf-netmod-entity-07: (with COMMENT)

[Adam Roach <[e-mail]>]

Adam Roach has entered the following ballot position for
draft-ietf-netmod-entity-07: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-netmod-entity/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

I have one correction and one question about the ietf-hardware YANG module.

         enum exa {
           value 14;
           description
             "Data scaling factor of 10^15.";
         }
         enum peta {
           value 15;
           description
             "Data scaling factor of 10^18.";
         }

I believe this is backwards -- "peta" should be 10^15, while "exa" should be 10^18.

----

     typedef sensor-value-precision {
       type int32 {
         range "-8 .. 9";
       }

Why is this an int32 rather than an int8?