Re: [netmod] Genart last call review of draft-ietf-netmod-module-tags-06

Christian Hopps <chopps@chopps.org> Wed, 06 March 2019 22:50 UTC

Return-Path: <chopps@chopps.org>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1B295130DC4; Wed, 6 Mar 2019 14:50:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SVnis6Mghsjj; Wed, 6 Mar 2019 14:50:05 -0800 (PST)
Received: from smtp.chopps.org (smtp.chopps.org [54.88.81.56]) by ietfa.amsl.com (Postfix) with ESMTP id D9133130F70; Wed, 6 Mar 2019 14:50:04 -0800 (PST)
Received: from stubbs.int.chopps.org (047-050-069-038.biz.spectrum.com [47.50.69.38]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by smtp.chopps.org (Postfix) with ESMTPSA id 0117960505; Wed, 6 Mar 2019 17:50:01 -0500 (EST)
From: Christian Hopps <chopps@chopps.org>
Message-Id: <0BE3CBAC-40EF-4162-82D0-04C638A3B429@chopps.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_236D6ECA-762F-4BD0-8840-F0E4856A9C15"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Date: Wed, 6 Mar 2019 17:50:00 -0500
In-Reply-To: <155183201188.27630.13798246400958114485@ietfa.amsl.com>
Cc: Christian Hopps <chopps@chopps.org>, gen-art@ietf.org, draft-ietf-netmod-module-tags.all@ietf.org, ietf@ietf.org, netmod@ietf.org
To: Datatracker on behalf of Elwyn Davies <ietf-secretariat-reply@ietf.org>
References: <155183201188.27630.13798246400958114485@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3445.102.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/STT2q76E-ZJHvoz4mi8QK0Q4RMY>
Subject: Re: [netmod] Genart last call review of draft-ietf-netmod-module-tags-06
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 22:50:08 -0000

Thanks for the review! Comments inline.

> On Mar 5, 2019, at 7:26 PM, Datatracker on behalf of Elwyn Davies <ietf-secretariat-reply@ietf.org>; wrote:
> 
> Reviewer: Elwyn Davies
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
> 
> Document: draft-ietf-netmod-module-tags-06
> Reviewer: Elwyn Davies
> Review Date: 2019-03-05
> IETF LC End Date: 2019-03-03
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> Almost ready.  There are a couple of minor issues and a small number of nits.
> Apologies for the slightly late delivery of the review.
> 
> Major issues:
> None
> 
> Minor issues:
> Abstract/s1: I would judge that RFC 8407 ought to be normative since it is
> updated.

RFC8407 is a BCP not a Standard though so I don't think it's appropriate to make it normative.

> S4.2: using the Netmod working group as contact point for the module is not
> future proof.  I am  not sure what the correct contact ought to be: IESG?

Speaking of 8407 guidelines... It gives guidance here. I will follow it. :)

  "The "contact" statement MUST be present.  If the module is contained
   in a document intended for Standards Track status, then the WG web
   and mailing information SHOULD be present, and the main document
   author or editor contact information SHOULD be present."

> S7.2: [This is a thought that occurred to me...] ought there to be an ietf:
> security tag?

Yes, added.

> S9: I would consider RFCs 8199, 8340, 8342 and 8407 to be normative

8199: Informational
8340: BCP
8407: BCP

8342: Standard, and I think your right, moved to Normative.

> 
> Nits/editorial comments:
> Abstract: s/modules/module's/
> 
> Abstract:
> OLD:
> This document also provides guidance to future model writers, as such, this
> document updates RFC8407.
> 
> NEW:
> This document also provides guidance to future model writers; as such, this
> document updates RFC8407.
> 
> ENDS
> 
> S1.1, title: s/use cases of/use cases for/
> 
> S1.1, para 1: s/documents progression/document's development/
> 
> S1.1, paras 2, 3 and 5: Suggest s/E.g./For example/
> 
> S1.1, para 4: s/e.g./e.g.,/

Updated with your suggestions.

> S2, para 1:
>    > All tags SHOULD begin with a prefix indicating who owns their definition.
> 
> If I read correctly, the YANG definition in s4.2 REQUIRES that all tags have a
> prefix.  For clarity, it would better if this read:
>    All tags MUST begin with a prefix; it is intended that this prefix SHOULD
>   [or maybe 'should'] indicate
>  the ownership or origination of the definition.

The intent was to not put the MUST on users. As the final arbiters of tags, users should be free to do whatever they want and not have implementations or standards superfluously block them from doing so. How about we carry the SHOULD into the typedef in the YANG model as well? That seems reasonable to me, i.e.,

  typedef tag {
    type string {
      length "1..max";
      pattern '[a-zA-Z_][a-zA-Z0-9\-_]*:[\S ]+';
    }
    description
      "A tag is a type 'string' value that does not include carriage
       return, newline or tab characters. It SHOULD begin with a
       standard prefix.";

> S2, para 1: s/yang type/YANG type/ (I think)
> 
> S2.2: s/follwing/following/
> 
> S3.1, para 2:
> OLD:
> If the module definition is IETF standards track, the tags MUST also be Section
> 2.1. Thus, new modules can drive the addition of new standard tags to the IANA
> registry, and the IANA registry can serve as a check against duplication.
> 
> NEW:
> If the module is defined in an IETF standards track document, the tags MUST use
> the prefix defined in Section 2.1. Thus, definitions of new modules can drive
> the addition of new standard tags to the IANA registry defined in Section 7.2,
> and the IANA registry can serve as a check against duplication.
> 
> ENDS
> 
> S3.2: s/standard/IETF Standard/
> 
> S3.3: It would be useful to introduce the term 'masking' used later in the YANG
> module definition.

How about:

"Tags of any kind can be assigned and removed by the user using normal
configuration mechanisms. In order to remove a tag from the
operational datastore the user adds a matching =masked-tag= entry for
a given module."

> S4.1: I think this usage of RFC 8340 makes it normative.

Covered earlier (BCP).

> S4.2, extension module-tag definition: This should contain a pointer to RFC
> 8342 which discusses the system origin concept.

Added.

Thanks,
Chris.

> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod