Re: [netmod] [Gen-art] Genart last call review of draft-ietf-netmod-factory-default-14

Alissa Cooper <alissa@cooperw.in> Wed, 22 April 2020 19:41 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D55F3A046E; Wed, 22 Apr 2020 12:41:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=Z0Wy7b6y; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=W38qXEXo
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jm2Np8kt31mr; Wed, 22 Apr 2020 12:41:27 -0700 (PDT)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 527753A052C; Wed, 22 Apr 2020 12:41:24 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 677D35C0272; Wed, 22 Apr 2020 15:41:23 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 22 Apr 2020 15:41:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm2; bh=6 JIcra0Tkufowb+KahRidJFS75aL9UHKQiZkd+6l8k0=; b=Z0Wy7b6yLCqzFYbgZ uZHn5+5xdEhchelHZsGe0fHi8h5wf90/ESEOMLEKRDRqH7/5ZvCLfHNCBhjGu4lU P/D588B6brHt12sniU8WLjhAYb4eAuBcLCHn11OuQXmtxnOsLEMy/AHwUrlyWeOL tcx2xG80vPsoJrvtyKOENL0t3sDr3dRuMGzqnmMOxpCy4IWDWlJTLXu0anmp0Jpe s5++AHyO3QHSRjfotADP+4wkxtDSqUd2jLOD44G72uxi7jGhLuK++DnE1O6zbS/H aNZbexE2jTjZllfT7R0Y1adsRz+3Nc/eeuj9RHexhy3n9sZnjtP9sbI3w4gf6BNk zXarg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=6JIcra0Tkufowb+KahRidJFS75aL9UHKQiZkd+6l8 k0=; b=W38qXEXoQ733kFcyS1byeljLrm5hRv9dSGPliPc5JzwJiRkMSpVqJCS0W l96axHkrQRFesCyJKV525E7WjaWv624x3O0QnZPugtM31ErtPg/8iuK4Ryj192gJ cJNTFmNqnJyT1/tNPni+d1BQdCHmTMUjstqTFccOMRyyCYmDZ6KB52CQU952Q9g4 ekbYvoCS7em9UN2Ibc++YNFQ+p+04aFIqD04SMhBRClEW5HSE5dsgu26/U4+ALY0 pQ9IOHwgGtaYlhDFtrtMXtnMSjGy925erECqln3zlW1eBeAnZHHnnbIjpxb5snyC 3BFYgVThQSLIG9cVbf+vev1Aizlfw==
X-ME-Sender: <xms:452gXvU4onY0r2_HlIjKowR9ktM1_7Bm3cQFiUQ6PHnlByh_3Yhh4Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeejgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtjeenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrg hinhepihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrjeeknecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlihhsshgrsegtoh hophgvrhifrdhinh
X-ME-Proxy: <xmx:452gXoW88DR7whKmZnFXUYeavKQyrqFOX_hIxywr0oekCWZsxGnC7A> <xmx:452gXvMBcYi-6tsZ87IrzF1Xpps9qGOdvhYV2VSGOVNaNrVSHNIoIg> <xmx:452gXr7U-39UCq25-1oika4lDa0SXxtMzu9vIT0HKXgKnhs_1Oh2RA> <xmx:452gXvPWhCBAaIln-0IxiEwW0yNFxczu0c_gogoBu_K5Oyy01yFHrg>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.78]) by mail.messagingengine.com (Postfix) with ESMTPA id B3BE83065CDE; Wed, 22 Apr 2020 15:41:22 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABAAD54B417@dggeml511-mbs.china.huawei.com>
Date: Wed, 22 Apr 2020 15:41:21 -0400
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-netmod-factory-default.all@ietf.org" <draft-ietf-netmod-factory-default.all@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <82630369-489D-4E1E-8897-C17CBC6F4B70@cooperw.in>
References: <B8F9A780D330094D99AF023C5877DABAAD54B417@dggeml511-mbs.china.huawei.com>
To: Qin Wu <bill.wu@huawei.com>, Stewart Bryant <stewart.bryant@gmail.com>
X-Mailer: Apple Mail (2.3445.9.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/SUXV671V5tlKeZEKm2qQKdSnCXs>
Subject: Re: [netmod] [Gen-art] Genart last call review of draft-ietf-netmod-factory-default-14
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2020 19:41:31 -0000

Stewart, thanks for your review. Qin, thanks for your response. I entered a No Objection ballot.

Alissa


> On Mar 13, 2020, at 8:26 AM, Qin Wu <bill.wu@huawei.com> wrote:
> 
> Thanks Stewart for a good review, see reply inline below.
> 
> -----邮件原件-----
> 发件人: Stewart Bryant via Datatracker [mailto:noreply@ietf.org] 
> 发送时间: 2020年3月12日 21:12
> 收件人: gen-art@ietf.org
> 抄送: netmod@ietf.org; last-call@ietf.org; draft-ietf-netmod-factory-default.all@ietf.org
> 主题: Genart last call review of draft-ietf-netmod-factory-default-14
> 
> Reviewer: Stewart Bryant
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-netmod-factory-default-14
> Reviewer: Stewart Bryant
> Review Date: 2020-03-12
> IETF LC End Date: 2020-03-16
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: A well written document that is pretty much ready to go. I only have one concern and that is whether the overwrite pattern needs some text so that it does not accidentally become a covert channel.
> 
> Major issues: None
> 
> Minor issues:
> 
> "All security sensitive data (i.e., private keys, passwords, etc.)  SHOULD be  overwritten with zeros or a pattern before deletion.  "
> 
> "a pattern" is possibly vague, and care needs to be taken that this is not a covert channel. Possibly it needs to say something like "an implementation specific common pattern"?
> 
> [Qin]: The proposed change works for me, maybe "common" should also be removed.
> Nits/editorial comments:
> 
> Nits contains a warning about references, but one concerns text that will removed, and the other is a format error that will be fixed in publication
> [Qin]:Correct, YANG library reference is unused and should be removed. 
> I saw the SecDir comment on RPC. This is a starred term in the abbreviation list and does not technically need expanding.
> [Qin]: Right, RPC is an existing term that is defined in RFC7950, which doesn't need to be expanded.
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art