Re: [netmod] WG Last Call: draft-ietf-netmod-sub-intf-vlan-model-05
Martin Bjorklund <mbj@tail-f.com> Thu, 22 August 2019 20:14 UTC
Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB6D4120889 for <netmod@ietfa.amsl.com>; Thu, 22 Aug 2019 13:14:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id slYPGzfC3NYL for <netmod@ietfa.amsl.com>; Thu, 22 Aug 2019 13:14:58 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 2FB8812011B for <netmod@ietf.org>; Thu, 22 Aug 2019 13:14:58 -0700 (PDT)
Received: from localhost (h-46-233.A165.priv.bahnhof.se [46.59.46.233]) by mail.tail-f.com (Postfix) with ESMTPSA id 98F4E1AE0981 for <netmod@ietf.org>; Thu, 22 Aug 2019 22:14:53 +0200 (CEST)
Date: Thu, 22 Aug 2019 22:14:53 +0200
Message-Id: <20190822.221453.1052536475937856222.mbj@tail-f.com>
To: netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <0100016bd93be4a2-a22ba545-c022-44d6-9188-1b51ff1effe0-000000@email.amazonses.com>
References: <0100016bd93be4a2-a22ba545-c022-44d6-9188-1b51ff1effe0-000000@email.amazonses.com>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/TIl-enDCk7jquEw15XH5rFWwzTY>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-sub-intf-vlan-model-05
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Aug 2019 20:15:00 -0000
Hi, Here is my (late) review of draft-ietf-netmod-sub-intf-vlan-model-05. o 1 The YANG module names are not correct; they are listed as: if-l3-vlan.yang - Defines the model for basic classification of VLAN tagged traffic to L3 transport services flexible-encapsulation.yang - Defines the model for flexible classification of Ethernet/VLAN traffic to L2 transport services Should be "ietf-if-l3-vlan" and "ietf-flexible-encapsulation". Or "ietf-if-l3-vlan" and "ietf-if-flexible-encapsulation". But I also wonder if these names should somehow be changed. What is a "l3-vlan"? And "flexible-encapsulation" sound a bit too generic. o 1.1 The text says: Sub-interface: A sub-interface is a small augmentation of a regular interface in the standard YANG module for Interface Management that represents a subset of the traffic handled by its parent interface. I think the augmentation is the YANG-realization of a sub-interface, but it is not what a sub-interface is. Also, this definition is mis-leading; it doesn't mention that a sub-interface has its own interface type and is represented as one separate entry in the interface list. I think it is better to import this term from draft-ietf-netmod-intf-ext-yang (section 3.6) o 3 The text says: The L3 Interface VLAN model provides appropriate leaves for termination of an 802.1Q VLAN tagged segment to a sub-interface based L3 service. There is a comment in the YANG model that says the same thing. But the YANG model itself augments not only to sub-interface-based interface, but also to ethernet-like interfaces. o YANG modules Both modules lack the IETF Trust Copyright statement. We don't list WG Chairs anymore. The revision statements should be on the form: "RFC XXXX: <title>" Many descriptions are full sentences w/o the ending ".". The modules should be indented properly; a starting point can be pyang -f yang --yang-line-length 69 o ietf-if-l3-vlan There is a comment: /* * Matches a single VLAN Id, or a pair of VLAN Ids to classify * traffic into an L3 service. */ This should be moved into a description clause. o ietf-if-l3-vlan / container dot1q-vlan The must statement has: count(../../if-cmn:forwarding-mode) = 0 This can be changed to not(../../if-cmn:forwarding-mode) which is more direct imo. The must statement's description statement seems to be a copy-and-paste error. o ietf-if-l3-vlan / container dot1q-vlan The descriptions talk about "matching frames" and "classifying traffic", but it is not described anywhere how the matching and classifying is used. (also applies to ietf-flexible-encapsulation) o ietf-if-l3-vlan / outer-tag / second-tag These names are a bit inconsistent. The description describes them as "outermost tag" and "second outermost tag". Perhaps use these names instead? (same names are found in ietf-flexible-encapsulation) o ietf-flexible-encapsulation / all features The features are described as: "This feature indicates whether the network element supports specifying flexible rewrite operations"; Should this be s/whether/that ? o ietf-flexible-encapsulation There is some descriptive text in comments that should be moved to description statements. o ietf-flexible-encapsulation The descriptions for pop/push are a bit terse. It seems to assume that readers already know what this (from somewhere) is so it doesn't need to be described. If this is intended, perhaps add a reference to where this is described. /martin
- [netmod] WG Last Call: draft-ietf-netmod-sub-intf… Kent Watsen
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Acee Lindem (acee)
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Jeff Tantsura
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Qin Wu
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Martin Bjorklund
- [netmod] Fw: WG Last Call: draft-ietf-netmod-sub-… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Qin Wu
- Re: [netmod] WG Last Call: draft-ietf-netmod-sub-… Rob Wilton (rwilton)