[netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04
Andy Bierman <andy@yumaworks.com> Thu, 06 April 2017 17:43 UTC
Return-Path: <andy@yumaworks.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D1CB12422F for <netmod@ietfa.amsl.com>; Thu, 6 Apr 2017 10:43:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JucVHMkpKlgv for <netmod@ietfa.amsl.com>; Thu, 6 Apr 2017 10:43:25 -0700 (PDT)
Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7EFA7128DE5 for <netmod@ietf.org>; Thu, 6 Apr 2017 10:43:25 -0700 (PDT)
Received: by mail-wr0-x230.google.com with SMTP id c55so125952wrc.3 for <netmod@ietf.org>; Thu, 06 Apr 2017 10:43:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=rkvm5cbUEvF10a6yOvcA/F9McN7WA45NjoH9N/WSAf0=; b=PRUtS1nul1VILBg/RdPl9jPgllHgXgeNMFmMRRMzD3+68Fll4OtoCdMMwr1x5RNgY5 pKT/y9gSROWbR+UIFU+Alr4Z35MPINf3QRPyenkVaMwgtXwu80ZOiRIOoWCq7NzzkWKR 60dkHxJSRixphqyNdiwQIeKAK4cDmSIYyRSgeAt8HHFeXXKdwtW8bvtsLiz2eJJXX9aP j0AHpjoebGDNdJhCgZ3wPPvOY9Ws1YvYpK/8krj6hwsg1i0cd6eLJF+O8pZ86HOJAzpy G3b2HBgPZMKdVtUGL1oAqAX6jerTbsVezYFnRm+NE1dA+OArgFxGnbS83aYRRD/lHy9H nAFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rkvm5cbUEvF10a6yOvcA/F9McN7WA45NjoH9N/WSAf0=; b=jvIwpu+Zlmo0ZtywRsUWHo51+Q/cjfXLkzO9Qd12Du1Oa9fkD8a/kBfOSYGqp5KJTT fOFaeCJttX2JED3dxVLroluL0apUbPbMgYtT3fA9ER+7brfRC0kMy9Ejq2be1dsPgWv5 cdjBbWLpyH6PtyJafujeqNqg+FeQONvxEL7pnvfXWfzjMuEqdQhCdlLtzjwwykqLkL17 QoQcMZx108Xw+NEQ/nUPSqk7mzqUoIXOGlUDrGllWvfnPhokaXXOgx23s5hx9eiN0yL6 XakmoLsm0UkWcQwtbBLGSTieg0l0k1iR8Snfi3jmx5daGTvGNNPsbEAQvoYeQMK2D06o qRLg==
X-Gm-Message-State: AFeK/H0MPvY2BSia7dz+zDYNYiCY+sLc0/r89lig0ZeqDhyHzbPGLnuoz/vvVVENTCj+Kemi2FCLmKn0i15tIw==
X-Received: by 10.223.161.70 with SMTP id r6mr30043400wrr.65.1491500603978; Thu, 06 Apr 2017 10:43:23 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.139.21 with HTTP; Thu, 6 Apr 2017 10:43:23 -0700 (PDT)
From: Andy Bierman <andy@yumaworks.com>
Date: Thu, 06 Apr 2017 10:43:23 -0700
Message-ID: <CABCOCHTtihJuFauSW4KmaoCHJSFYgNCR200MWsLQ_7456HsO0w@mail.gmail.com>
To: "netmod@ietf.org" <netmod@ietf.org>, YANG Doctors <yang-doctors@ietf.org>
Content-Type: multipart/alternative; boundary="f403045e274aaece21054c830bd9"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/TYO2et0Q_t9FXuGia3JBKdjf-Ek>
Subject: [netmod] YANG doctor review of draft-ietf-netmod-intf-ext-yang-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Apr 2017 17:43:28 -0000
Overall: The document is well-written and almost ready for publication Comments: 1) No examples or guidance for "encaps-type" The document does not really define the standards value for this empty choice. There are no examples showing its use. More work is needed for this part of the module. The following TODO needs to be resolved and the note removed from the document: /* * TODO - Should we introduce an abstract type to make this * extensible to new interface types, or vendor * specific interface types? */ 2) normative overlap The text and layout of sec. 3 is good. The issue is that the YANG module text copies from this section in some places (leafs) and references it in others (feature definitions) Some parts like "half-life" are more detailed in the leaf definition than the plain text in sec. 3 Perhaps the leaf definitions can have reference-stmts added as needed, so it is clear that the YANG leaf is not the entire normative text. The YANG descriptions are good, but maybe not complete wrt/ sec. 3 additional text. sec 3.7 typo: the existing the sub-interface ^^^ remove extra 'the' 3) identity ethSubInterface This identity is used in the encapsulation container when-stmt. It is not clear if this is intended as a base identity (like identity sub-interface) An example for the encapsulation container would help clarify the expected usage This also has 2 bases (sub-interface and l2vlan). Some explanation in the identity-stmt would be helpful (since this is a new YANG 1.1 construct) Andy
- Re: [netmod] YANG doctor review of draft-ietf-net… Vladimir Vassilev
- Re: [netmod] YANG doctor review of draft-ietf-net… Robert Wilton
- Re: [netmod] YANG doctor review of draft-ietf-net… Martin Bjorklund
- Re: [netmod] YANG doctor review of draft-ietf-net… Ladislav Lhotka
- Re: [netmod] YANG doctor review of draft-ietf-net… Martin Bjorklund
- Re: [netmod] YANG doctor review of draft-ietf-net… Ladislav Lhotka
- [netmod] YANG doctor review of draft-ietf-netmod-… Andy Bierman
- Re: [netmod] YANG doctor review of draft-ietf-net… Robert Wilton