Re: [netmod] iana-if-type.yang has multiple revisions with the same date

[William Lupton <[e-mail]>]

I uploaded some more modules to the catalog yesterday and was looking into
why compilations are failing.

It turns out that [e-mail] (the 'fixed' version) is
broken. Running it through pyang gives this:

% pyang [e-mail]
[e-mail]:56: error: unterminated statement definition
for keyword "description", looking at C

The problem is a bit earlier, in the coalesced revision statement:

  revision 2022-03-07 {
    description
      "Coalesced revision history entries for 2018-06-28.”;
  }

That closing quote is a 'close curly double quote' (UTF-8 Encoding: 0xE2
0x80 0x9D). Fixing it to an ASCII double quote fixes the problem. Is there
no automatic validation of IANA modules?

% grep Coalesced [e-mail] | od -ax
0000000   sp  sp  sp  sp  sp  sp   "   C   o   a   l   e   s   c   e   d
             2020    2020    2020    4322    616f    656c    6373    6465
0000020   sp   r   e   v   i   s   i   o   n  sp   h   i   s   t   o   r
             7220    7665    7369    6f69    206e    6968    7473    726f
0000040    y  sp   e   n   t   r   i   e   s  sp   f   o   r  sp   2   0
             2079    6e65    7274    6569    2073    6f66    2072    3032
0000060    1   8   -   0   6   -   2   8   .   *?  80  9d*   ;  nl
             3831    302d    2d36    3832    *e2*2e    *9d80*    0a3b

0000076

On Tue, 8 Mar 2022 at 13:07, Rob Wilton (rwilton) <[e-mail]> wrote:

> Hi William,
>
>
>
> IANA have published a new revision with the revision history fixed.
>
>
>
> iana-if-type YANG Module
> <https://www.iana.org/assignments/iana-if-type/iana-if-type.xhtml>
>
>
>
> Regards,
>
> Rob
>
>
>
>
>
> *From:* netmod <[e-mail]> *On Behalf Of *Rob Wilton
> (rwilton)
> *Sent:* 04 March 2022 14:37
> *To:* William Lupton <[e-mail]>; Benoit Claise <
> [e-mail]>
> *Cc:* NetMod WG <[e-mail]>
> *Subject:* Re: [netmod] iana-if-type.yang has multiple revisions with the
> same date
>
>
>
> Hi William,
>
>
>
> I have asked Sabrina in IANA to please publish a new revision with the
> history fixed.
>
>
>
> Regards,
>
> Rob
>
>
>
>
>
> *From:* netmod <[e-mail]> *On Behalf Of *William Lupton
> *Sent:* 04 March 2022 10:15
> *To:* Benoit Claise <[e-mail]>
> *Cc:* NetMod WG <[e-mail]>
> *Subject:* Re: [netmod] iana-if-type.yang has multiple revisions with the
> same date
>
>
>
> +1 (not surprisingly). What action? And whose action?
>
>
>
> On Thu, 3 Mar 2022 at 19:24, Benoit Claise <[e-mail]>
> wrote:
>
> +1  to Jürgen point of view.
>
>
>
> Regards, Benoit
>
> *From:*Jürgen Schönwälder <[e-mail]>
>
> *To:*William Lupton <[e-mail]>
>
> *Cc:*NetMod WG <[e-mail]>
>
> *Date:*2022-03-03 20:01:06
>
> *Subject:*Re: [netmod] iana-if-type.yang has multiple revisions with the
> same date
>
>
>
> The obvious thing to do in this particular case (where there are only
> allocations of new values) is to collapse the revisions and to move
> on. Slightly better would be to ensure this does not happen again.
>
> /js
>
> On Thu, Mar 03, 2022 at 05:45:25PM +0000, William Lupton wrote:
> > > It is too late to do anything about this module.
> >
> > This module is republished every time a new ifType is added. Are you
> saying
> > that it would be unacceptable to collapse the duplicate revisions next
> time
> > it's updated? If so then we will live with this FOR EVER!
> >
> > >
>
> > _______________________________________________
> > netmod mailing list
> > [e-mail]
> > https://www.ietf.org/mailman/listinfo/netmod
>
>
> --
> Jürgen Schönwälder              Jacobs University Bremen gGmbH
> Phone: [phone]         Campus Ring 1 | 28759 Bremen | Germany
> Fax:   [phone]         <https://www.jacobs-university.de/>
>
> _______________________________________________
> netmod mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/netmod
>
>