Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7277bis-00

Vladimir Vassilev <vladimir@transpacket.com> Mon, 18 December 2017 10:46 UTC

Return-Path: <vladimir@transpacket.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2202127517 for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 02:46:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Deef_K2DjGBA for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 02:46:36 -0800 (PST)
Received: from mail.transpacket.com (s91205186171.blix.com [91.205.186.171]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93AFF126BFD for <netmod@ietf.org>; Mon, 18 Dec 2017 02:46:36 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.transpacket.com (Postfix) with ESMTP id F3E7615605E0; Mon, 18 Dec 2017 11:46:33 +0100 (CET)
Received: from mail.transpacket.com ([127.0.0.1]) by localhost (mail.transpacket.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Hao2hGFMEnBb; Mon, 18 Dec 2017 11:46:33 +0100 (CET)
Received: from localhost (localhost [127.0.0.1]) by mail.transpacket.com (Postfix) with ESMTP id CBB1A15605D4; Mon, 18 Dec 2017 11:46:33 +0100 (CET)
Received: from mail.transpacket.com ([127.0.0.1]) by localhost (mail.transpacket.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wZpNMie3BH_S; Mon, 18 Dec 2017 11:46:33 +0100 (CET)
Received: from [192.168.209.122] (s1853520235.blix.com [185.35.202.35]) by mail.transpacket.com (Postfix) with ESMTPSA id AB41915605CB; Mon, 18 Dec 2017 11:46:33 +0100 (CET)
To: Martin Bjorklund <mbj@tail-f.com>
Cc: netmod@ietf.org
References: <20171213.154734.273404682004037071.mbj@tail-f.com> <500e497e-9a80-8d00-22ca-6fe271fcd725@transpacket.com> <937fadab-b3f0-1246-8543-00cb4d6a5acd@transpacket.com> <20171216.104645.2140965470373068531.mbj@tail-f.com>
From: Vladimir Vassilev <vladimir@transpacket.com>
Message-ID: <b5b9198f-15ef-fd6c-bb5c-04c0ef49557c@transpacket.com>
Date: Mon, 18 Dec 2017 11:46:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171216.104645.2140965470373068531.mbj@tail-f.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: nb
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/Tarwhhp2vFoiZMlB-MVsnC4scN0>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7277bis-00
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Dec 2017 10:46:39 -0000

On 12/16/2017 10:46 AM, Martin Bjorklund wrote:

> Hi,
>
> Vladimir Vassilev <vladimir@transpacket.com>; wrote:
>> On 12/13/2017 04:26 PM, Vladimir Vassilev wrote:
>>> Hi,
>>>
>>> On 12/13/2017 03:47 PM, Martin Bjorklund wrote:
>>>
>>>> Hi,
>>>>
>>>> Thanks for reporting this.  I'll add the missing origin.  But why did
>>>> you think forwarding and mtu should be removed?
>>> 1. IMO since <mtu> is not present in the <ipv4> container in the
>>> Appendix A (<get-config>) example and does not have default value in
>>> the model I still think it should be removed.
>> Alternatively the ipv4/mtu node can be a good example of a
>> origin="or:system" configuration.
> Yes.
>
>>>>     In fact, I think I
>>>> missed <enabled>,
>>> 2. IMO both fixes adding <enabled> or removing <forwarding> should be
>>> OK depending on the RFC6243 defined with-defaults capability
>>> 'basic-mode' parameter advertised by the server. I was running the
>>> example with basic-mode=explicit
> Right.  I now have this:
>
>        <!-- other parameters from ietf-interfaces omitted -->
>
>        <ipv4 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip">
>          <enabled or:origin="or:default">true</enabled>
>          <forwarding or:origin="or:default">false</forwarding>
>          <mtu or:origin="or:system">1500</mtu>
>          <address>
>            <ip>192.0.2.1</ip>
>            <prefix-length>24</prefix-length>
>            <origin>static</origin>
>          </address>
>          <neighbor or:origin="or:learned">
>            <ip>192.0.2.2</ip>
>            <link-layer-address>00:01:02:03:04:05</link-layer-address>
>          </neighbor>
>        </ipv4>
>        <ipv6 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip">
>          <enabled or:origin="or:default">true</enabled>
>          <forwarding or:origin="or:default">false</forwarding>
>          <mtu>1280</mtu>
>          ...
>
> Do you think this is ok?
Yes. The or:default data makes the example even better.

1. However there is one more default value missing 
(/interfaces/interface[name='eth0']/enabled) for the example to be 
consistent
2. ... and in the last diff I unintentionally omitted the get-data 
output node <data> required namespace addition (this is also applicable 
to draft-ietf-netmod-7223bis-01):

diff -u before2.xml after2.xml
--- before2.xml    2017-12-18 11:41:54.029279321 +0100
+++ after2.xml    2017-12-18 11:36:25.973850340 +0100
@@ -1,4 +1,4 @@
-     <data>
+     <data xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-datastores">
         <interfaces
             xmlns="urn:ietf:params:xml:ns:yang:ietf-interfaces"
             xmlns:ianaift="urn:ietf:params:xml:ns:yang:iana-if-type"
@@ -7,6 +7,7 @@
           <interface or:origin="or:intended">
             <name>eth0</name>
             <type>ianaift:ethernetCsmacd</type>
+           <enabled or:origin="or:default">true</enabled>
             <!-- other parameters from ietf-interfaces omitted -->
             <ipv4 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip">
               <enabled or:origin="or:default">true</enabled>


Vladimir
>
>
> /martin