Re: [netmod] tree diagrams for augment

"Eric Voit (evoit)" <evoit@cisco.com> Wed, 31 May 2017 12:58 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9F3171289B0 for <netmod@ietfa.amsl.com>; Wed, 31 May 2017 05:58:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.512
X-Spam-Level:
X-Spam-Status: No, score=-14.512 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xkDdpVGBzISn for <netmod@ietfa.amsl.com>; Wed, 31 May 2017 05:58:46 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8CCFE127275 for <netmod@ietf.org>; Wed, 31 May 2017 05:58:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=19573; q=dns/txt; s=iport; t=1496235526; x=1497445126; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=pRINKD5iiDhT1upk9uEIcu+uZJdiqisdSEHwfhisglo=; b=K2OF2yfdXs3r41f9WaHxxfY2n2wcz2NXDolflE35omSRyOztiEDW4+PY sXET3D1uJwXLIKgdoH1lVS4kcHhMuHuDl5VqGMhB8l+Fk/zu1GksN3Pmw BFgawjxQh5K6jxgDS4OLWeYSjSMJbSFUDe83oT7QmevyzQWIJkFPvDEjE A=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CYAAAPvS5Z/5RdJa1dGQEBAQEBAQEBAQEBBwEBAQEBgm5nYoENB44DkW+VeYIPIQEKgh0BgxBKAoJiPxgBAgEBAQEBAQFrKIUYAQEBAQIBAQErQQsFCwIBCA4HEBoHJwsUEQIEAQ0FCIk+XAgQrh6LUQEBAQEBAQEBAQEBAQEBAQEBAQEBARgFhmGESzSERoYVBZ4jAZMegg+PcYkBi0wBHziBCnQVRocCdocXgS+BDQEBAQ
X-IronPort-AV: E=Sophos;i="5.38,423,1491264000"; d="scan'208,217";a="249715307"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2017 12:58:45 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id v4VCwj9F005803 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 31 May 2017 12:58:45 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 31 May 2017 08:58:44 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1210.000; Wed, 31 May 2017 08:58:44 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: Martin Bjorklund <mbj@tail-f.com>, "andy@yumaworks.com" <andy@yumaworks.com>
CC: "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] tree diagrams for augment
Thread-Index: AQHS02/Yyompy3DFqUe0c+tavueYVKIBxcqAgAyr0sA=
Date: Wed, 31 May 2017 12:58:44 +0000
Message-ID: <c9338ef719044abd99dd891fb2e37614@XCH-RTP-013.cisco.com>
References: <CABCOCHTLkkCY75Q7TneRYqZu351SeCUdboPD+u2ow4hE2_C3hA@mail.gmail.com> <20170523.091841.639172441748909073.mbj@tail-f.com>
In-Reply-To: <20170523.091841.639172441748909073.mbj@tail-f.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.228]
Content-Type: multipart/alternative; boundary="_000_c9338ef719044abd99dd891fb2e37614XCHRTP013ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/TszDVtuJ89T9uOqRqMfpK1lbMHQ>
Subject: Re: [netmod] tree diagrams for augment
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 May 2017 12:58:49 -0000

> From: Martin Bjorklund, May 23, 2017 3:19 AM

> Andy Bierman <andy@yumaworks.com<mailto:andy@yumaworks.com>> wrote:

> > Hi,

> >

> > Below is part of 1 tree diagram from yang-push-06.

> > The problem is that is shows the entire RPC, and gives no indication

> > at all that this module only defines augmentations, or which nodes in

> > the tree diagram will be found here.

>

> I see what you mean, although it does give some (implicit) indication with the

> prefixes (yp:).  But it is certainly not obvious.

>

> Ideas for a better representation of augments are most welcome.



I don't claim I have a better representation, but below is what I manually included in yang-push-04 to represent the items which Andy requests.  Perhaps this can be used in helping formulate a better approach.



i]   indicates that the node in that line has been brought in / imported from another model, and

(a) indicates a specific imported node which has been augmented.



i]     +---x establish-subscription

(a)    |  +---w input

i]     |  |  +---w stream?

i]     |  |  +---w encoding?

(a)    |  |  +---w (filter-type)?

i]     |  |  |  +--:(rfc5277)

i]     |  |  |  |  +---w filter?

       |  |  |  +--:(update-filter)

       |  |  |  |  +---w (update-filter)?

       |  |  |  |     +--:(subtree)

       |  |  |  |     |  +---w subtree-filter?

       |  |  |  |     +--:(xpath)

       |  |  |  |        +---w xpath-filter?

i]     |  |  |  +--:(by-reference)

i]     |  |  |     +---w filter-ref?

i]     |  |  +---w startTime?

i]     |  |  +---w stopTime?

       |  |  +---w (update-trigger)?

       |  |  |  +--:(periodic)

       |  |  |  |  +---w period



Eric





> One simple

> thing we could do would be to use prefixes on all augmented nodes, and never

> on the nodes from the "main" module.

>

>

> /martin

>

>

> >

> >

> > Andy

> >

> >

> >  rpcs:

> >     +---x establish-subscription

> >     |  +---w input

> >     |  |  +---w encoding?               encoding

> >     |  |  +---w (target)

> >     |  |  |  +--:(event-stream)

> >     |  |  |  |  +---w stream                  stream

> >

> >     |  |  |  |  +---w replay-start-time?   yang:date-and-time {replay}?

> >     |  |  |  +--:(yp:datastore)

> >     |  |  |     +---w yp:datastore            datastore

> >     |  |  +---w (applied-filter)

> >     |  |  |  +--:(by-reference)

> >     |  |  |  |  +---w filter-ref              filter-ref

> >     |  |  |  +--:(locally-configured)

> >     |  |  |     +---w filter-type             filter-type

> >     |  |  |     +---w filter

> >     |  |  +---w stop-time?              yang:date-and-time

> >     |  |  +---w (yp:update-trigger)?

> >     |  |  |  +--:(yp:periodic)

> >     |  |  |  |  +---w yp:period               yang:timeticks

> >     |  |  |  |  +---w yp:anchor-time?         yang:date-and-time

> >     |  |  |  +--:(yp:on-change) {on-change}?

> >     |  |  |     +---w yp:dampening-period     yang:timeticks

> >     |  |  |     +---w yp:no-synch-on-start?   empty

> >     |  |  |     +---w yp:excluded-change*     change-type

> >     |  |  +---w yp:dscp?                inet:dscp

> >     |  |  +---w yp:weighting?           uint8

> >     |  |  +---w yp:dependency?          sn:subscription-id

> >     |  +--ro output

> >     |     +--ro subscription-result         subscription-result

> >     |     +--ro (result)?

> >     |        +--:(no-success)

> >     |        |  +--ro filter-failure?             string

> >     |        |  +--ro replay-start-time-hint?     yang:date-and-time

> >     |        |  +--ro yp:period-hint?             yang:timeticks

> >     |        |  +--ro yp:error-path?              string

> >     |        |  +--ro yp:object-count-estimate?   uint32

> >     |        |  +--ro yp:object-count-limit?      uint32

> >     |        |  +--ro yp:kilobytes-estimate?      uint32

> >     |        |  +--ro yp:kilobytes-limit?         uint32

> >     |        +--:(success)

> >     |           +--ro identifier                  subscription-id

>

> _______________________________________________

> netmod mailing list

> netmod@ietf.org<mailto:netmod@ietf.org>

> https://www.ietf.org/mailman/listinfo/netmod