Re: [netmod] I-D Action: draft-ietf-netmod-acl-model-16.txt

Mahesh Jethanandani <mjethanandani@gmail.com> Tue, 06 February 2018 18:36 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5DFDA12741D for <netmod@ietfa.amsl.com>; Tue, 6 Feb 2018 10:36:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k2JyaLxZuTd0 for <netmod@ietfa.amsl.com>; Tue, 6 Feb 2018 10:36:44 -0800 (PST)
Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3F4E127522 for <netmod@ietf.org>; Tue, 6 Feb 2018 10:36:43 -0800 (PST)
Received: by mail-it0-x232.google.com with SMTP id p139so3725747itb.1 for <netmod@ietf.org>; Tue, 06 Feb 2018 10:36:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KfNHEhEW1MXFdQf9dG9l4GVd38xo5fzDGK+uFq/3sxY=; b=Pyqf03If+28lFhdd1/okxKbGrU1cpLPRIVlIu6h8ryFLk4PzoVAoLEKZbzeCkyIeZ8 xfhXTmyF6eWINvC8Y2lbWuLmoyEr4az3XcF/xHa0hRuI7HWp6kbSkD5svSR9ZOzeBo6Z igonfhHxL7TjT14nH1AWRMM7PZJgLVJtaRLDOShG3YV8SJd150eaQZ9arYf8HmP8C4JP ZbLA/e6PZ+Lqt9uoYRO8n5cVjr2G+kP5RqwuZPKnxRT1S2K0QLXGxaCZGswu7aJvqUmY EQsCc9lkOIQ1NWxjN0ypZ310wNIYeyPnlqY7JGN07s62q2VtE9Hae4kDjmj7CPfYqUYm 5+zw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KfNHEhEW1MXFdQf9dG9l4GVd38xo5fzDGK+uFq/3sxY=; b=HzqMpFxIUfxTXASpIltwzM5VMIGkuDdJsGvpls/fG7XjdQrHoPLR/wVJ3zIUkb7P0v hPcAeNCifEF8LqVzPIhzVtu4RMtZMhqp+U2XXi5qG0SRs1lwsq3VDDRckdGfWQipgtKG aMbhZVXC8EefBUAR+3MkXeqkM6PUvQqMb6J59t4BNC0q91/TkZAVkNLe1ojb3UYc767A cnD+BBtl0asuuUJ3jP6Zyz5KqLZBXbT9o0DiIJv+fEcO9UCzLsQaUDh/nVElHTg6WDbW xdnclA0M+WnFHGA7+XBOXbWJVsuhv//YKxm0wkIeHgnAXPWzaNFeARcPoiWxpEebnQ4Z OWgQ==
X-Gm-Message-State: APf1xPD0HP4oHFrnsk7PXkUXbvcLgOQWVjE/ZMIVYUk7Lk23btxAvhHN rfTtcKUySktTk8HWZt5sELQ+gWCs
X-Google-Smtp-Source: AH8x2252SukuO1jy7t44JnuemAF+aeKjRIkKw965Nwj2/W247rS4tOBepbGzhhZijZSVp76Q+OBIPw==
X-Received: by 10.36.190.8 with SMTP id i8mr4576777itf.26.1517942203157; Tue, 06 Feb 2018 10:36:43 -0800 (PST)
Received: from mahesh-m-m8d1.attlocal.net ([2600:1700:edb0:8fd0:d498:9d84:6f93:f7de]) by smtp.gmail.com with ESMTPSA id l82sm7585099ioe.20.2018.02.06.10.36.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2018 10:36:42 -0800 (PST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
From: Mahesh Jethanandani <mjethanandani@gmail.com>
In-Reply-To: <84f42879-1a49-d023-3a62-afbbcb53d73e@spritelink.net>
Date: Tue, 6 Feb 2018 10:36:40 -0800
Cc: netmod@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <256632EC-30B7-4353-8B88-045F652432E2@gmail.com>
References: <151762118030.14613.16606991699665016537@ietfa.amsl.com> <37914E8C-1A57-4ECF-A865-D8880169F454@gmail.com> <84f42879-1a49-d023-3a62-afbbcb53d73e@spritelink.net>
To: Kristian Larsson <kristian@spritelink.net>
X-Mailer: Apple Mail (2.3445.5.20)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/U0nR3zZg_pwuB7lySVUAUwmgVJw>
Subject: Re: [netmod] I-D Action: draft-ietf-netmod-acl-model-16.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Feb 2018 18:36:46 -0000

Kristian,

As I commented on the PR, putting the ‘container’ inside of the ‘choice’ statement allows me to collapse the ‘container’ and the ‘case’ statement into a single ‘container’ statement. With your changes, I see an additional ‘case’ statement, bloating the model in four places.

Cheers.

> On Feb 6, 2018, at 1:42 AM, Kristian Larsson <kristian@spritelink.net> wrote:
> 
> Mahesh,
> 
> I suppose, since you posted the update Friday night, that I missed my chance of prettifying the source/destination port choice/container structure that was just added. If not, it's in a PR towards your repo - https://github.com/mjethanandani/acl-model/pull/4
> 
> Kind regards,
>   Kristian.
> 
> 
> 
> On 2018-02-03 02:41, Mahesh Jethanandani wrote:
>> This update addresses the comments that were received as part of LC. For those of you who commented on the draft during the LC, please verify that your comments have been addressed.
>> Thanks.
>>> On Feb 2, 2018, at 5:26 PM, internet-drafts@ietf.org wrote:
>>> 
>>> 
>>> A New Internet-Draft is available from the on-line Internet-Drafts directories.
>>> This draft is a work item of the Network Modeling WG of the IETF.
>>> 
>>>        Title           : Network Access Control List (ACL) YANG Data Model
>>>        Authors         : Mahesh Jethanandani
>>>                          Lisa Huang
>>>                          Sonal Agarwal
>>>                          Dana Blair
>>> 	Filename        : draft-ietf-netmod-acl-model-16.txt
>>> 	Pages           : 54
>>> 	Date            : 2018-02-02
>>> 
>>> Abstract:
>>>   This document describes a data model of Access Control List (ACL)
>>>   basic building blocks.
>>> 
>>>   Editorial Note (To be removed by RFC Editor)
>>> 
>>>   This draft contains many placeholder values that need to be replaced
>>>   with finalized values at the time of publication.  This note
>>>   summarizes all of the substitutions that are needed.  Please note
>>>   that no other RFC Editor instructions are specified anywhere else in
>>>   this document.
>>> 
>>>   Artwork in this document contains shorthand references to drafts in
>>>   progress.  Please apply the following replacements
>>> 
>>>   o  "XXXX" --> the assigned RFC value for this draft both in this
>>>      draft and in the YANG models under the revision statement.
>>> 
>>>   o  Revision date in model needs to get updated with the date the
>>>      draft gets approved.  The date also needs to get reflected on the
>>>      line with <CODE BEGINS>.
>>> 
>>> 
>>> The IETF datatracker status page for this draft is:
>>> https://datatracker.ietf.org/doc/draft-ietf-netmod-acl-model/
>>> 
>>> There are also htmlized versions available at:
>>> https://tools.ietf.org/html/draft-ietf-netmod-acl-model-16
>>> https://datatracker.ietf.org/doc/html/draft-ietf-netmod-acl-model-16
>>> 
>>> A diff from the previous version is available at:
>>> https://www.ietf.org/rfcdiff?url2=draft-ietf-netmod-acl-model-16
>>> 
>>> 
>>> Please note that it may take a couple of minutes from the time of submission
>>> until the htmlized version and diff are available at tools.ietf.org.
>>> 
>>> Internet-Drafts are also available by anonymous FTP at:
>>> ftp://ftp.ietf.org/internet-drafts/
>>> 
>>> _______________________________________________
>>> netmod mailing list
>>> netmod@ietf.org
>>> https://www.ietf.org/mailman/listinfo/netmod
>> Mahesh Jethanandani
>> mjethanandani@gmail.com
>> _______________________________________________
>> netmod mailing list
>> netmod@ietf.org
>> https://www.ietf.org/mailman/listinfo/netmod
> 
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod

Mahesh Jethanandani
mjethanandani@gmail.com