Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt

[Christian Hopps <[e-mail]>]

Martin Bjorklund <[e-mail]> writes:

> Hi,
>
> Just some quick comments on the YANG:
>
> However, it seems libxml2's regexp engine requires both "[" and "^" to
> be escaped:
>
>         '[-0-9a-z "#\[\]' +
>         '!$%&()*+,./:;<=>?@\\\^_`{|}~]+';
>
> This expression isn't wrong, but it seems to me that these characters
> should not have to be escaped.
>
> The pattern allows double quote (") but not single quote (').  Is
> that intentional?

The intent was "ascii-printable". Would be nice if there was an easier way to specify this. :)

> [a simple way to test the patterns is to have a "default" statement
> and a YANG complier that verifies defaults]

Does pyang do this?

> I recommend that you rename the example module in section to
> "example-uses-geo-location" (and change the namespace to
> urn:example:uses-geo-location).   We should not use the "ietf"
> namespace for examples.

Will do.

Thanks,
Chris.

> /martin