Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt

Christian Hopps <chopps@chopps.org> Mon, 04 March 2019 20:20 UTC

Return-Path: <chopps@chopps.org>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D076130E5B for <netmod@ietfa.amsl.com>; Mon, 4 Mar 2019 12:20:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ysqZKR0H77eU for <netmod@ietfa.amsl.com>; Mon, 4 Mar 2019 12:20:25 -0800 (PST)
Received: from smtp.chopps.org (smtp.chopps.org [54.88.81.56]) by ietfa.amsl.com (Postfix) with ESMTP id D4F21128D0B for <netmod@ietf.org>; Mon, 4 Mar 2019 12:20:25 -0800 (PST)
Received: from tops.chopps.org (047-050-069-038.biz.spectrum.com [47.50.69.38]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by smtp.chopps.org (Postfix) with ESMTPS id 36F79604D0; Mon, 4 Mar 2019 15:20:25 -0500 (EST)
References: <155121476305.848.1143308532121819978@ietfa.amsl.com> <51C97F98-F877-49D4-9250-5213A31B442D@chopps.org> <20190304.105940.312797647046250578.mbj@tail-f.com>
User-agent: mu4e 1.1.0; emacs 26.1
From: Christian Hopps <chopps@chopps.org>
To: Martin Bjorklund <mbj@tail-f.com>
Cc: chopps@chopps.org, netmod@ietf.org
In-reply-to: <20190304.105940.312797647046250578.mbj@tail-f.com>
Date: Mon, 04 Mar 2019 15:20:24 -0500
Message-ID: <sa67ede1jef.fsf@chopps.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/UBrXXM0e9Pk64h6HRNBZf8fl2J0>
Subject: Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2019 20:20:27 -0000

Martin Bjorklund <mbj@tail-f.com> writes:

> Hi,
>
> Just some quick comments on the YANG:
>
> However, it seems libxml2's regexp engine requires both "[" and "^" to
> be escaped:
>
>         '[-0-9a-z "#\[\]' +
>         '!$%&()*+,./:;<=>?@\\\^_`{|}~]+';
>
> This expression isn't wrong, but it seems to me that these characters
> should not have to be escaped.
>
> The pattern allows double quote (") but not single quote (').  Is
> that intentional?

The intent was "ascii-printable". Would be nice if there was an easier way to specify this. :)

> [a simple way to test the patterns is to have a "default" statement
> and a YANG complier that verifies defaults]

Does pyang do this?

> I recommend that you rename the example module in section to
> "example-uses-geo-location" (and change the namespace to
> urn:example:uses-geo-location).   We should not use the "ietf"
> namespace for examples.

Will do.

Thanks,
Chris.

> /martin