Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

Balázs Lengyel <balazs.lengyel@ericsson.com> Sun, 17 November 2019 13:52 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53D9C12010C for <netmod@ietfa.amsl.com>; Sun, 17 Nov 2019 05:52:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y9YtIfLIqVAI for <netmod@ietfa.amsl.com>; Sun, 17 Nov 2019 05:52:17 -0800 (PST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40053.outbound.protection.outlook.com [40.107.4.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EED39120108 for <netmod@ietf.org>; Sun, 17 Nov 2019 05:52:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GyAX84cuLBF7vgeez2NXeRxFfV+ti9EutEJolVoXx7kjnw4VuISnDQaQ4ZiR7lSsxsFfv66kTVTt6Be+IAVopklZrbFx5mTTWgTqCKR8HlenDWZ1SBkmg1oQj1KGxu51OU7bRgFia2j+KfGlaes98Q3WMdUZcKHpep9aIajHh9fRk5WjNOxltYcyU32C3UPs5PrV+bj6wwHamKG+CcxekMVLrodMI0Z4mDC/61DTf2OYJI+TPKfXx7EUOhs41bwmWM13aPOHeYatgyluJGzdNMGNaRbtQtD0Os5irqlhh+C452DjwpkIK6avjYOTv38Gpvi/pbwmktwzDQsHPK22XQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ua65cGKMxYvy1Tw1UOeW+nt5LV6vNbt88zJUwixrDco=; b=iTH4WrZ3XBmSSZO2GPOB6jIs1MrrfQd33NyDwUny4EkS+DWJG42z1AjVEFE0Iqz1zvYv0sZ2t50PgfNwKYf/jyyLcM/g5rvPqcw+Y3ohpRDJ44ACGiwMtAQzKoxd7pPXckwvnqnmHiWZASHZBxeaT8DchwPr/I+OaIHBcEToSoKD3FCBiqISyfMwBaujzApUOU7Vc+wwzeTUtbgaRfteXzYyWROJPbC62AsgB5yIONPu26A6sjFIjC6x8ZjiQtJMFsJfuLvWGBvIChzSX95wGZgUv5423y3XyBGviQGWEQ3A4z9taXWZCHbnFjqL6D5oZRZikRqIE40S0nhMH0QGSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ua65cGKMxYvy1Tw1UOeW+nt5LV6vNbt88zJUwixrDco=; b=I9tgzJj/CA0NiMqDMK96MumlmPx12dJpaTFgqr9yc0xRah6Duf/wAc5wSx76IeSPknB8Mrk45a9+3yMrqqR//DwyXxa/hoiP5V2ySfcO2xK6UQDSpiZJEjwqY7xnZqLq6DXnOAViEpAwfSkJNCj9e9ctNw7J5cGc9BTeTJ8t6UA=
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com (10.186.170.77) by AM7PR07MB6328.eurprd07.prod.outlook.com (10.186.169.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.12; Sun, 17 Nov 2019 13:52:15 +0000
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::749e:982d:1c62:367b]) by AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::749e:982d:1c62:367b%4]) with mapi id 15.20.2474.012; Sun, 17 Nov 2019 13:52:15 +0000
From: =?utf-8?B?QmFsw6F6cyBMZW5neWVs?= <balazs.lengyel@ericsson.com>
To: Martin Bjorklund <mbj@tail-f.com>
CC: "andy@yumaworks.com" <andy@yumaworks.com>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
Thread-Index: AQHVf2MbQga78mSle0Opwa3noseNw6dUAaKAgCraSXCAAKy9gIAQCmdg
Date: Sun, 17 Nov 2019 13:52:15 +0000
Message-ID: <AM7PR07MB6214B5582C8EA2CB2924DA05F0720@AM7PR07MB6214.eurprd07.prod.outlook.com>
References: <20191010.140525.904627955349075516.mbj@tail-f.com> <CABCOCHShFd41gcGLTSjJQMWCA4Ak_QX2iHpng_6DBqLRf23vqw@mail.gmail.com> <AM7PR07MB62148A605167BD4D046A2E3DF0790@AM7PR07MB6214.eurprd07.prod.outlook.com> <20191107.091655.653448067546159616.mbj@tail-f.com>
In-Reply-To: <20191107.091655.653448067546159616.mbj@tail-f.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-originating-ip: [2001:67c:1232:144:110e:633f:b6cd:de19]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4f6aa031-2894-4d85-6a25-08d76b655ada
x-ms-traffictypediagnostic: AM7PR07MB6328:
x-microsoft-antispam-prvs: <AM7PR07MB6328A84F936DC9C9BC8F381BF0720@AM7PR07MB6328.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 02243C58C6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(396003)(376002)(366004)(136003)(189003)(199004)(13464003)(316002)(76116006)(6436002)(86362001)(55016002)(6306002)(8676002)(99286004)(81166006)(74316002)(54906003)(81156014)(71190400001)(71200400001)(305945005)(9686003)(7736002)(4326008)(6916009)(5660300002)(66574012)(85202003)(6246003)(66616009)(66446008)(64756008)(66556008)(66476007)(66946007)(33656002)(8936002)(52536014)(966005)(229853002)(478600001)(46003)(2906002)(11346002)(446003)(486006)(14454004)(476003)(6116002)(7696005)(76176011)(53546011)(6506007)(102836004)(25786009)(186003)(85182001)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM7PR07MB6328; H:AM7PR07MB6214.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: zyBefl9gfWk12mKPfLBGgxOABXhRYKmkSUXvHfGYzuI0q4az5U03KthFc4JYUc8rd4RunKpiU+C35ce8daUU9j/hx2kB+3RwmCWMxjdOZByGMhtdolVJem8IMhtwffoawEMG+0Ihp7Fws/tCSH+l762WP0hQZW5IaFPqMUny2RP3iOGViU8uFrXLAmLjZxOUzTS8tmD9qp0BBvcp9CO5vNxHTunyomYxhsSC/sTkbtwTrQZzBPsR0zDLhlBQWYOwklu0YY0iQV2A0SnPX7TaItjdkCUAyLVo12cJ6v2L3luaco8M0mmNwEn7JX4hGYwdZsUcRd6OtZgA3JBzGVRK9L5aKl57ztn/Pvd1HMl9NRbnYzj3SQgmccfO/jcYXttn/qUwpnAPUdtJ3KxbXxEiE13VgBLk5+4CvGkRBFTci929QvlL8zuCyliMR8IStK13
x-ms-exchange-transport-forked: True
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_02CB_01D59D8D.1880C720"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f6aa031-2894-4d85-6a25-08d76b655ada
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2019 13:52:15.6117 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WMka6iDu3iFK6fkEhmiRVxaO7rFdBH9PBxdHVd59oq5iLLq6+sxl+NL/upLqIVyv7xnCr4likgxpBNejsr5iK31V01jBkCZWLQxsczmoJro=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6328
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/UOfzo0MG9_5RKrPmL9kX7Rw8IJ8>
Subject: Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 13:52:20 -0000

See below BALAZS2.
-----Original Message-----
From: Martin Bjorklund <mbj@tail-f.com> 
Sent: 2019. november 7., csütörtök 16:17
To: Balázs Lengyel <balazs.lengyel@ericsson.com>
Cc: andy@yumaworks.com; netmod@ietf.org
Subject: Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

Balázs Lengyel <balazs.lengyel@ericsson.com> wrote:
> See below!    Balazs
> 
>  
> 
> From: netmod <netmod-bounces@ietf.org> On Behalf Of Andy Bierman
> Sent: 2019. október 10., csütörtök 17:34
> To: Martin Bjorklund <mbj@tail-f.com>
> Cc: NetMod WG <netmod@ietf.org>
> Subject: Re: [netmod] comments on 
> draft-ietf-netmod-yang-instance-file-format-04
> 
>  
> 
>  
> 
>  
> 
> On Thu, Oct 10, 2019 at 5:06 AM Martin Bjorklund <mbj@tail-f.com <mailto:mbj@tail-f.com> > wrote:
> 
> 
>   o  leaf-list module
> 
>     The type of this leaf-list is a string with:
> 
>       pattern '.+@\d{4}-\d{2}-\d{2}\.yang'yang';
> 
>     I think the revision needs to be optional, and the suffix ".yang"
>     dropped, since it doesn't add any value:
> 
>       pattern '.+(@\d{4}-\d{2}-\d{2})?';
> 
>    (same for inline-spec).
> 
>  
> 
> IMO the filespec SHOULD follow the pattern in  
> https://tools.ietf.org/html/rfc7950#section-5.2
> 
> BALAZS: It does follow the pattern except that I made the revision date mandatory. It is needed to properly understand the instance data.
> 
>  
> 
> Except a new file extension SHOULD be used.
> 
> Suggest: .yif == YANG Instance File
> 
>  
> 
> Obviously it would be a horrible idea to use .yang since that 
> extension
> 
> is already used to identify a YANG schema file.
> 
> BALAZS: The leaf-list lists not the instance data files but the content defining YANG modules, so IMO “.yang” is an appropriate extension. It is really a YANG schema file we are listing.

No, you are not listing a file name, you are listing the name and, optionally, the revision of a YANG *module*.  It can internally be stored as a .yang file a .yin file, or as a blob in a database.

Hence, we should not have the ".yang" suffix here.
BALAZS2:
OK, I will add the '.yin' possibility.
I would like to keep the file extension because
ietf-yang-type@2015-12-07.yang
looks more familiar, will be easier to understand, than just
ietf-yang-types@2019-12-07
IMHO in practice systems might very well use it for file lookup.

I updated the pattern to: 
              pattern '[a-zA-Z_][a-zA-Z0-9\-_.]*' +
                '(@\d{4}-\d{2}-\d{2})?\.((yang)|(yin))'in))';
/martin