Re: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4

[Martin Bjorklund <[e-mail]>]

Hi,

Thank you for the review.  Comments inline.

"Rob Wilton (rwilton)" <[e-mail]> wrote:
> Hi,
> 
> I've reviewed this document, and other than 2 minor nits, I believe
> that it is ready for publication. 
> 
> Two minor comments:
> 
> 
>   1.  Section 1.1.1 NMDA.  There should be a comma before "and are
>   not redefined here".

Fixed.

>   2.  I wonder whether it would be useful to have a sentence in the
>   "Definitions" section that defines how a structure is encoded.
>   Although I appreciate that this is specified in the YANG module
>   itself.  An alternative could be a forward reference from the
>   Definitions section to the YANG module.  This could also cover the
>   Xpath behaviour as well.

This is probably a good idea.  Perhaps also add a small example:


   A YANG data structure is encoded in the same way as an "anydata"
   node.  This means that the name of the structure is encoded as a
   "container", with the instantiated children encoded as child nodes to
   this node.  For example, this structure:

     module example-errors {
       ...

       sx:structure my-error {
         leaf error-number {
           type int;
         }
       }
     }

   can be encoded in JSON as:

     "example-module:my-error": {
       "error-number": 131
     }



/martin



> 
> Thanks,
> Rob
> 
> 
> From: netmod <[e-mail]> On Behalf Of Joel Jaeggli
> Sent: 27 September 2019 06:32
> To: NETMOD Working Group <[e-mail]>
> Subject: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4
> 
> All,
> 
> This starts a two week working group last call for  draft-ietf-netmod-yang-data-ext-04
> 
> The working group last call ends on  Friday October 11th 2019.  Please send your comments to the working group mailing list.
> 
> Positive comments, e.g., "I've reviewed this document and believe it is ready for publication", are welcome!  This is useful and important, even from authors.
> 
> 
> https://tools.ietf.org/html/draft-ietf-netmod-yang-data-ext-04
> 
> 
> The diff from 03, produced prior to IETF 105 is available here:
> 
> 
> https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-netmod-yang-data-ext-04.txt
> 
> 
> Thanks
> Joel
> 
>