Re: [netmod] I-D Action: draft-ietf-netmod-sub-intf-vlan-model-01.txt

Hi Vladimir,

Thanks for raising this.

On 15/06/2017 12:59, Vladimir Vassilev wrote:
> Hello,
>
> There is a problem with a mutually exclusive 'when' statements for the 
> /interfaces/inteface/encapsulation container in 
> ietf-interfaces-common@2017-03-13.yang 
> (draft-ietf-netmod-intf-ext-yang-04) and 
> ietf-if-l3-vlan@2017-03-13.yang  models causing error with our 
> validation tools.
>
> As defined in ietf-interfaces-common@2017-03-13.yang:
>
> ...
>
>     container encapsulation {
>       when
>         "derived-from-or-self(../if:type,
>                               'ianaift:ethernetCsmacd') or
>          derived-from-or-self(../if:type,
>                               'ianaift:ieee8023adLag') or
>          derived-from-or-self(../if:type, 'ianaift:pos') or
>          derived-from-or-self(../if:type,
>                               'ianaift:atmSubInterface') or
>          derived-from-or-self(../if:type, 'ethSubInterface')" {
>
> ...
>
> and here augmented in ietf-if-l3-vlan@2017-03-13.yang:
>
>   augment "/if:interfaces/if:interface/if-cmn:encapsulation/" +
>           "if-cmn:encaps-type" {
>     when "../if:type = 'ianaift:l2vlan' and
>           derived-from-or-self(../if-cmn:forwarding-mode,
>                                'if-cmn:network-layer')" {
>
> Short term fix I use is to add "or derived-from-or-self(../if:type, 
> 'ianaift:l2vlan')" to the ietf-interfaces-common definition.
I suspect that probably the reverse fix is probably better.

I.e. add derived-from-or-self(../if:type, 'ethSubInterface' to the 
encapsulation when statement replacing the l2vlan, since ethSubInterface 
derived from l2vlan anyway.

Thanks,
Rob

>
>
> Vladimir
>
>
> On 03/13/2017 08:38 PM, internet-drafts@ietf.org wrote:
>> A New Internet-Draft is available from the on-line Internet-Drafts 
>> directories.
>> This draft is a work item of the NETCONF Data Modeling Language of 
>> the IETF.
>>
>>          Title           : Sub-interface VLAN YANG Data Models
>>          Authors         : Robert Wilton
>>                            David Ball
>>                            Tapraj Singh
>>                            Selvakumar Sivaraj
>>     Filename        : draft-ietf-netmod-sub-intf-vlan-model-01.txt
>>     Pages           : 27
>>     Date            : 2017-03-13
>>
>> Abstract:
>>     This document defines YANG modules to add support for classifying
>>     traffic received on interfaces as Ethernet/VLAN framed packets to
>>     sub-interfaces based on the fields available in the Ethernet/VLAN
>>     frame headers.  These modules allow configuration of Layer 3 and
>>     Layer 2 sub-interfaces (e.g. attachment circuits) that can
>>     interoperate with IETF based forwarding protocols; such as IP and
>>     L3VPN services; or L2VPN services like VPWS, VPLS, and EVPN.  The
>>     sub-interfaces also interoperate with VLAN tagged traffic orginating
>>     from an IEEE 802.1Q compliant bridge.  Primarily the classification
>>     is based on VLAN identifiers in the 802.1Q VLAN tags, but the model
>>     also has support for matching on some other layer 2 frame header
>>     fields and is designed to be extensible to match on other arbitrary
>>     header fields.
>>
>>     The model differs from an IEEE 802.1Q bridge model in that the
>>     configuration is interface/sub-interface based as opposed to being
>>     based on membership of an 802.1Q VLAN bridge.
>>
>>
>> The IETF datatracker status page for this draft is:
>> https://datatracker.ietf.org/doc/draft-ietf-netmod-sub-intf-vlan-model/
>>
>> There's also a htmlized version available at:
>> https://tools.ietf.org/html/draft-ietf-netmod-sub-intf-vlan-model-01
>>
>> A diff from the previous version is available at:
>> https://www.ietf.org/rfcdiff?url2=draft-ietf-netmod-sub-intf-vlan-model-01 
>>
>>
>>
>> Please note that it may take a couple of minutes from the time of 
>> submission
>> until the htmlized version and diff are available at tools.ietf.org.
>>
>> Internet-Drafts are also available by anonymous FTP at:
>> ftp://ftp.ietf.org/internet-drafts/
>>
>> _______________________________________________
>> netmod mailing list
>> netmod@ietf.org
>> https://www.ietf.org/mailman/listinfo/netmod
>
> .
>