Re: [netmod] RtgDir review: draft-ietf-netmod-schema-mount-10.txt

Martin Bjorklund <mbj@tail-f.com> Mon, 06 August 2018 10:46 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D099130DBE; Mon, 6 Aug 2018 03:46:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Aj_Snp6e3IZ; Mon, 6 Aug 2018 03:45:59 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id DE421128CF3; Mon, 6 Aug 2018 03:45:55 -0700 (PDT)
Received: from localhost (unknown [173.38.220.61]) by mail.tail-f.com (Postfix) with ESMTPSA id D7C531AE0141; Mon, 6 Aug 2018 12:45:53 +0200 (CEST)
Date: Mon, 06 Aug 2018 12:45:52 +0200 (CEST)
Message-Id: <20180806.124552.546267868496801549.mbj@tail-f.com>
To: matthew.bocci@nokia.com
Cc: rtg-ads@ietf.org, rtg-dir@ietf.org, netmod@ietf.org, draft-ietf-netmod-schema-mount.all@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <8072D6C6-B951-4836-A423-9E71BED4F8DD@nokia.com>
References: <8072D6C6-B951-4836-A423-9E71BED4F8DD@nokia.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/WHbQaZflQVVzabsI1VKoEQg5fmo>
Subject: Re: [netmod] RtgDir review: draft-ietf-netmod-schema-mount-10.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2018 10:46:02 -0000

Hi,

Thank you for your review!  Comments inline.

"Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com>; wrote:
> Hello,
> 
> I have been selected as the Routing Directorate reviewer for this
> draft. The Routing Directorate seeks to review all routing or
> routing-related drafts as they pass through IETF last call and IESG
> review, and sometimes on special request. The purpose of the review is
> to provide assistance to the Routing ADs. For more information about
> the Routing Directorate, please see
> ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
> 
> Although these comments are primarily for the use of the Routing ADs,
> it would be helpful if you could consider them along with any other
> IETF Last Call comments that you receive, and strive to resolve them
> through discussion or by updating the draft.
> 
> Document: draft-ietf-netmod-schema-mount-10.txt
> Reviewer: Matthew Bocci
> Review Date: 11 June 2018
> IETF LC End Date: unknown
> Intended Status: Standards Track
> 
> Summary:
> 
> This document is basically ready for publication, but has nits that
> should be considered prior to publication.
> 
> Comments:
> 
> The draft is clearly written and easy to understand. I have no
> significant concerns although there are a few minor editorial nits
> that I think should be addressed.
> 
> 
> Major Issues:
> 
> No major issues found.
> 
> Minor Issues:
> 
> No minor issues found.
> 
> Nits:
> 
> I found the references to the mechanism as simply "schema mount" made
> the document harder to parse than it should be. For example
> "The basic idea of schema mount is to label...". It would be more
> readable to always refer to the mechanism as "a schema mount" or "the
> schema mount"
> as appropriate.

A similar comment was made by the opsdir reviewer.  Since the draft
says in the Introduction:

  This document introduces a new mechanism, denoted as schema
  mount, that allows for mounting one data model [...]

we have added "schema mount" to the terminology section:

  - schema mount: The mechanism to combine data models defined in this
    document.


> There are a few other places where the indefinite article is missing
> e.g. the definitions in section 2.1 would be
> more readable if they started with 'a', thus: "schema: a collection of
> schema trees..."

Fixed.

> Section 2.1 Glossary of new terms
> "- Schema: collection of schema trees with a common root"
> I am not sure that you can really say that 'schema' is a new
> term. Maybe this could be rephrased to say "the term schema is used in
> this document to refer to..."

We have merged this section with the previous section, and instead
added:

   The following additional terms are used within this document:

      [...]

      o  schema: A collection of schema trees with a common root.

(thus it is no longer labeled as being a "new term")


/martin