Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-diagrams
Vladimir Vassilev <vladimir@transpacket.com> Tue, 16 January 2018 09:20 UTC
Return-Path: <vladimir@transpacket.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB5CE12FAFB for <netmod@ietfa.amsl.com>; Tue, 16 Jan 2018 01:20:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4hc_cL0tvcpX for <netmod@ietfa.amsl.com>; Tue, 16 Jan 2018 01:20:34 -0800 (PST)
Received: from mail.transpacket.com (s91205186171.blix.com [91.205.186.171]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C6BA12FB03 for <netmod@ietf.org>; Tue, 16 Jan 2018 01:19:36 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.transpacket.com (Postfix) with ESMTP id E4BAB1442D35 for <netmod@ietf.org>; Tue, 16 Jan 2018 10:19:34 +0100 (CET)
Received: from mail.transpacket.com ([127.0.0.1]) by localhost (mail.transpacket.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JedJ4yeIxfwV for <netmod@ietf.org>; Tue, 16 Jan 2018 10:19:34 +0100 (CET)
Received: from localhost (localhost [127.0.0.1]) by mail.transpacket.com (Postfix) with ESMTP id B92D71442D36 for <netmod@ietf.org>; Tue, 16 Jan 2018 10:19:34 +0100 (CET)
Received: from mail.transpacket.com ([127.0.0.1]) by localhost (mail.transpacket.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RUGbsZEsEktE for <netmod@ietf.org>; Tue, 16 Jan 2018 10:19:34 +0100 (CET)
Received: from [192.168.2.191] (cm-84.211.71.154.getinternet.no [84.211.71.154]) by mail.transpacket.com (Postfix) with ESMTPSA id 9671A1442D2E for <netmod@ietf.org>; Tue, 16 Jan 2018 10:19:34 +0100 (CET)
To: netmod@ietf.org
References: <2cde8b64-0455-a513-4719-feb61c87a952@bogus.com> <aa7a1449-fd6e-e4c6-7568-41061c09d9f2@transpacket.com>
From: Vladimir Vassilev <vladimir@transpacket.com>
Message-ID: <a2929f9a-cc2f-36e4-a0fc-848f70575cc5@transpacket.com>
Date: Tue, 16 Jan 2018 10:19:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <aa7a1449-fd6e-e4c6-7568-41061c09d9f2@transpacket.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: nb
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/YY2zc9J4uAxj3UMcBNLAEJ05ylk>
Subject: Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-diagrams
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 09:20:37 -0000
On 01/15/2018 09:41 PM, Vladimir Vassilev wrote: > Hi, > > I have reviewed and implemented (apart from schema mount specific > functionality) draft-ietfetf-netmod-yang-tree-diagrams-04 and found > the following issues: > > ==sec 2.6. Node Representation== > > 1. To correctly reflect the current pyang output one needs to add '--' > between <status> and <flags>. > OLD: > <status> <flags> <name> <opts> <type> <if-features> > NEW: > <status>--<flags> <name> <opts> <type> <if-features> > > There is also undocumented alignment space count function before > <type> that pyang uses to align the <type> fields of child data leafs > with common ancestor. If this is specified in the draft the tree > output can be deterministic and for me this is an advantage. This is > currently one of the few underspecified pieces of the tree format so I > had to check pyang implementation in oder to generate same alignment > space counts and binary identical tree output results. > > > 2. It is unclear which <flags> option should be used for rpc and > action input/output and child nodes and the notification child nodes. > pyang uses '-w' for input and input/* and 'ro' for output and output/*: > > module: ietf-netconf-partial-lock > rpcs: > +---x partial-lock > | +---w input > | | +---w select* string > ... > > pyang also uses '--' as <flags> for augmentation data nodes for > actions input. > > ... > augment /rt:routing-state/rt:ribs/rt:rib/rt:active-route/rt:input: > +---- destination-address? inet:ipv4-address > ... > > > 3. pyang is prefixing choice node names with the parent <flags> e.g. > +--ro (next-hop-options) while case nodes are not prefixed. I guess > this is a bug in pyang since it is not specified in the draft but > choice nodes prefixed with parent <flags> are also present in the sec > 4 and 4.1 examples? Ignore 3. choice had a config substatement which explains the presence of <flags>. > > 4. This bit I found confusing. I propose this change to unambiguously > describe the current pyang format. > > OLD: > * for a leaf-list or list > [<keys>] for a list's keys > NEW: > * for a leaf-list or list without keys > * [<keys>] for a list with keys > > Vladimir > > On 01/01/2018 11:01 PM, joel jaeggli wrote: >> Greetings, >> >> We hope the new year is a time to make great progess on outstanding >> documents before preparation for the London IETF begins in earnest. >> >> This starts a two-week working group last call on: >> >> YANG Tree Diagrams >> draft-ietf-netmod-yang-tree-diagrams >> >> https://datatracker.ietf.org/doc/draft-ietf-netmod-yang-tree-diagrams/ >> >> Please send email to the list indicating your support or concerns. >> >> We are particularly interested in statements of the form: >> >> * I have reviewed this draft and found no issues. >> * I have reviewed this draft and found the following issues: ... >> >> >> Thank you, >> NETMOD WG Chairs > > _______________________________________________ > netmod mailing list > netmod@ietf.org > https://www.ietf.org/mailman/listinfo/netmod
- [netmod] WGLC - draft-ietf-netmod-yang-tree-diagr… joel jaeggli
- [netmod] Reminder: WGLC - draft-ietf-netmod-yang-… joel jaeggli
- [netmod] 答复: Reminder: WGLC - draft-ietf-netmod-y… Qin Wu
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… t.petch
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Benoit Claise
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Robert Wilton
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Robert Wilton
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Martin Bjorklund
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Robert Wilton
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Acee Lindem (acee)
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Lou Berger
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Martin Bjorklund
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Robert Wilton
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Vladimir Vassilev
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Martin Bjorklund
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Vladimir Vassilev
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… Benoit Claise
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Martin Bjorklund
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Vladimir Vassilev
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Robert Wilton
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Martin Bjorklund
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Lou Berger
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Robert Wilton
- Re: [netmod] Reminder: WGLC - draft-ietf-netmod-y… joel jaeggli
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… joel jaeggli
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Vladimir Vassilev
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Juergen Schoenwaelder
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Alexander Clemm
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Martin Bjorklund
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Juergen Schoenwaelder
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Vladimir Vassilev
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Juergen Schoenwaelder
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Robert Wilton
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… t.petch
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Martin Bjorklund
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Robert Wilton
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Juergen Schoenwaelder
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Benoit Claise
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… Jeff Tantsura
- Re: [netmod] WGLC - draft-ietf-netmod-yang-tree-d… t.petch
- [netmod] Closure - : WGLC - draft-ietf-netmod-yan… joel jaeggli
- Re: [netmod] Closure - : WGLC - draft-ietf-netmod… Martin Bjorklund