Re: [netmod] AD review of draft-ietf-netmod-entity-06

Benoit Claise <bclaise@cisco.com> Thu, 21 December 2017 14:53 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2AA012D7F7 for <netmod@ietfa.amsl.com>; Thu, 21 Dec 2017 06:53:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o5TfSPBAQCeI for <netmod@ietfa.amsl.com>; Thu, 21 Dec 2017 06:53:58 -0800 (PST)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8EF9D120724 for <netmod@ietf.org>; Thu, 21 Dec 2017 06:53:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2166; q=dns/txt; s=iport; t=1513868037; x=1515077637; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=GWMEEfnzq29l9TOWT85od/mwmVJ+219opJQV66+NRng=; b=X4TI/M31/OsJkPr1KnLKzCC76+rgZCuYp2MuJeexbOo1KpkFXU+Cg4rg h/dx8SbPd/E5i0gUcohPkoHAQrg5LjO9eaLEnqYkGw7DjDs+EPIYOwOdu uh1C2xVf7HdZ0uyxkGqGU9EO6Tg7g0rRa9OCVQmIWcyFRaL4LwyOh8C1/ A=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BxAQBryjta/xbLJq1bGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYUYJ4QGixiQHZk+CoU7AoUMFQEBAQEBAQEBAWsohSQBBSMVUQs?= =?us-ascii?q?OAggCAiYCAlcGAQwGAgEBiiekZYInim0BAQEBAQEBAwEBAQEBASKBD4Jwg2iCE?= =?us-ascii?q?oMFgzCBTgEBCIMtgmUBBJIdkSuVL4IXigEkhz6OeogFgTs1I4FPMhoIGxWCZYR?= =?us-ascii?q?YQDeHXII7AQEB?=
X-IronPort-AV: E=Sophos;i="5.45,436,1508803200"; d="scan'208";a="1020550"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 14:53:43 +0000
Received: from [10.55.221.36] (ams-bclaise-nitro3.cisco.com [10.55.221.36]) by aer-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id vBLErhqS001040; Thu, 21 Dec 2017 14:53:43 GMT
To: Martin Bjorklund <mbj@tail-f.com>, netmod@ietf.org
References: <cb06b12e-59d9-148e-03f0-2ffdb1e4e15f@cisco.com> <20171221.123746.382540578845045602.mbj@tail-f.com> <20171221115010.annbhb4vs3roo4dk@elstar.local> <20171221.125826.1295894140821866805.mbj@tail-f.com> <20171221120336.asqnp343in7y26ie@elstar.local>
From: Benoit Claise <bclaise@cisco.com>
Message-ID: <79cc9570-0bcc-f935-cc3b-4dd5289b4520@cisco.com>
Date: Thu, 21 Dec 2017 15:53:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171221120336.asqnp343in7y26ie@elstar.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/YrUtLcX4-pkThPyNEEW0RnPTq_I>
Subject: Re: [netmod] AD review of draft-ietf-netmod-entity-06
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Dec 2017 14:54:00 -0000

On 12/21/2017 1:03 PM, Juergen Schoenwaelder wrote:
> On Thu, Dec 21, 2017 at 12:58:26PM +0100, Martin Bjorklund wrote:
>> Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> wrote:
>>> On Thu, Dec 21, 2017 at 12:37:46PM +0100, Martin Bjorklund wrote:
>>>> Hi,
>>>>
>>>> I need WG input on this issue.  The question is how to handle
>>>> 'serial-num', 'mfg-name', and 'model-name'.  I think they should all
>>>> be treated the same.  Based on previous WG discussion (see e.g. the
>>>> mail thread "draft-ietf-netmod-entity issue #13"), I think they should
>>>> all be configurable, but the configured value is only used in
>>>> operational state if the system cannot read it from the hardware.
>>>>
>>>> So I suggest the following changes:
>>>>
>>>> OLD:
>>>>
>>>>        leaf serial-num {
>>>>          type string;
>>>>          config false;
>>>>          description
>>>>            "The vendor-specific serial number string for the
>>>>             component.  The preferred value is the serial number
>>>>             string actually printed on the component itself (if
>>>>             present).";
>>>>          reference "RFC 6933: entPhysicalSerialNum";
>>>>        }
>>>>
>>>> NEW:
>>>>
>>>>        leaf serial-num {
>>>>          type string;
>>>>          description
>>>>            "The vendor-specific serial number string for the
>>>>             component.  The preferred value is the serial number
>>>>             string actually printed on the component itself (if
>>>>             present).
>>> The last sentence is not useful since nobody knows what 'preferred'
>>> value means. So remove it.
>> This text comes from RFC 6933.  Do you really think it is not clear
>> what the intention is?
> I guess I read too fast. No, the sentence is fine. My comment was wrong.
>
> [...]
>   
>> Agreed.  So we'd have a single paragraph:
>>
>>     This leaf can be configured.  The configured value is used only if
>>     the server cannot determine the vendor-specific serial number from
>>     the component itself.
> Yes, I think this covers it.
That works for me.

Regards, B.
>
> /js
>