Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
Martin Bjorklund <mbj@tail-f.com> Mon, 26 August 2019 07:04 UTC
Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61C9E1200A4 for <netmod@ietfa.amsl.com>; Mon, 26 Aug 2019 00:04:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U3c2UGyxT7lP for <netmod@ietfa.amsl.com>; Mon, 26 Aug 2019 00:04:36 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id EE16D120019 for <netmod@ietf.org>; Mon, 26 Aug 2019 00:04:35 -0700 (PDT)
Received: from localhost (unknown [173.38.220.50]) by mail.tail-f.com (Postfix) with ESMTPSA id AF0D21AE0187; Mon, 26 Aug 2019 09:04:31 +0200 (CEST)
Date: Mon, 26 Aug 2019 09:04:08 +0200
Message-Id: <20190826.090408.243319791214325843.mbj@tail-f.com>
To: rwilton@cisco.com
Cc: vladimir@transpacket.com, netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <MN2PR11MB4366DA593D42209D7F44C8EFB5A50@MN2PR11MB4366.namprd11.prod.outlook.com>
References: <MN2PR11MB4366C1CD8F0567D0C360F1BAB5A50@MN2PR11MB4366.namprd11.prod.outlook.com> <20190822.133449.502914144686905879.mbj@tail-f.com> <MN2PR11MB4366DA593D42209D7F44C8EFB5A50@MN2PR11MB4366.namprd11.prod.outlook.com>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="utf-8"
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/_Kyql57qfBQo4wo1wBweV-NLdw4>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2019 07:04:38 -0000
"Rob Wilton (rwilton)" <rwilton@cisco.com> wrote: > Hi Martin, > > Please see comments inline ... > > > -----Original Message----- > > From: Martin Bjorklund <mbj@tail-f.com> > > Sent: 22 August 2019 12:35 > > To: Rob Wilton (rwilton) <rwilton@cisco.com> > > Cc: vladimir@transpacket.com; netmod@ietf.org > > Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07 > > > > Hi, > > > > Some comments inline. > > > > > > "Rob Wilton (rwilton)" <rwilton@cisco.com> wrote: > > > Hi Vladimir, > > > > > > Thanks for your detailed review. Sorry for the slow reply, I've been > > > away. I'm also about to be away again for a couple of days. > > > > > > Please see my comments inline ... > > > > > > I'll also track these issues to closure on > > > https://github.com/netmod-wg/interface-extensions-yang/issues > > > > > > > -----Original Message----- > > > > From: netmod <netmod-bounces@ietf.org> On Behalf Of Vladimir > > > > Vassilev > > > > Sent: 13 August 2019 17:05 > > > > To: Kent Watsen <kent+ietf@watsen.net>; netmod@ietf.org > > > > Subject: Re: [netmod] WG Last Call: > > > > draft-ietf-netmod-intf-ext-yang-07 > > > > > > > > I have reviewed the draft. I have the following (19) IMO useful > > > > proposals: > > > > > > > > 1. Dedicated module (ietf-if-oper-status-debounce.yang) for the > > > > oper- status debouncing/dampening functionality currently in > > > > ietf-interfaces- > > > > common.yang. > > > > > > I don't think that we want a proliferation of too many separate YANG > > > modules for small features. Each of the areas of different > > > functionality within this module are already conditional on > > > if-feature, so I don't think that there is a strong justification to > > > separating this out as a separate module. > > > > I agree. > > > > > > 4. Dedicated module (ietf-if-loopback.yang) for the loopback > > > > functionality currently in ietf-interfaces-common.yang. > > > > > > Same answer as for 1. I don't think that we should have too many > > > really small modules. > > > > I agree. > > > > > > > > 10. Introducing config true "forwarding-mode" leaf breaks clients > > > > that support e.g. rfc8344 ietf-ip (which has its dedicated > > > > forwarding leafs e.g. > > > > /ietf-interfaces:interfaces/interface/ietf-ip:ipv4/forwarding ) by > > > > introducing this new module with a new leaf they know nothing about. > > > > I support this leaf as config false. If NETCONF was not > > > > transactional a global leaf enabling the forwarding configuration > > > > would be a feature. > > > > But NETCONF is transactional. > > > > > > I don't get the relevance of transactions Neither do I. > > > , but it isn't intended to > > > break existing clients/YANG modules. > > > > > > The idea of this leaf is that if it is configured then the system can > > > use it to check other constraints. E.g. to validate that an L2 QoS > > > policy isn’t being configured on an L3 interface. If the leaf isn't > > > configured then those constraints are not checked. > > > > Hmm. Are you saying that this leaf doesn't have any direct effect in > > the > > server? > > It depends on the device. Some devices require a leaf like this (or > similar) to correctly provision the services. Other devices don't > need it. Hmm, is this really a property of the device implementation? Isn't it a property of the data models that describe these services? It seems to me that the semantics of this leaf is a bit unclear, esp. if we look at the sub-intf-vlan model which uses this leaf: container dot1q-vlan { must 'count(../../if-cmn:forwarding-mode) = 0 or ' + 'derived-from-or-self(../../if-cmn:forwarding-mode,' + '"if-cmn:layer-3-forwarding")' This means that it is perfectly ok for a client to configure "dot1q-vlan" without also setting forwarding-mode. > > > > 19. ietf-if-common.yang and ietf-if-ethernet-like.yang instead of > > > > ietf- > > > > interfaces-common.yang and ietf-interfaces-ethernet-like.yang. > > > > Setting a shorter naming precedent for future modules augmenting > > > > ietf- interfaces. > > > > > > I'm not opposed to shorter names, but would be interested in the views > > > of others in the WG. > > > > I had a similar concern for the modules in the sub-intf-vlan draft (I > > will > > post my review of that doc later). > > > > Currently we have: > > > > ietf-interfaces-common > > ietf-interfaces-ethernet-like > > ietf-if-l3-vlan > > ietf-flexible-encapsulation > > > > I think we should have consistency, either: > > > > ietf-interfaces-common > > ietf-interfaces-ethernet-like > > ietf-interfaces-l3-vlan > > ietf-interfaces-flexible-encapsulation > > > > or > > > > ietf-if-common > > ietf-if-ethernet-like > > ietf-if-l3-vlan > > ietf-if-flexible-encapsulation > > > > I prefer the shorter names personally. Ok. /martin > > Thanks, > Rob > > > > > > /martin > > > > > > > > > > Thanks again for the review. It is appreciated. > > > > > > Rob > > > > > > > > > > > > > > /Vladimir > > > > > > > > On 10/07/2019 02.15, Kent Watsen wrote: > > > > > All, > > > > > > > > > > This starts a twelve-day working group last call for > > > > > draft-ietf-netmod-intf-ext-yang-07 > > > > > > > > > > The working group last call ends on July 21 (the day before the > > > > > NETMOD > > > > 105 sessions). Please send your comments to the working group > > > > mailing list. > > > > > > > > > > Positive comments, e.g., "I've reviewed this document and believe > > > > > it is > > > > ready for publication", are welcome! This is useful and important, > > > > even from authors. > > > > > > > > > > Thank you, > > > > > NETMOD Chairs > > > > > _______________________________________________ > > > > > netmod mailing list > > > > > netmod@ietf.org > > > > > https://www.ietf.org/mailman/listinfo/netmod > > > > > > > > _______________________________________________ > > > > netmod mailing list > > > > netmod@ietf.org > > > > https://www.ietf.org/mailman/listinfo/netmod > > > _______________________________________________ > > > netmod mailing list > > > netmod@ietf.org > > > https://www.ietf.org/mailman/listinfo/netmod
- [netmod] WG Last Call: draft-ietf-netmod-intf-ext… Kent Watsen
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Acee Lindem (acee)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Acee Lindem (acee)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Balázs Lengyel
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Qin Wu
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Qin Wu
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Mahesh Jethanandani
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Qin Wu
- Re: [netmod] WG Last Call: draft-ietf-netmod-intf… Rob Wilton (rwilton)