[netmod] AD review of draft-ietf-netmod-rfc7223bis-01

Benoit Claise <bclaise@cisco.com> Mon, 18 December 2017 14:43 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D303B1270AC for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 06:43:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.61
X-Spam-Level:
X-Spam-Status: No, score=-12.61 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Uu5ReQ3hTq8M for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 06:43:18 -0800 (PST)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE62B124B17 for <netmod@ietf.org>; Mon, 18 Dec 2017 06:43:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5470; q=dns/txt; s=iport; t=1513608197; x=1514817797; h=from:subject:to:message-id:date:mime-version; bh=ukS97tR4MresKOyVqhZGlvzCJ7vOlpMZ9bpMJKqwwZ0=; b=AeQVYO7YxH+DYtxSTaS4/+8z+RYuGK0+4yfHEUfVzl26sJNruWAMPg4a p0m0oJnZCaaXpug4ezkxmeEV2dIinmaPYlW5YSFh125d7RoBIlsFzqUxB fBm125T4QnreXkklHQpFDQnO0Sy1PlLji74ebWY1LKvO6/pRahJMQ/QqO U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AqAwCt0zda/xbLJq1cGgEBAQEBAgEBA?= =?us-ascii?q?QEIAQEBAYQkdCAHAYQFixWhZYVQFIIBCiOKYRYBAQEBAQEBAQFrKIVNBHE+Al8?= =?us-ascii?q?NBgIBAYomCQeZcJAVgW06JopCAQEBAQYBAQEBASODboNkghKGJgsBAYE1IoMrg?= =?us-ascii?q?mMFkhuRIYd/g3GJPIJ5iRyHXo0bf1qIBIE7Jg0lgU8yGggbFYJlCYROQDeKFgE?= =?us-ascii?q?BAQ?=
X-IronPort-AV: E=Sophos;i="5.45,422,1508803200"; d="scan'208,217";a="940003"
Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2017 14:43:15 +0000
Received: from [10.55.221.36] (ams-bclaise-nitro3.cisco.com [10.55.221.36]) by aer-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id vBIEhF31005142 for <netmod@ietf.org>; Mon, 18 Dec 2017 14:43:15 GMT
From: Benoit Claise <bclaise@cisco.com>
To: NETMOD Working Group <netmod@ietf.org>
Message-ID: <4f4df77e-c88e-502d-56b0-5007e93a854f@cisco.com>
Date: Mon, 18 Dec 2017 15:43:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------28F9884B56C0127D97AED2F2"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/cnrZ54qzVJ_j_vaLVxW2f--UWkQ>
Subject: [netmod] AD review of draft-ietf-netmod-rfc7223bis-01
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Dec 2017 14:43:20 -0000

Dear all,

In order not to be the bottleneck in the process, here is my AD review 
of draft-ietf-netmod-rfc7223bis-01 
<https://datatracker.ietf.org/doc/draft-ietf-netmod-rfc7223bis/>

Editorial:

-
    An interface is identified by its name, which is unique within the
    server.  This property is captured in the "interface-ref"_and_
    typedef, which other YANG modules SHOULD use when they need to
    reference an interface.

NEW:
    An interface is identified by its name, which is unique within the
    server.  This property is captured in the "interface-ref"
    typedef, which other YANG modules SHOULD use when they need to
    reference an interface.

-
    Note that NETCONF and SNMP may
    differ in the time granularity in which they provide access to the
    counters.

I guess we want to remove the reference to NETCONF?
Proposal:
    Note the server that implements the YANG module and the SNMP Agent may
    differ in the time granularity in which they provide access to the
    counters.
  
-
We want to mention that "or:" comes from "ietf-origin@2017-08-17.yang"; in draft-ietf-netmod-revised-datastores

<rpc-reply
        xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"
        message-id="101">
      <data>
        <interfaces
            xmlns="urn:ietf:params:xml:ns:yang:ietf-interfaces"
            xmlns:ianaift="urn:ietf:params:xml:ns:yang:iana-if-type"
            xmlns:vlan="http://example.com/vlan"
            xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin">

          <interface or:origin="or:intended">
            <name>eth0</name>
            <type>ianaift:ethernetCsmacd</type>
            <enabled>false</enabled>
            <admin-status>down</admin-status>
            <oper-status>down</oper-status>
            <if-index>2</if-index>
            <phys-address>00:01:02:03:04:05</phys-address>
            <statistics>
              <discontinuity-time>
                2013-04-01T03:00:00+00:00
              </discontinuity-time>
              <!-- counters now shown here -->
            </statistics>
          </interface>

Regards, Benoit (as OPS AD)