Return-Path: <chopps@chopps.org>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 3B1CA130DDE
 for <netmod@ietfa.amsl.com>; Tue, 16 Oct 2018 05:31:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id zrNsYfCX8dQf for <netmod@ietfa.amsl.com>;
 Tue, 16 Oct 2018 05:31:47 -0700 (PDT)
Received: from smtp.chopps.org (smtp.chopps.org [54.88.81.56])
 by ietfa.amsl.com (Postfix) with ESMTP id BEE2A130DC9
 for <netmod@ietf.org>; Tue, 16 Oct 2018 05:31:46 -0700 (PDT)
Received: from [192.168.2.5] (47-50-69-38.static.klmz.mi.charter.com
 [47.50.69.38])
 (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by smtp.chopps.org (Postfix) with ESMTPSA id E54C36005B;
 Tue, 16 Oct 2018 12:31:45 +0000 (UTC)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Christian Hopps <chopps@chopps.org>
In-Reply-To: <20181002203031.pcdclhq7vb5tohrj@anna.jacobs.jacobs-university.de>
Date: Tue, 16 Oct 2018 08:31:43 -0400
Cc: Christian Hopps <chopps@chopps.org>, joel jaeggli <joelja@bogus.com>,
 NETMOD Working Group <netmod@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <57BCB4D8-D82F-43C9-8D05-2F52A174F37C@chopps.org>
References: <b45d1c39-c2f0-bcaf-61a4-9822ac04725a@bogus.com>
 <20181002203031.pcdclhq7vb5tohrj@anna.jacobs.jacobs-university.de>
To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/djLWU-FPruDDHk1YQGvAGNW7qy4>
Subject: Re: [netmod] WG LC draft-ietf-netmod-module-tags-02 - 10/2/18 -
 10/16/18
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>,
 <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>,
 <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Oct 2018 12:31:50 -0000


On Oct 2, 2018, at 4:30 PM, Juergen Schoenwaelder =
<j.schoenwaelder@jacobs-university.de> wrote:
> Not ready, comments posted earlier here:
>=20
> =
https://mailarchive.ietf.org/arch/msg/netmod/qUGyGIxHJKsEXZsG6r3P7R0nirg


Hi Re-quoting to keep the discussion on this thread.

> - What does this mean? In particular the second sentence makes me =
wonder.
>=20
>   Implementations MUST ensure that a modules tag list is consistent
>   across any location from which the list is accessible.  So if a user
>   adds a tag through configuration that tag should also be seen when
>   using any augmentation that exposes the modules tag list.

This text exists b/c originally the module tags list was being proposed =
to be accessible in 2 places, with a read-only version in a yang library =
augmentation. The WG decided that this read-only augmentation was not =
useful so we removed. It.  I'll remove this text as it's now more =
confusing than useful apparently. :)

> - Wording - suggest to remove 'types':
>=20
>    Tags may be IANA assigned or privately defined types.";

Done.

> - Leaf names:
>=20
>   module: ietf-module-tags
>       +--rw module-tags* [name]
>          +--rw name          yang:yang-identifier
>          +--rw tag*          string
>          +--rw masked-tag*   string
>=20
>   Name seems to refer to a module but this is not clear until you
>   read the description. I understand that in RFC 7895 and its bis we
>   also just use 'name' but I would find things easier to understand
>   if we would have this:
>=20
>   module: ietf-module-tags
>       +--rw module-tags* [module]
>          +--rw module        yang:yang-identifier
>          +--rw tags*         string
>          +--rw masked-tags*  string
>=20
>   Note that I also used plural for the leaf-lists.
>=20
>   In the description, I would also say "A list of tags associated
>   with..."  instead of "A tag associated with...".

I'll change it to module-name, and pluralize "tag" to "tags".

>=20
> - Editorial
>=20
>  s/This user/A user

Done

> - Adding and masking the same tag
>=20
>  What happens if config adds a tag and masks the same tag? Is the
>  masking taking priority in this case, i.e., you first all all tags
>  and then you filter those that are masked?

The mask takes precedence. I'll add text to clarify this.

> - Standard tags defined in description statements
>=20
>  I do not like this. YANG has extension statements and having to
>  parse stuff out of free text description statements seems to be a
>  movement backwards.

This is used by the human implementer of the module (i.e., they need to =
write code to implement the module). As such it was not intended for =
machine parsing.

> - System management
>=20
>  What is 'system management' and a 'system management protocol'?

These were derived from the work the RtgYangDT originally did where we =
were organizing everything under a single device tree. This tree concept =
was (rightly) abandoned to be replaced with use of tags. Examples of =
protocols would be Syslog, TACAC+, SNMP, Netconf, ... I've added that to =
the description.
=20
> - Tag format
>=20
>  Apparently, the colon has a special meaning in a tag string and
>  otherwise there do not seem to be any restrictions. (Which is good,
>  I can finally put various smileys on my gear.)
>=20
>  Should we state explicitly somewhere that a colon has a special
>  meaning and that tag strings are structured into a sequence of
>  'taggies' separated by colons? Or is definition by example good
>  enough?

I think it's good enough. :)

> - Meaning of tag masks
>=20
>  Do masks mean a complete string match or can I mask along the prefix
>  hierarchy, i.e., 'vendor:acme:' masks everything starting with
>  'vendor:acme:'?

Exact match, I've added text to clarify this.

>=20
> - Retrieval of the final list of tags
>=20
>  Once I have configured tags and masks, how do I obtain the resulting
>  tag list? Do I have to calculate this locally? Or will the final
>  list be found in the operational state datastore (i.e., the applied
>  config

No need to calculate locally, and yes the final list is found in =
operational state datastore.

The description of the "tags" list includes the following text:

             The operational view of this list will contain all
             user-configured tags as well as any predefined tags that
             have not been masked by the user using the masked-tag leaf
             list below.";

Thanks,
Chris.

>=20
> /js
>=20
> --=20
> Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>





> On Oct 2, 2018, at 4:30 PM, Juergen Schoenwaelder =
<j.schoenwaelder@jacobs-university.de> wrote:
>=20
> On Tue, Oct 02, 2018 at 01:21:04PM -0700, joel jaeggli wrote:
>> This is start of a two week working group last-call for
>> draft-ietf-netmod-module-tags-02 a current netmod working group
>> document.
>>=20
>> You may review at:
>> https://tools.ietf.org/html/draft-ietf-netmod-module-tags-02
>>=20
>> Please send email to the list indicating "yes/support" or "no/do not
>> support".  If indicating no, please state your reservations with the
>> document.  If yes, please also feel free to provide comments you'd =
like
>> to see addressed once the document is a WG document.
>=20
> Not ready, comments posted earlier here:
>=20
> =
https://mailarchive.ietf.org/arch/msg/netmod/qUGyGIxHJKsEXZsG6r3P7R0nirg
>=20
> /js
>=20
> --=20
> Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>
>=20
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod
>=20

